mbox series

[v4,0/6] Fix some Python Inferior methods

Message ID 20230714-py-inf-fixes-30615-v4-0-9189744d8547@adacore.com
Headers
Series Fix some Python Inferior methods |

Message

Tom Tromey July 14, 2023, 5:06 p.m. UTC 
  A user pointed out a bug in Inferior.search_memory.  This series is
the result.  Most of the patches are minor things I noticed while
working on the final patch, which fixes the bug.

Regression tested on x86-64 Fedora 36.

---
Changes in v4:
- Addressed review comments: test case output checking
- Link to v3: https://inbox.sourceware.org/gdb-patches/20230713-py-inf-fixes-30615-v3-0-26a024f30553@adacore.com

Changes in v3:
- Added some comments to the final patch
- Link to v2: https://inbox.sourceware.org/gdb-patches/20230711-py-inf-fixes-30615-v2-0-64a2540864e6@adacore.com

Changes in v2:
- Addressed review comments
- Added scoped_restore_current_inferior_for_memory patch
- Link to v1: https://inbox.sourceware.org/gdb-patches/20230707-py-inf-fixes-30615-v1-0-7792ab559530@adacore.com

---
Tom Tromey (6):
      Minor cleanups in py-inferior.exp
      Refactor py-inferior.exp
      Rename Python variable in py-inferior.exp
      Remove obsolete comment from gdbthread.h
      Introduce scoped_restore_current_inferior_for_memory
      Use correct inferior in Inferior.read_memory et al

 gdb/aix-thread.c                         | 18 ++-----
 gdb/gdbthread.h                          |  2 +-
 gdb/inferior.h                           | 29 +++++++++++
 gdb/proc-service.c                       | 10 +---
 gdb/python/py-inferior.c                 | 43 +++++++++++++---
 gdb/testsuite/gdb.python/py-inferior.exp | 84 ++++++++++++++++++++++++--------
 6 files changed, 135 insertions(+), 51 deletions(-)
---
base-commit: 23e46b680f6fa6fce45aaf6c004cab6be322fbf1
change-id: 20230707-py-inf-fixes-30615-668ef09475ab

Best regards,

Comments

Pedro Alves July 14, 2023, 6:09 p.m. UTC | #1 
On 2023-07-14 18:06, Tom Tromey wrote:
> A user pointed out a bug in Inferior.search_memory.  This series is
> the result.  Most of the patches are minor things I noticed while
> working on the final patch, which fixes the bug.
> 
> Regression tested on x86-64 Fedora 36.

For whole series:

Approved-By: Pedro Alves <pedro@palves.net>

Thanks.