Message ID | 20230709-trace-cleanups-v1-0-c410e1072fab@tromey.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 484833856DC8 for <patchwork@sourceware.org>; Sun, 9 Jul 2023 17:02:21 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 988DE3858C3A for <gdb-patches@sourceware.org>; Sun, 9 Jul 2023 17:01:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 988DE3858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id CE67D10047402 for <gdb-patches@sourceware.org>; Sun, 9 Jul 2023 17:01:48 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IXnAqeK0USPQoIXnAqCquu; Sun, 09 Jul 2023 17:01:48 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=YNRadTKx c=1 sm=1 tr=0 ts=64aae7fc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=phMC7obXDRZQt3g-U2QA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tl1XkVMTunhmwFiUAR2AxVC4jaFWKwtvNyJ0uGYaCws=; b=ZXrdT0qR2JYtmO0UCoj0FpWOug 1syRBIScwYCvPUCHaBeysd24NZaxStg5cDV4xNOwwCCuRQculAgVLwyW4psXo91VkovAD46ALYcJT mlAz6cFlu6evc9n0rEfnbQuH6; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:52250 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <tom@tromey.com>) id 1qIXnA-001oeb-1r for gdb-patches@sourceware.org; Sun, 09 Jul 2023 11:01:48 -0600 From: Tom Tromey <tom@tromey.com> Subject: [PATCH 0/8] Minor C++-ification and cleanup in trace targets Date: Sun, 09 Jul 2023 11:01:46 -0600 Message-Id: <20230709-trace-cleanups-v1-0-c410e1072fab@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAPrnqmQC/x3MQQrCQAxG4auUrB2Y6aBSryIu0vTXBnQsSZVC6 d07uvwW763kMIXTpVnJ8FXXd6lIh4Zk5PJA0KGa2tjmeI5dmI0FQZ7g8pk8ZObcpYTjSQaq0WS 46/IfXm/VPTtCb1xk/G1e7DOMtm0H73ZRFnkAAAA= To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qIXnA-001oeb-1r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net ([192.168.0.21]) [75.166.135.140]:52250 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Minor C++-ification and cleanup in trace targets
|
|
Message
Tom Tromey
July 9, 2023, 5:01 p.m. UTC
This series applies some minor C++-ification and cleanups to the trace targets. Regression tested on x86-64 Fedora 38. --- Tom Tromey (8): Remove a use of xfree Replace use of xfree with byte_vector Use unique_ptr for trace_filename Use unique_ptr for trace_dirname Use function_view in traceframe_walk_blocks Constify tfile_interp_line Move definition of ctf_target type Change 'handle_id' to be a local variable gdb/tracectf.c | 77 ++++++++++++++++++++++------------------------- gdb/tracefile-tfile.c | 82 ++++++++++++++++++++------------------------------- 2 files changed, 68 insertions(+), 91 deletions(-) --- base-commit: 4fb2abb59d16f6395162f2e8d9494cde4a37e4a1 change-id: 20230709-trace-cleanups-3aa3911e56cd Best regards,
Comments
On 7/9/23 10:01, Tom Tromey wrote: > This series applies some minor C++-ification and cleanups to the trace > targets. > > Regression tested on x86-64 Fedora 38. I've read through the series, and I don't see anything concerning here. Only ~340 more uses of xfree left. :-) Reviewed-by: Keith Seitz <keiths@redhat.com> Keith
> I've read through the series, and I don't see anything concerning here. > Only ~340 more uses of xfree left. :-) > Reviewed-by: Keith Seitz <keiths@redhat.com> Thanks, I'm going to check it in. Tom