Patchwork [19/19] Mark internel unistd functions hidden

login
register
mail settings
Submitter H.J. Lu
Date Oct. 14, 2015, 10:48 p.m.
Message ID <20151014224839.GF30911@intel.com>
Download mbox | patch
Permalink /patch/9157/
State New
Headers show

Comments

H.J. Lu - Oct. 14, 2015, 10:48 p.m.
Since internal unistd functions are only used internally in ld.so and
libc.so, they can be made hidden.

	[BZ #19122]
	* include/unistd.h (__libc_check_standard_fds): Add
	attribute_hidden.
	IS_IN (rtld)] (__access): Likewise.
	IS_IN (rtld)] (__brk): Likewise.
	IS_IN (rtld)] (__close): Likewise.
	IS_IN (rtld)] (__getcwd): Likewise.
	IS_IN (rtld)] (__getpid): Likewise.
	IS_IN (rtld)] (__libc_read): Likewise.
	IS_IN (rtld)] (__libc_write): Likewise.
	IS_IN (rtld)] (__lseek): Likewise.
	IS_IN (rtld)] (__profil): Likewise.
	IS_IN (rtld)] (__read): Likewise.
	IS_IN (rtld)] (__sbrk): Likewise.
---
 include/unistd.h | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Patch

diff --git a/include/unistd.h b/include/unistd.h
index fbba393..09a4c6e 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -158,7 +158,7 @@  rtld_hidden_proto (__libc_enable_secure)
 
 
 /* Various internal function.  */
-extern void __libc_check_standard_fds (void);
+extern void __libc_check_standard_fds (void) attribute_hidden;
 
 
 /* Internal name for fork function.  */
@@ -177,6 +177,20 @@  extern int __have_dup3 attribute_hidden;
 extern int __getlogin_r_loginuid (char *name, size_t namesize)
      attribute_hidden;
 
+#  if IS_IN (rtld)
+extern __typeof (__access) __access attribute_hidden;
+extern __typeof (__brk) __brk attribute_hidden;
+extern __typeof (__close) __close attribute_hidden;
+extern __typeof (__getcwd) __getcwd attribute_hidden;
+extern __typeof (__getpid) __getpid attribute_hidden;
+extern __typeof (__libc_read) __libc_read attribute_hidden;
+extern __typeof (__libc_write) __libc_write attribute_hidden;
+extern __typeof (__lseek) __lseek attribute_hidden;
+extern __typeof (__profil) __profil attribute_hidden;
+extern __typeof (__read) __read attribute_hidden;
+extern __typeof (__sbrk) __sbrk attribute_hidden;
+#  endif
+
 __END_DECLS
 # endif