diff mbox

Initialize terminal_state to terminal_is_ours

Message ID 1438107473-10965-1-git-send-email-patrick@parcs.ath.cx
State New, archived
Headers

Commit Message

Patrick Palka July 28, 2015, 6:17 p.m. UTC 
  Right now this variable is initialized to 0 i.e. terminal_is_inferior
and does not get set to terminal_is_ours until target_terminal_init() is
called.  This function only gets called when an inferiro is first
created.  In the meantime however, terminal_state would wrongly remain
terminal_is_inferior.

Tested on x86_64 Debian Stretch -- native, gdbserver and
extended-gdbserver.

gdb/ChangeLog:

	* target.c (terminal_state): Initialize to terminal_is_ours.
---
 gdb/target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pedro Alves July 28, 2015, 11:24 p.m. UTC | #1 
On 07/28/2015 07:17 PM, Patrick Palka wrote:
> Right now this variable is initialized to 0 i.e. terminal_is_inferior
> and does not get set to terminal_is_ours until target_terminal_init() is
> called.  This function only gets called when an inferiro is first
> created.  In the meantime however, terminal_state would wrongly remain
> terminal_is_inferior.
> 
> Tested on x86_64 Debian Stretch -- native, gdbserver and
> extended-gdbserver.
> 
> gdb/ChangeLog:
> 
> 	* target.c (terminal_state): Initialize to terminal_is_ours.

Whoops.  OK.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/target.c b/gdb/target.c
index 4e2d005..a39201d 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -444,7 +444,7 @@  enum terminal_state
     terminal_is_ours = 2
   };
 
-static enum terminal_state terminal_state;
+static enum terminal_state terminal_state = terminal_is_ours;
 
 /* See target.h.  */