| Submitter | Romain Naour |
|---|---|
| Date | April 10, 2015, 10:11 p.m. |
| Message ID | <1428703891-28920-1-git-send-email-romain.naour@openwide.fr> |
| Download | mbox | patch |
| Permalink | /patch/6153/ |
| State | New |
| Headers | show |
Comments
Romain Naour <romain.naour@openwide.fr> writes: > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c > index 1a40897..71d078a 100644 > --- a/gdb/gdbserver/linux-low.c > +++ b/gdb/gdbserver/linux-low.c > @@ -4933,7 +4933,7 @@ static int > linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p) > { > unsigned long text, text_end, data; > - int pid = lwpid_of (get_thread_lwp (current_inferior)); > + int pid = lwpid_of (current_inferior); The patch is OK to the mainline, with a ChangeLog entry. I don't know we'll have releases on 7.8 branch. Can you commit your patch to git mainline? or you want me to commit it for you.
Hi, Le 14/04/2015 11:24, Yao Qi a écrit : > Romain Naour <romain.naour@openwide.fr> writes: > >> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c >> index 1a40897..71d078a 100644 >> --- a/gdb/gdbserver/linux-low.c >> +++ b/gdb/gdbserver/linux-low.c >> @@ -4933,7 +4933,7 @@ static int >> linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p) >> { >> unsigned long text, text_end, data; >> - int pid = lwpid_of (get_thread_lwp (current_inferior)); >> + int pid = lwpid_of (current_inferior); > > The patch is OK to the mainline, with a ChangeLog entry. I don't know > we'll have releases on 7.8 branch. Thanks for your review, I'll send an updated patch rebased on master. If you are interested, take a look at gdb's build 7.8.2 result: http://autobuild.buildroot.net/?reason=gdb-7.8.2 gdb 7.9 is not yet tested by autobuilders. > > Can you commit your patch to git mainline? or you want me to commit it > for you. > Yes please, I don't have git access to commit my patch. Best regards, Romain Naour
Patch
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 1a40897..71d078a 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -4933,7 +4933,7 @@ static int linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p) { unsigned long text, text_end, data; - int pid = lwpid_of (get_thread_lwp (current_inferior)); + int pid = lwpid_of (current_inferior); errno = 0;
Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid must be retrieved from current_inferior. The change has not been made in the function linux_read_offsets(). Fixes: http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- gdb/gdbserver/linux-low.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)