Patchwork [24/36] breakpoint.h: move enum ‘print_stop_action’

login
register
mail settings
Submitter Pedro Alves
Date Feb. 9, 2015, 11:20 p.m.
Message ID <1423524046-20605-25-git-send-email-palves@redhat.com>
Download mbox | patch
Permalink /patch/5017/
State New
Headers show

Comments

Pedro Alves - Feb. 9, 2015, 11:20 p.m.
Building GDB in C++, we get:

  src/gdb/breakpoint.h:529:8: error: use of enum ‘print_stop_action’ without previous declaration

We can forward declare enums in C++.

gdb/ChangeLog:
2015-02-09  Pedro Alves  <palves@redhat.com>

	* breakpoint.h (enum print_stop_action): Move further up in the
	file.
---
 gdb/breakpoint.h | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)
Yao Qi - Feb. 11, 2015, 12:27 p.m.
Hi Pedro,

On 09/02/15 23:20, Pedro Alves wrote:
> Building GDB in C++, we get:
>
>    src/gdb/breakpoint.h:529:8: error: use of enum ‘print_stop_action’ without previous declaration
>
> We can forward declare enums in C++.

I think you meant "can't".  Patch is good to me.

Patch

diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index 100d4f2..ad91102 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -471,6 +471,26 @@  struct bp_location
   struct symtab *symtab;
 };
 
+/* The possible return values for print_bpstat, print_it_normal,
+   print_it_done, print_it_noop.  */
+enum print_stop_action
+{
+  /* We printed nothing or we need to do some more analysis.  */
+  PRINT_UNKNOWN = -1,
+
+  /* We printed something, and we *do* desire that something to be
+     followed by a location.  */
+  PRINT_SRC_AND_LOC,
+
+  /* We printed something, and we do *not* desire that something to be
+     followed by a location.  */
+  PRINT_SRC_ONLY,
+
+  /* We already printed all we needed to print, don't print anything
+     else.  */
+  PRINT_NOTHING
+};
+
 /* This structure is a collection of function pointers that, if available,
    will be called instead of the performing the default action for this
    bptype.  */
@@ -966,26 +986,6 @@  struct bpstat_what
     int is_longjmp;
   };
 
-/* The possible return values for print_bpstat, print_it_normal,
-   print_it_done, print_it_noop.  */
-enum print_stop_action
-  {
-    /* We printed nothing or we need to do some more analysis.  */
-    PRINT_UNKNOWN = -1,
-
-    /* We printed something, and we *do* desire that something to be
-       followed by a location.  */
-    PRINT_SRC_AND_LOC,
-
-    /* We printed something, and we do *not* desire that something to
-       be followed by a location.  */
-    PRINT_SRC_ONLY,
-
-    /* We already printed all we needed to print, don't print anything
-       else.  */
-    PRINT_NOTHING
-  };
-
 /* Tell what to do about this bpstat.  */
 struct bpstat_what bpstat_what (bpstat);