Patchwork Re: Time zone data

login
register
mail settings
Submitter Florian Weimer
Date Dec. 17, 2014, 8:39 a.m.
Message ID <54914136.30001@redhat.com>
Download mbox | patch
Permalink /patch/4292/
State New
Headers show

Comments

Florian Weimer - Dec. 17, 2014, 8:39 a.m.
On 12/16/2014 04:32 PM, Joseph Myers wrote:
> On Tue, 16 Dec 2014, Florian Weimer wrote:
>
>> We seem to have quite a few of time zone descriptions in timezone/, but they
>> have not been updated since 2009 or so.  I suppose these days, everyone uses
>> tzdata for system time zone data.
>>
>> Why do we keep these files?  Are they used in test cases?
>
> Yes, this data serves as test inputs only.  It's not been installed by
> glibc since:
>
> commit 482ff4dae91cf9a288284072d1a299868db7a634
> Author: Ulrich Drepper <drepper@gmail.com>
> Date:   Wed Mar 7 04:48:47 2012 -0500
>
>      Don't install timezone rule files

Ah, thanks.  What about this patch?
Dmitry Levin - Dec. 17, 2014, 10:24 a.m.
On Wed, Dec 17, 2014 at 09:39:18AM +0100, Florian Weimer wrote:
[...]
> Ah, thanks.  What about this patch?
[...]
> +one, which can refer entries in the syste, time zone database.  The

s/syste,/system/
Joseph Myers - Dec. 17, 2014, 3:20 p.m.
On Wed, 17 Dec 2014, Florian Weimer wrote:

> +osystem that doesn't support a time zone information database.

s/osystem/system/
Florian Weimer - Dec. 17, 2014, 3:25 p.m.
On 12/17/2014 04:20 PM, Joseph Myers wrote:
> On Wed, 17 Dec 2014, Florian Weimer wrote:
>
>> +osystem that doesn't support a time zone information database.
>
> s/osystem/system/

Oh, I really wasn't awake at that time.

Okay with this and Dmitry's fix?

Patch

From 6dd289c245227b9182155f5dbacad36cca54ee08 Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Wed, 17 Dec 2014 09:38:03 +0100
Subject: [PATCH] Update documentation references to the time zone database

As of commit 482ff4dae91cf9a288284072d1a299868db7a634, the database
is no longer installed by the GNU C Library.

2014-12-17  Florian Weimer  <fweimer@redhat.com>

	* manual/time.texi (TZ Variable): Update to reflect that the time
	zone database is no longer part of the installation.
	* timezone/README: Likewise.

diff --git a/manual/time.texi b/manual/time.texi
index 8a5f94e..45e5f57 100644
--- a/manual/time.texi
+++ b/manual/time.texi
@@ -2359,14 +2359,13 @@  different time zone, and would like times reported to you in the time
 zone local to you, rather than what is local to the computer.
 
 In POSIX.1 systems the value of the @code{TZ} variable can be in one of
-three formats.  With @theglibc{}, the most common format is the
-last one, which can specify a selection from a large database of time
-zone information for many regions of the world.  The first two formats
-are used to describe the time zone information directly, which is both
-more cumbersome and less precise.  But the POSIX.1 standard only
-specifies the details of the first two formats, so it is good to be
-familiar with them in case you come across a POSIX.1 system that doesn't
-support a time zone information database.
+three formats.  With @theglibc{}, the most common format is the last
+one, which can refer entries in the syste, time zone database.  The
+first two formats are used to describe the time zone information
+directly, which is both more cumbersome and less precise.  But the
+POSIX.1 standard only specifies the details of the first two formats, so
+it is good to be familiar with them in case you come across a POSIX.1
+osystem that doesn't support a time zone information database.
 
 The first format is used when there is no Daylight Saving Time (or
 summer time) in the local time zone:
@@ -2520,9 +2519,7 @@  subdirectories for geographical areas; for example,
 @file{America/New_York}, @file{Europe/London}, @file{Asia/Hong_Kong}.
 These data files are installed by the system administrator, who also
 sets @file{/etc/localtime} to point to the data file for the local time
-zone.  @Theglibc{} comes with a large database of time zone
-information for most regions of the world, which is maintained by a
-community of volunteers and put in the public domain.
+zone.
 
 @node Time Zone Functions
 @subsection Functions and Variables for Time Zones
diff --git a/timezone/README b/timezone/README
index 7a5e31c..7a8dc47 100644
--- a/timezone/README
+++ b/timezone/README
@@ -9,6 +9,8 @@  The files
 	backward systemv solar87 solar88 solar89
 	iso3166.tab zone.tab leapseconds yearistype
 come from the tzdata package by Arthur David Olson et.al.
+These data files are included here only for use by the test suite.
+They are not installed as part of the GNU C Library.
 
 Please check the ChangeLog files in the top level directory for the
 version of the tzcode and tzdata packages.
-- 
2.1.0