Patchwork [1/2] Remove unused includes in aarch64-tdep.c

login
register
mail settings
Submitter Simon Marchi
Date Dec. 3, 2019, 4:25 a.m.
Message ID <20191203042558.2694627-1-simon.marchi@polymtl.ca>
Download mbox | patch
Permalink /patch/36452/
State New
Headers show

Comments

Simon Marchi - Dec. 3, 2019, 4:25 a.m.
include-what-you-use reports:

../../../src/binutils-gdb/gdb/aarch64-tdep.c should remove these lines:
- #include "ax.h"  // lines 45-45
- #include "elf-bfd.h"  // lines 52-52
- #include "elf/aarch64.h"  // lines 53-53
- #include "infcall.h"  // lines 44-44
- #include "inferior.h"  // lines 24-24
- #include "language.h"  // lines 43-43

gdb/ChangeLog:

	* aarch64-tdep.c: Remove includes.
---
 gdb/aarch64-tdep.c | 7 -------
 1 file changed, 7 deletions(-)
Tom Tromey - Dec. 4, 2019, 5:45 p.m.
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> include-what-you-use reports:
[...]

These both seem fine to me.

Tom
Simon Marchi - Dec. 4, 2019, 6:48 p.m.
On 2019-12-04 12:45 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> include-what-you-use reports:
> [...]
> 
> These both seem fine to me.
> 
> Tom
> 

Thanks, I pushed them.

Patch

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index af186e4b1be5..1d5fb2001d38 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -21,7 +21,6 @@ 
 #include "defs.h"
 
 #include "frame.h"
-#include "inferior.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
 #include "dis-asm.h"
@@ -40,18 +39,12 @@ 
 #include "prologue-value.h"
 #include "target-descriptions.h"
 #include "user-regs.h"
-#include "language.h"
-#include "infcall.h"
-#include "ax.h"
 #include "ax-gdb.h"
 #include "gdbsupport/selftest.h"
 
 #include "aarch64-tdep.h"
 #include "aarch64-ravenscar-thread.h"
 
-#include "elf-bfd.h"
-#include "elf/aarch64.h"
-
 #include "record.h"
 #include "record-full.h"
 #include "arch/aarch64-insn.h"