Patchwork [review] Add a NEWS entry for multithreaded symbol loading

login
register
mail settings
Submitter Simon Marchi (Code Review)
Date Nov. 26, 2019, 10:01 p.m.
Message ID <gerrit.1574805680000.I263add6aae03b523f0870ad4d1e972eada4b382a@gnutoolchain-gerrit.osci.io>
Download mbox | patch
Permalink /patch/36275/
State New
Headers show

Comments

Simon Marchi (Code Review) - Nov. 26, 2019, 10:01 p.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/725
......................................................................

Add a NEWS entry for multithreaded symbol loading

Just to let people know that this is available and how to use it.

Also updates the description of the setting to say the default is 0.

gdb/ChangeLog:

2019-11-26  Christian Biesinger  <cbiesinger@google.com>

	* NEWS: Mention the new multithreaded symbol loading.

Change-Id: I263add6aae03b523f0870ad4d1e972eada4b382a
---
M gdb/NEWS
1 file changed, 5 insertions(+), 1 deletion(-)
Eli Zaretskii - Nov. 27, 2019, 4:55 a.m.
> Date: Tue, 26 Nov 2019 17:01:20 -0500
> From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> Cc: Christian Biesinger <cbiesinger@google.com>
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/725
> ......................................................................
> 
> Add a NEWS entry for multithreaded symbol loading
> 
> Just to let people know that this is available and how to use it.
> 
> Also updates the description of the setting to say the default is 0.
> 
> gdb/ChangeLog:
> 
> 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* NEWS: Mention the new multithreaded symbol loading.

OK, thanks.
Simon Marchi (Code Review) - Nov. 27, 2019, 6:03 p.m.
Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/725
......................................................................


Patch Set 1: Code-Review+1

Looks reasonable to me, but Eli should review.
Eli Zaretskii - Nov. 27, 2019, 6:23 p.m.
> Date: Wed, 27 Nov 2019 13:03:13 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> 
> Tom Tromey has posted comments on this change.
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/725
> ......................................................................
> 
> 
> Patch Set 1: Code-Review+1
> 
> Looks reasonable to me, but Eli should review.

I already did.

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 5fd0f41..0fa71d5 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -58,6 +58,10 @@ 
  with extensions .gdb, .py and .scm are supported as long as GDB was
  compiled with support for that language.
 
+* GDB now supports multithreaded symbol loading for higher performance.
+  This feature is still in testing, so it is disabled by default.  You
+  can turn it on using 'maint set worker-threads unlimited'.
+
 * Python API
 
   ** The gdb.Value type has a new method 'format_string' which returns a
@@ -152,7 +156,7 @@ 
 maint set worker-threads
 maint show worker-threads
   Control the number of worker threads that can be used by GDB.  The
-  default is "unlimited", which lets GDB choose a number that is
+  default is 0.  "unlimited" lets GDB choose a number that is
   reasonable.  Currently worker threads are only used when demangling
   the names of linker symbols.