Declare dwarf_always_disassemble in dwarf2read.h
Commit Message
[Simon, how's this? Compiles fine.]
And remove the declaration from dwarf2loc.c, for better typesafety.
gdb/ChangeLog:
2019-09-19 Christian Biesinger <cbiesinger@google.com>
* dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
* dwarf2read.h: Declare dwarf_always_disassemble.
---
gdb/dwarf2loc.c | 2 --
gdb/dwarf2read.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On 2019-09-19 12:31 a.m., Christian Biesinger via gdb-patches wrote:
> [Simon, how's this? Compiles fine.]
>
> And remove the declaration from dwarf2loc.c, for better typesafety.
LGTM, thanks,
Simon
On Thu, Sep 19, 2019 at 8:01 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-09-19 12:31 a.m., Christian Biesinger via gdb-patches wrote:
> > [Simon, how's this? Compiles fine.]
> >
> > And remove the declaration from dwarf2loc.c, for better typesafety.
>
> LGTM, thanks,
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
956bafb0de0..e86f08d28f4 HEAD -> master
Christian
@@ -46,8 +46,6 @@
#include "gdbsupport/underlying.h"
#include "gdbsupport/byte-vector.h"
-extern bool dwarf_always_disassemble;
-
static struct value *dwarf2_evaluate_loc_desc_full (struct type *type,
struct frame_info *frame,
const gdb_byte *data,
@@ -33,6 +33,8 @@ extern struct cmd_list_element *show_dwarf_cmdlist;
typedef struct dwarf2_per_cu_data *dwarf2_per_cu_ptr;
DEF_VEC_P (dwarf2_per_cu_ptr);
+extern bool dwarf_always_disassemble;
+
/* A descriptor for dwarf sections.
S.ASECTION, SIZE are typically initialized when the objfile is first