Fix g++ 9.1 build breakage

Message ID 20190821200558.257800-1-cbiesinger@google.com
State New, archived
Headers

Commit Message

Terekhov, Mikhail via Gdb-patches Aug. 21, 2019, 8:05 p.m. UTC
  gdb/ChangeLog:

2019-08-21  Christian Biesinger  <cbiesinger@google.com>

	* tui/tui-data.h (tui_gen_win_info): Add an =default
	move constructor, required by some GCC versions.
---
 gdb/tui/tui-data.h | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Tom Tromey Aug. 21, 2019, 8:08 p.m. UTC | #1
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> gdb/ChangeLog:
Christian> 2019-08-21  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* tui/tui-data.h (tui_gen_win_info): Add an =default
Christian> 	move constructor, required by some GCC versions.

Thank you for doing this.  This is ok.

FYI we discussed this on irc and it apparently could only be reproduced
with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Tom
  
Terekhov, Mikhail via Gdb-patches Aug. 21, 2019, 8:10 p.m. UTC | #2
On Wed, Aug 21, 2019 at 3:08 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * tui/tui-data.h (tui_gen_win_info): Add an =default
> Christian>      move constructor, required by some GCC versions.
>
> Thank you for doing this.  This is ok.
>
> FYI we discussed this on irc and it apparently could only be reproduced
> with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Thanks, pushed.

Christian
  

Patch

diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 6dfea41d49..f43035674d 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -55,6 +55,7 @@  protected:
   virtual void make_window ();
 
 public:
+  tui_gen_win_info (tui_gen_win_info &&) = default;
 
   virtual ~tui_gen_win_info ();