[gdb/testsuite] Mark ptype_union.exp as unsupported for cc-with-gdb-index

Message ID 20190621083306.GA29089@delia
State New, archived
Headers

Commit Message

Tom de Vries June 21, 2019, 8:33 a.m. UTC
  Hi,

When testing gdb with board cc-with-gdb-index, we run into:
...
FAIL: gdb.ada/ptype_union.exp: ptype global
FAIL: gdb.ada/ptype_union.exp: print global
...

The index is not supported for Ada (PR24713), and cc-with-gdb-index does not
add an index for Ada test-cases.  However, this test-case compiles C sources,
for which cc-with-gdb-index does add an index. In gdb we load the executable
containing the index and set the language to Ada, resulting in gdb trying to
handle something that is not supported.

Fix the fail by marking this unsupported.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Mark ptype_union.exp as unsupported for cc-with-gdb-index

gdb/testsuite/ChangeLog:

2019-06-21  Tom de Vries  <tdevries@suse.de>

	PR testsuite/24518
	PR ada/24713
	* gdb.ada/ptype_union.exp: Mark as unsupported if executable contains
	index.

---
 gdb/testsuite/gdb.ada/ptype_union.exp | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Tom Tromey June 21, 2019, 12:59 p.m. UTC | #1
Tom> The index is not supported for Ada (PR24713)

Yeah.  This is on my to-do list to look at sometime.

Tom> 2019-06-21  Tom de Vries  <tdevries@suse.de>

Tom> 	PR testsuite/24518
Tom> 	PR ada/24713
Tom> 	* gdb.ada/ptype_union.exp: Mark as unsupported if executable contains
Tom> 	index.

This is ok.  Thanks for doing this.

Tom
  

Patch

diff --git a/gdb/testsuite/gdb.ada/ptype_union.exp b/gdb/testsuite/gdb.ada/ptype_union.exp
index 4f33721c81..c27db1f292 100644
--- a/gdb/testsuite/gdb.ada/ptype_union.exp
+++ b/gdb/testsuite/gdb.ada/ptype_union.exp
@@ -19,6 +19,11 @@  if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
     return -1
 }
 
+if {[exec_has_index_section $binfile]} {
+    unsupported "Ada is not currently supported by the index (PR 24713)"
+    return -1
+}
+
 # The test case is written in C, because it was easy to make the
 # required type there; but the bug itself only happens in Ada.
 gdb_test "set lang ada" ""