diff mbox

[gdb/testsuite] Fix infoline-reloc-main-from-zero.exp compilation

Message ID 20190617101910.GA24372@delia
State New, archived
Headers

Commit Message

Tom de Vries June 17, 2019, 10:19 a.m. UTC 
  Hi,

When running gdb.base/infoline-reloc-main-from-zero.exp, I see:
...
Running gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp ...
gdb compile failed, ld: infoline-reloc-main-from-zero: \
  not enough room for program headers, try linking with -N
ld: final link failed: bad value
collect2: error: ld returned 1 exit status
UNTESTED: gdb.base/infoline-reloc-main-from-zero.exp: infoline-reloc-main-from-zero.exp
UNTESTED: gdb.base/infoline-reloc-main-from-zero.exp: failed to compile
...

Fix this by following the suggestion:
...
-set opts {debug "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00"}
+set opts {debug "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00 -Wl,-N"}
...

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Fix infoline-reloc-main-from-zero.exp compilation

gdb/testsuite/ChangeLog:

2019-06-17  Tom de Vries  <tdevries@suse.de>

	PR testsuite/24612
	* gdb.base/infoline-reloc-main-from-zero.exp: Add -Wl,-N to
	additional_flags.

---
 gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Tromey July 24, 2019, 1:36 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> gdb/testsuite/ChangeLog:

Tom> 2019-06-17  Tom de Vries  <tdevries@suse.de>

Tom> 	PR testsuite/24612
Tom> 	* gdb.base/infoline-reloc-main-from-zero.exp: Add -Wl,-N to
Tom> 	additional_flags.

Thank you for the patch.  This is ok.

Tom
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp b/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp
index 99f577004e..670f611466 100644
--- a/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp
+++ b/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp
@@ -29,7 +29,7 @@  if [get_compiler_info] {
 
 # Build executable with stripped startup code and text section starting at zero
 
-set opts {debug "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00"}
+set opts {debug "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00 -Wl,-N"}
 
 if {[build_executable $testfile.exp $testfile $srcfile $opts] == -1} {
     untested "failed to compile"