Patchwork Improve/fix the TUI's current source line highlight

login
register
mail settings
Submitter Pedro Alves
Date March 14, 2019, 5:47 p.m.
Message ID <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com>
Download mbox | patch
Permalink /patch/31854/
State New
Headers show

Comments

Pedro Alves - March 14, 2019, 5:47 p.m.
[trying again, this time with a tar.gz.  sourceware rejected the image/pngs
content type...]

With styling enabled, I think the way we display the TUI's
highlighted/current line is very ugly and distracting.  At least,
I can't seem to get used to it.  The problem in my view is that we
reverse foreground/background in colored text as well, leading to
a fuzzy rainbow of colors.

This patch changes that to something that I find much more sensible --
only reverse the default foreground/background colors, leave styled
text colors alone.  If the foreground color is not the default (because the
text was styled), leave the foreground color as is.  If
e.g., the terminal is fg=BLACK, and bg=WHITE, and the style wants to
print text in RED, reverse the background color (print in BLACK), but
still print the text in RED.

I've attached screenshots of before/after patch, with both
white-on-black (actually, linux-colors / grey-ish-on-black),
and black-on-white themes in my console (konsole).  Also attached
screenshots with styling disabled, so that you can see how the
after-patch versions look more like the unstyled output.

Note: The new ui_file_style::set_fg method isn't called set_foreground
instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).

WDYT?  

Eli, could you try this on Windows, see if it behaves as intended there?

gdb/ChangeLog:
yyyy-mm-dd  Pedro Alves  <palves@redhat.com>

	* tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
	New globals.
	(apply_style): New, factored out from ...
	(apply_ansi_escape): ... this.  Handle reverse video mode.
	(tui_set_reverse_mode): New function.
	* tui/tui-io.h (tui_set_reverse_mode): New declaration.
	* tui/tui-winsource.c (tui_show_source_line): Use
	tui_set_reverse_mode instead of setting A_STANDOUT.
	* ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
	New setter methods.
---
 gdb/tui/tui-io.c        | 99 ++++++++++++++++++++++++++++++++++++++++++-------
 gdb/tui/tui-io.h        |  3 ++
 gdb/tui/tui-winsource.c |  4 +-
 gdb/ui-style.h          | 18 +++++++++
 4 files changed, 109 insertions(+), 15 deletions(-)
John Baldwin - March 14, 2019, 7:55 p.m.
On 3/14/19 10:47 AM, Pedro Alves wrote:
> [trying again, this time with a tar.gz.  sourceware rejected the image/pngs
> content type...]
> 
> With styling enabled, I think the way we display the TUI's
> highlighted/current line is very ugly and distracting.  At least,
> I can't seem to get used to it.  The problem in my view is that we
> reverse foreground/background in colored text as well, leading to
> a fuzzy rainbow of colors.
> 
> This patch changes that to something that I find much more sensible --
> only reverse the default foreground/background colors, leave styled
> text colors alone.  If the foreground color is not the default (because the
> text was styled), leave the foreground color as is.  If
> e.g., the terminal is fg=BLACK, and bg=WHITE, and the style wants to
> print text in RED, reverse the background color (print in BLACK), but
> still print the text in RED.
> 
> I've attached screenshots of before/after patch, with both
> white-on-black (actually, linux-colors / grey-ish-on-black),
> and black-on-white themes in my console (konsole).  Also attached
> screenshots with styling disabled, so that you can see how the
> after-patch versions look more like the unstyled output.
> 
> Note: The new ui_file_style::set_fg method isn't called set_foreground
> instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).
> 
> WDYT?  

I prefer your version over the current approach.  I think we've decided
to forgo the idea, but if we had light and dark "themes" it would perhaps
make sense to use the other "theme" colors for the highlight bar.  Your
version is pretty close to that with the current single "theme".
Pedro Alves - March 14, 2019, 8:10 p.m.

Tom Tromey - March 15, 2019, 9:41 p.m.
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> This patch changes that to something that I find much more sensible --
Pedro> only reverse the default foreground/background colors, leave styled
Pedro> text colors alone.  If the foreground color is not the default (because the
Pedro> text was styled), leave the foreground color as is.

Pedro> I've attached screenshots of before/after patch

Finally we need screenshots for gdb!  I thought the day would never
come.

Pedro> Note: The new ui_file_style::set_fg method isn't called set_foreground
Pedro> instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).

Pedro> WDYT?  

Looks much better, please check this in.

Tom

Patch

diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index d006e41cab..2a77db9715 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -267,6 +267,15 @@  static int last_color_pair = -1;
 
 static ui_file_style last_style;
 
+/* If true, we're highlighting the current source line in reverse
+   video mode.  */
+static bool reverse_mode_p = true;
+
+/* The background/foreground colors before we entered reverse
+   mode.  */
+static ui_file_style::color reverse_save_bg (ui_file_style::NONE);
+static ui_file_style::color reverse_save_fg (ui_file_style::NONE);
+
 /* Given two colors, return their color pair index; making a new one
    if necessary.  */
 
@@ -291,21 +300,11 @@  get_color_pair (int fg, int bg)
   return it->second;
 }
 
-/* Apply an ANSI escape sequence from BUF to W.  BUF must start with
-   the ESC character.  If BUF does not start with an ANSI escape,
-   return 0.  Otherwise, apply the sequence if it is recognized, or
-   simply ignore it if not.  In this case, the number of bytes read
-   from BUF is returned.  */
+/* Apply STYLE to W.  */
 
-static size_t
-apply_ansi_escape (WINDOW *w, const char *buf)
+static void
+apply_style (WINDOW *w, ui_file_style style)
 {
-  ui_file_style style = last_style;
-  size_t n_read;
-
-  if (!style.parse (buf, &n_read))
-    return n_read;
-
   /* Reset.  */
   wattron (w, A_NORMAL);
   wattroff (w, A_BOLD);
@@ -351,9 +350,83 @@  apply_ansi_escape (WINDOW *w, const char *buf)
     wattron (w, A_REVERSE);
 
   last_style = style;
+}
+
+/* Apply an ANSI escape sequence from BUF to W.  BUF must start with
+   the ESC character.  If BUF does not start with an ANSI escape,
+   return 0.  Otherwise, apply the sequence if it is recognized, or
+   simply ignore it if not.  In this case, the number of bytes read
+   from BUF is returned.  */
+
+static size_t
+apply_ansi_escape (WINDOW *w, const char *buf)
+{
+  ui_file_style style = last_style;
+  size_t n_read;
+
+  if (!style.parse (buf, &n_read))
+    return n_read;
+
+  if (reverse_mode_p)
+    {
+      /* We want to reverse _only_ the default foreground/background
+	 colors.  If the foreground color is not the default (because
+	 the text was styled), we want to leave it as is.  If e.g.,
+	 the terminal is fg=BLACK, and bg=WHITE, and the style wants
+	 to print text in RED, we want to reverse the background color
+	 (print in BLACK), but still print the text in RED.  To do
+	 that, we enable the A_REVERSE attribute, and re-reverse the
+	 parsed-style's fb/bg colors.
+
+	 Notes on the approach:
+
+	  - there's no portable way to know which colors the default
+	    fb/bg colors map to.
+
+	  - this approach does the right thing even if you change the
+	    terminal colors while GDB is running -- the reversed
+	    colors automatically adapt.
+      */
+      if (!style.is_default ())
+	{
+	  ui_file_style::color bg = style.get_background ();
+	  ui_file_style::color fg = style.get_foreground ();
+	  style.set_fg (bg);
+	  style.set_bg (fg);
+	}
+
+      /* Enable A_REVERSE.  */
+      style.set_reverse (true);
+    }
+
+  apply_style (w, style);
   return n_read;
 }
 
+/* See tui.io.h.  */
+
+void
+tui_set_reverse_mode (WINDOW *w, bool reverse)
+{
+  ui_file_style style = last_style;
+
+  reverse_mode_p = reverse;
+  style.set_reverse (reverse);
+
+  if (reverse)
+    {
+      reverse_save_bg = style.get_background ();
+      reverse_save_fg = style.get_foreground ();
+    }
+  else
+    {
+      style.set_bg (reverse_save_bg);
+      style.set_fg (reverse_save_fg);
+    }
+
+  apply_style (w, style);
+}
+
 /* Print LENGTH characters from the buffer pointed to by BUF to the
    curses command window.  The output is buffered.  It is up to the
    caller to refresh the screen if necessary.  */
diff --git a/gdb/tui/tui-io.h b/gdb/tui/tui-io.h
index 8165b5bdfc..34a24da292 100644
--- a/gdb/tui/tui-io.h
+++ b/gdb/tui/tui-io.h
@@ -48,6 +48,9 @@  extern void tui_redisplay_readline (void);
 /* Expand TABs into spaces.  */
 extern char *tui_expand_tabs (const char *, int);
 
+/* Enter/leave reverse video mode.  */
+extern void tui_set_reverse_mode (WINDOW *w, bool reverse);
+
 extern struct ui_out *tui_out;
 extern cli_ui_out *tui_old_uiout;
 
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 7fd460bde3..310f605f8a 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -276,13 +276,13 @@  tui_show_source_line (struct tui_win_info *win_info, int lineno)
 
   line = win_info->generic.content[lineno - 1];
   if (line->which_element.source.is_exec_point)
-    wattron (win_info->generic.handle, A_STANDOUT);
+    tui_set_reverse_mode (win_info->generic.handle, true);
 
   wmove (win_info->generic.handle, lineno, 1);
   tui_puts (line->which_element.source.line,
 	    win_info->generic.handle);
   if (line->which_element.source.is_exec_point)
-    wattroff (win_info->generic.handle, A_STANDOUT);
+    tui_set_reverse_mode (win_info->generic.handle, false);
 
   /* Clear to end of line but stop before the border.  */
   wclrtoeol (win_info->generic.handle);
diff --git a/gdb/ui-style.h b/gdb/ui-style.h
index 04a1d448ba..2a87fbe801 100644
--- a/gdb/ui-style.h
+++ b/gdb/ui-style.h
@@ -180,18 +180,36 @@  struct ui_file_style
     return m_reverse;
   }
 
+  /* Set/clear the reverse display flag.  */
+  void set_reverse (bool reverse)
+  {
+    m_reverse = reverse;
+  }
+
   /* Return the foreground color of this style.  */
   const color &get_foreground () const
   {
     return m_foreground;
   }
 
+  /* Set the foreground color of this style.  */
+  void set_fg (color c)
+  {
+    m_foreground = c;
+  }
+
   /* Return the background color of this style.  */
   const color &get_background () const
   {
     return m_background;
   }
 
+  /* Set the background color of this style.  */
+  void set_bg (color c)
+  {
+    m_background = c;
+  }
+
   /* Return the intensity of this style.  */
   intensity get_intensity () const
   {