Patchwork Move remaining nptl_db headers to sysdeps/nptl

login
register
mail settings
Submitter Florian Weimer
Date Feb. 8, 2019, 10:14 p.m.
Message ID <87womahqr6.fsf@oldenburg2.str.redhat.com>
Download mbox | patch
Permalink /patch/31372/
State Committed
Headers show

Comments

Florian Weimer - Feb. 8, 2019, 10:14 p.m.
sys/procfs.h was already using this sysdeps directory.

This avoids the need for  nptl-specific wrapper headers under
include/, a generic location in the source tree.

2019-02-08  Florian Weimer  <fweimer@redhat.com>

	* nptl_db/proc_service.h: Move to ...
	* sysdeps/nptl/proc_service.h: ... here.
	* nptl_db/thread_db.h: Move to ...
	* sysdeps/nptl/thread_db.h: ... here.
	* nptl/descr.h: Include <thread_db.h>.
Florian Weimer - Feb. 15, 2019, 12:46 p.m.
* Florian Weimer:

> sys/procfs.h was already using this sysdeps directory.
>
> This avoids the need for  nptl-specific wrapper headers under
> include/, a generic location in the source tree.
>
> 2019-02-08  Florian Weimer  <fweimer@redhat.com>
>
> 	* nptl_db/proc_service.h: Move to ...
> 	* sysdeps/nptl/proc_service.h: ... here.
> 	* nptl_db/thread_db.h: Move to ...
> 	* sysdeps/nptl/thread_db.h: ... here.
> 	* nptl/descr.h: Include <thread_db.h>.
>
> diff --git a/nptl/descr.h b/nptl/descr.h
> index 9c54cbc8f2..4ef33ae465 100644
> --- a/nptl/descr.h
> +++ b/nptl/descr.h
> @@ -29,7 +29,7 @@
>  #include <lowlevellock.h>
>  #include <pthreaddef.h>
>  #include <dl-sysdep.h>
> -#include "../nptl_db/thread_db.h"
> +#include <thread_db.h>
>  #include <tls.h>
>  #include <unwind.h>
>  #include <bits/types/res_state.h>
> diff --git a/nptl_db/proc_service.h b/sysdeps/nptl/proc_service.h
> similarity index 100%
> rename from nptl_db/proc_service.h
> rename to sysdeps/nptl/proc_service.h
> diff --git a/nptl_db/thread_db.h b/sysdeps/nptl/thread_db.h
> similarity index 100%
> rename from nptl_db/thread_db.h
> rename to sysdeps/nptl/thread_db.h

Ping.  This patch still needs review.

Thanks,
Florian
Adhemerval Zanella Netto - Feb. 15, 2019, 4:47 p.m.
On 08/02/2019 20:14, Florian Weimer wrote:
> sys/procfs.h was already using this sysdeps directory.
> 
> This avoids the need for  nptl-specific wrapper headers under
> include/, a generic location in the source tree.
> 
> 2019-02-08  Florian Weimer  <fweimer@redhat.com>
> 
> 	* nptl_db/proc_service.h: Move to ...
> 	* sysdeps/nptl/proc_service.h: ... here.
> 	* nptl_db/thread_db.h: Move to ...
> 	* sysdeps/nptl/thread_db.h: ... here.
> 	* nptl/descr.h: Include <thread_db.h>.

LGTM, both proc_service.h and thread_db.h are installed on correct locations
and all abi continue to build.

> 
> diff --git a/nptl/descr.h b/nptl/descr.h
> index 9c54cbc8f2..4ef33ae465 100644
> --- a/nptl/descr.h
> +++ b/nptl/descr.h
> @@ -29,7 +29,7 @@
>  #include <lowlevellock.h>
>  #include <pthreaddef.h>
>  #include <dl-sysdep.h>
> -#include "../nptl_db/thread_db.h"
> +#include <thread_db.h>
>  #include <tls.h>
>  #include <unwind.h>
>  #include <bits/types/res_state.h>
> diff --git a/nptl_db/proc_service.h b/sysdeps/nptl/proc_service.h
> similarity index 100%
> rename from nptl_db/proc_service.h
> rename to sysdeps/nptl/proc_service.h
> diff --git a/nptl_db/thread_db.h b/sysdeps/nptl/thread_db.h
> similarity index 100%
> rename from nptl_db/thread_db.h
> rename to sysdeps/nptl/thread_db.h
>

Patch

diff --git a/nptl/descr.h b/nptl/descr.h
index 9c54cbc8f2..4ef33ae465 100644
--- a/nptl/descr.h
+++ b/nptl/descr.h
@@ -29,7 +29,7 @@ 
 #include <lowlevellock.h>
 #include <pthreaddef.h>
 #include <dl-sysdep.h>
-#include "../nptl_db/thread_db.h"
+#include <thread_db.h>
 #include <tls.h>
 #include <unwind.h>
 #include <bits/types/res_state.h>
diff --git a/nptl_db/proc_service.h b/sysdeps/nptl/proc_service.h
similarity index 100%
rename from nptl_db/proc_service.h
rename to sysdeps/nptl/proc_service.h
diff --git a/nptl_db/thread_db.h b/sysdeps/nptl/thread_db.h
similarity index 100%
rename from nptl_db/thread_db.h
rename to sysdeps/nptl/thread_db.h