Patchwork make-syscalls.sh: fix comment referencing syscall-template

login
register
mail settings
Submitter Vineet Gupta
Date Feb. 1, 2019, 12:16 a.m.
Message ID <1548980210-5289-1-git-send-email-vgupta@synopsys.com>
Download mbox | patch
Permalink /patch/31268/
State New
Headers show

Comments

Vineet Gupta - Feb. 1, 2019, 12:16 a.m.
spotted when started working on ARC port to glibc

---
 ChangeLog                     | 5 +++++
 sysdeps/unix/make-syscalls.sh | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
Carlos O'Donell - Feb. 1, 2019, 1:45 a.m.
On 1/31/19 7:16 PM, Vineet Gupta wrote:
> spotted when started working on ARC port to glibc
> 
> ---
>  ChangeLog                     | 5 +++++
>  sysdeps/unix/make-syscalls.sh | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 

Obviously correct :-)

Please commit to master which is open for development.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> diff --git a/ChangeLog b/ChangeLog
> index 93201b76a26b..8438f93e13a2 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-01-31  Vineet Gupta <vgupta@synopsys.com>
> +
> +	* sysdeps/unix/make-syscalls.sh: Fix comment referencing
> +	syscall-template file.
> +
>  2019-01-31  Paul Pluzhnikov  <ppluzhnikov@google.com>
>  
>  	[BZ #24051]
> diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh
> index e39b2d6d5214..6a5c10d54e87 100644
> --- a/sysdeps/unix/make-syscalls.sh
> +++ b/sysdeps/unix/make-syscalls.sh
> @@ -7,7 +7,7 @@
>  #
>  # This script is used to process the syscall data encoded in the various
>  # syscalls.list files to produce thin assembly syscall wrappers around the
> -# appropriate OS syscall. See syscall-template.s for more details on the
> +# appropriate OS syscall. See syscall-template.S for more details on the
>  # actual wrapper.
>  #
>  # Syscall Signature Prefixes:
>
Vineet Gupta - Feb. 1, 2019, 1:48 a.m.
On 1/31/19 5:45 PM, Carlos O'Donell wrote:
> On 1/31/19 7:16 PM, Vineet Gupta wrote:
>> spotted when started working on ARC port to glibc
>>
>> ---
>>  ChangeLog                     | 5 +++++
>>  sysdeps/unix/make-syscalls.sh | 2 +-
>>  2 files changed, 6 insertions(+), 1 deletion(-)
>>
> Obviously correct :-)

Changelog is bigger than the fix ;-)

> Please commit to master which is open for development.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>


I'm not sure if I have access credentials to commit to *the* glibc repo ?
Carlos O'Donell - Feb. 1, 2019, 3:46 a.m.
On 1/31/19 8:48 PM, Vineet Gupta wrote:
> On 1/31/19 5:45 PM, Carlos O'Donell wrote:
>> On 1/31/19 7:16 PM, Vineet Gupta wrote:
>>> spotted when started working on ARC port to glibc
>>>
>>> ---
>>>  ChangeLog                     | 5 +++++
>>>  sysdeps/unix/make-syscalls.sh | 2 +-
>>>  2 files changed, 6 insertions(+), 1 deletion(-)
>>>
>> Obviously correct :-)
> 
> Changelog is bigger than the fix ;-)
> 
>> Please commit to master which is open for development.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> 
> I'm not sure if I have access credentials to commit to *the* glibc repo ?
> 

Pushed. Thank you :-)

commit d5627550ae99d10dfad216910ffa774f60460123 (HEAD -> master, origin/master, origin/HEAD)
Author: Vineet Gupta <vgupta@synopsys.com>
Date:   Thu Jan 31 22:45:10 2019 -0500

    make-syscalls.sh: fix comment referencing syscall-template

Patch

diff --git a/ChangeLog b/ChangeLog
index 93201b76a26b..8438f93e13a2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-01-31  Vineet Gupta <vgupta@synopsys.com>
+
+	* sysdeps/unix/make-syscalls.sh: Fix comment referencing
+	syscall-template file.
+
 2019-01-31  Paul Pluzhnikov  <ppluzhnikov@google.com>
 
 	[BZ #24051]
diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh
index e39b2d6d5214..6a5c10d54e87 100644
--- a/sysdeps/unix/make-syscalls.sh
+++ b/sysdeps/unix/make-syscalls.sh
@@ -7,7 +7,7 @@ 
 #
 # This script is used to process the syscall data encoded in the various
 # syscalls.list files to produce thin assembly syscall wrappers around the
-# appropriate OS syscall. See syscall-template.s for more details on the
+# appropriate OS syscall. See syscall-template.S for more details on the
 # actual wrapper.
 #
 # Syscall Signature Prefixes: