Message ID | a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org |
---|---|
State | New, archived |
Headers |
Received: (qmail 89729 invoked by alias); 12 Dec 2018 07:46:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 89652 invoked by uid 89); 12 Dec 2018 07:46:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy= X-HELO: mail.aegee.org Received: from mail.aegee.org (HELO mail.aegee.org) (144.76.142.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Dec 2018 07:46:11 +0000 Authentication-Results: mail.aegee.org/wBC7k6Yp002056; auth=pass (PLAIN) smtp.auth=didopalauzov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1544600768; i=dkim+MSA-tls@aegee.org; r=y; bh=v38OJcZKg4pP3O8vPOjUcmNLRU1yKwzp5zlu1AORV5Q=; h=Subject:From:To:Date; b=Yyfmx4Ac4mfGoGbO6nvtut/WVyRh0l2WFLbeftTROfbYdmEIbalyAlBEEsc581o3R 1aGOoRfYVTTnOyJerwaS+HwyAq0gGQMsfZ1z2WCrz4sR1vZQEb6xXGVDwwfDz0Yax+ 51zY79SeFFqRhrlbTQpKrgIqQ4QQwze38Twk69VZVSbg7c5VIXQXERSiZ31IvYfhMj au9f17MwVdY/0JXaZpIZNXfz0rLMk5PElyK4zH3if+WAMC4/VMoEGTGI9CUAju0J/O ru2DYT9n8W9/bQojiTkA6nIpVr5eGwyFZXOGMEUXrCJ1gTr0Fg6KuDTNzOTxWA9h4+ p+W3iosDFnbHbUCMqlhuz9rOxY3daIrZY4rx6OF2eWAUedO5nLaTpyClIIETQoS0/k d/YhVr6uA2fiKWmYS47rFeo84YHwblbOuJwNvjHjqq9644XdadP1G8aJaqbJJaQ38A 6CGLnPfjqzq59Z7E4CV8UXnpyerbWqX/n1HNbYllxfo112ZtIN7FLvvhJWMGpuvdLE 7UQE7ywabmNykgydhvEGIQSu40Io1qJmpK8rLdR59nPQ9Rxs0/67MPb8tbMAiMJWHK mqaoWekJ9IeL/sNHB1F6Hf0TwKyPl/uVUqeq62pnwLxqrJuK0xMTikwlvJJbTvSD2R PMMCdHtcL5Ac9cpT/sJ1/vaA= Authentication-Results: mail.aegee.org/wBC7k6Yp002056; dkim=none Received: from Tylan (37-219-194-104.nat.bb.dnainternet.fi [37.219.194.104]) (authenticated bits=0) by mail.aegee.org (8.15.2/8.15.2) with ESMTPSA id wBC7k6Yp002056 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <gdb-patches@sourceware.org>; Wed, 12 Dec 2018 07:46:07 GMT Message-ID: <a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org> Subject: Don't build readline/libreadline.a, when --with-system-readline is supplied From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= <dilyan.palauzov@aegee.org> To: gdb-patches@sourceware.org Date: Wed, 12 Dec 2018 07:46:03 +0000 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.31.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes |
Commit Message
Дилян Палаузов
Dec. 12, 2018, 7:46 a.m. UTC
https://sourceware.org/bugzilla/show_bug.cgi?id=18632 The bundled libreadline is always built, even if the system is ./configure'd --with-system-readline and the build libreadline.a is not used. Proposed patch: Fix ./configure.ac not to proceed readline/, when --with-system- readline is provided # it's not even worth trying to configure, much less build, that tool.
Comments
On Wed, 2018-12-12 at 07:46 +0000, Дилян Палаузов wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=18632 > > The bundled libreadline is always built, even if the system is > ./configure'd --with-system-readline and the build libreadline.a is not > used. > > Proposed patch: > > Fix ./configure.ac not to proceed readline/, when --with-system- > readline is provided > > diff --git a/configure.ac b/configure.ac > index 159f968..adf6dfb 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then > noconfigdirs="$noconfigdirs zlib" > fi > > +# Don't compile the bundled readline/libreadline.a if --with-system- > readline > +# is provided. > +if test x$with_system_readline = xyes ; then > + noconfigdirs="$noconfigdirs readline" > +fi > + > # some tools are so dependent upon X11 that if we're not building with > X, > # it's not even worth trying to configure, much less build, that tool.
On 2018-12-12 02:46, Дилян Палаузов wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=18632 > > The bundled libreadline is always built, even if the system is > ./configure'd --with-system-readline and the build libreadline.a is not > used. > > Proposed patch: > > Fix ./configure.ac not to proceed readline/, when --with-system- > readline is provided > > diff --git a/configure.ac b/configure.ac > index 159f968..adf6dfb 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then > noconfigdirs="$noconfigdirs zlib" > fi > > +# Don't compile the bundled readline/libreadline.a if --with-system- > readline > +# is provided. > +if test x$with_system_readline = xyes ; then > + noconfigdirs="$noconfigdirs readline" > +fi > + > # some tools are so dependent upon X11 that if we're not building with > X, > # it's not even worth trying to configure, much less build, that tool. Thanks. I've tested it and pushed it (with the generated configure and the matching ChangeLog entry). For those who wonder, Joseph Myers suggested we take care of this patch in GDB and then sync it with gcc [1]. Simon [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html
On 1/3/19 06:09, Simon Marchi wrote: > On 2018-12-12 02:46, Дилян Палаузов wrote: >> https://sourceware.org/bugzilla/show_bug.cgi?id=18632 >> >> The bundled libreadline is always built, even if the system is >> ./configure'd --with-system-readline and the build libreadline.a is not >> used. >> >> Proposed patch: >> >> Fix ./configure.ac not to proceed readline/, when --with-system- >> readline is provided >> >> diff --git a/configure.ac b/configure.ac >> index 159f968..adf6dfb 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then >> noconfigdirs="$noconfigdirs zlib" >> fi >> >> +# Don't compile the bundled readline/libreadline.a if --with-system- >> readline >> +# is provided. >> +if test x$with_system_readline = xyes ; then >> + noconfigdirs="$noconfigdirs readline" >> +fi >> + >> # some tools are so dependent upon X11 that if we're not building with >> X, >> # it's not even worth trying to configure, much less build, that tool. > > Thanks. I've tested it and pushed it (with the generated configure and > the matching ChangeLog entry). > > For those who wonder, Joseph Myers suggested we take care of this patch > in GDB and then sync it with gcc [1]. > Which never happened, and therefore a recent sync from gcc repo dropped this patch, so I reopened https://sourceware.org/bugzilla/show_bug.cgi?id=18632. Thanks, - Tom > Simon > > [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html
diff --git a/configure.ac b/configure.ac index 159f968..adf6dfb 100644 --- a/configure.ac +++ b/configure.ac @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then noconfigdirs="$noconfigdirs zlib" fi +# Don't compile the bundled readline/libreadline.a if --with-system- readline +# is provided. +if test x$with_system_readline = xyes ; then + noconfigdirs="$noconfigdirs readline" +fi + # some tools are so dependent upon X11 that if we're not building with X,