Patchwork [1/3] benchtests: keep comparing even if function timings do not match

login
register
mail settings
Submitter leonardo.sandoval.gonzalez@linux.intel.com
Date Dec. 10, 2018, 11:05 p.m.
Message ID <20181210230504.13571-2-leonardo.sandoval.gonzalez@linux.intel.com>
Download mbox | patch
Permalink /patch/30614/
State New
Headers show

Comments

leonardo.sandoval.gonzalez@linux.intel.com - Dec. 10, 2018, 11:05 p.m.
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

---
 benchtests/scripts/compare_bench.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Siddhesh Poyarekar - Dec. 11, 2018, 6:36 a.m.
On 11/12/18 4:35 AM, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

Please add a ChangeLog entry and an explanation describing the rationale 
for the patch.

Thanks,
Siddhesh

> 
> ---
>   benchtests/scripts/compare_bench.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
> index f4b7742f90..9cbbda6be6 100755
> --- a/benchtests/scripts/compare_bench.py
> +++ b/benchtests/scripts/compare_bench.py
> @@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold):
>               # timing info for the function variant.
>               if 'timings' not in pts1['functions'][func][var].keys() or \
>                   'timings' not in pts2['functions'][func][var].keys():
> -                    return
> +                    continue
>   
>               # If two lists do not have the same length then it is likely that
>               # the performance characteristics of the function have changed.
>

Patch

diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
index f4b7742f90..9cbbda6be6 100755
--- a/benchtests/scripts/compare_bench.py
+++ b/benchtests/scripts/compare_bench.py
@@ -77,7 +77,7 @@  def compare_runs(pts1, pts2, threshold):
             # timing info for the function variant.
             if 'timings' not in pts1['functions'][func][var].keys() or \
                 'timings' not in pts2['functions'][func][var].keys():
-                    return
+                    continue
 
             # If two lists do not have the same length then it is likely that
             # the performance characteristics of the function have changed.