Patchwork [FYI] Avoid two uninitialized warnings from gcc

login
register
mail settings
Submitter Tom Tromey
Date Oct. 4, 2018, 2:59 a.m.
Message ID <20181004025904.13081-1-tom@tromey.com>
Download mbox | patch
Permalink /patch/29642/
State New
Headers show

Comments

Tom Tromey - Oct. 4, 2018, 2:59 a.m.
This avoids a couple of uninitialized warnings from gcc by
initializing the object in question.  The one in coffread.c seems like
it could be a latent bug.  The one in scm-value.c is harmless, but GCC
can't see that.

gdb/ChangeLog
2018-10-03  Tom Tromey  <tom@tromey.com>

	* guile/scm-value.c (gdbscm_value_to_string): Initialize
	"buffer_contents".
	* coffread.c (coff_symtab_read): Initialize "newobj".
---
 gdb/ChangeLog         | 6 ++++++
 gdb/coffread.c        | 2 +-
 gdb/guile/scm-value.c | 3 ++-
 3 files changed, 9 insertions(+), 2 deletions(-)

Patch

diff --git a/gdb/coffread.c b/gdb/coffread.c
index 81465d6385..623467d38b 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -781,7 +781,7 @@  coff_symtab_read (minimal_symbol_reader &reader,
 		  struct objfile *objfile)
 {
   struct gdbarch *gdbarch = get_objfile_arch (objfile);
-  struct context_stack *newobj;
+  struct context_stack *newobj = nullptr;
   struct coff_symbol coff_symbol;
   struct coff_symbol *cs = &coff_symbol;
   static struct internal_syment main_sym;
diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c
index 18558605d0..ca0c075f5c 100644
--- a/gdb/guile/scm-value.c
+++ b/gdb/guile/scm-value.c
@@ -966,7 +966,8 @@  gdbscm_value_to_string (SCM self, SCM rest)
   int encoding_arg_pos = -1, errors_arg_pos = -1, length_arg_pos = -1;
   char *encoding = NULL;
   SCM errors = SCM_BOOL_F;
-  gdb_byte *buffer_contents;
+  /* Avoid an uninitialized warning from gcc.  */
+  gdb_byte *buffer_contents = nullptr;
   int length = -1;
   const char *la_encoding = NULL;
   struct type *char_type = NULL;