diff mbox

[gdb/testsuite] Fix regexp in py-rbreak.exp

Message ID 20180803175159.ygcc5r7jwtt6zqqz@delia
State New, archived
Headers

Commit Message

Tom de Vries Aug. 3, 2018, 5:51 p.m. UTC 
  Hi,

this fails for me on openSUSE Leap 15.0:
...
FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
...

The rbreak "" command expects 11 breaks, but I see two extra for
__libc_csu_fini and __libc_csu_init:
...
Breakpoint 13 at 0x4005b0: file elf-init.c, line 106.^M
Breakpoint 14 at 0x400540: file elf-init.c, line 68.^M
...

This patch fixes the failing test by excluding functions starting with an
underscore.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Fix regexp in py-rbreak.exp

---
 gdb/testsuite/gdb.python/py-rbreak.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


OK for trunk?

Comments

Tom Tromey Aug. 3, 2018, 6:44 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> This patch fixes the failing test by excluding functions starting with an
Tom> underscore.

Tom> Tested on x86_64-linux.

Tom> OK for trunk?

Yes, this is ok.  Thanks.

Tom
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp
index 97ebd79f67..8e68402179 100644
--- a/gdb/testsuite/gdb.python/py-rbreak.exp
+++ b/gdb/testsuite/gdb.python/py-rbreak.exp
@@ -33,7 +33,7 @@  if ![runto_main] then {
 }
 
 gdb_test_no_output "nosharedlibrary"
-gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \
+gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"^\[^_\]\",minsyms=False)" \
     "get all function breakpoints" 0
 gdb_test "py print(len(sl))" "11" \
     "check number of returned breakpoints is 11"