diff mbox

[OB,gdb/testsuite] Make noclone conditional in vla-optimized-out.c

Message ID 20180720150532.e7dvwtbzyysqwcld@delia
State New, archived
Headers

Commit Message

Tom de Vries July 20, 2018, 3:05 p.m. UTC 
  Hi,

Make the noclone attribute on f1 in vla-optimized-out.c conditional.  This
makes the test-case by default identical to
gcc/testsuite/gcc.dg/guality/vla-1.c.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Make noclone conditional in vla-optimized-out.c

2018-07-20  Tom de Vries  <tdevries@suse.de>

	* gdb.base/vla-optimized-out.c: Make noclone attribute conditional on
	NOCLONE macro.
	* gdb.base/vla-optimized-out.exp: Use additional_flags -DNOCLONE.

---
 gdb/testsuite/gdb.base/vla-optimized-out.c   | 7 ++++++-
 gdb/testsuite/gdb.base/vla-optimized-out.exp | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

Comments

Tom Tromey July 25, 2018, 7:18 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Hi,
Tom> Make the noclone attribute on f1 in vla-optimized-out.c conditional.  This
Tom> makes the test-case by default identical to
Tom> gcc/testsuite/gcc.dg/guality/vla-1.c.

Tom> Tested on x86_64-linux.

Tom> OK for trunk?

I think this was included in a different patch of yours?
Anyway, it is ok, thank you.

It seems like it would be good to mention the GCC file in one of these
files.  If you want to add a comment to that effect, it is pre-approved.

Tom
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.c b/gdb/testsuite/gdb.base/vla-optimized-out.c
index 913e8ea867..ec0a6fdd80 100644
--- a/gdb/testsuite/gdb.base/vla-optimized-out.c
+++ b/gdb/testsuite/gdb.base/vla-optimized-out.c
@@ -15,7 +15,12 @@ 
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-int __attribute__((noinline, noclone))
+int
+#ifdef NOCLONE
+__attribute__((noinline, noclone))
+#else
+__attribute__((noinline))
+#endif
 f1 (int i)
 {
   char a[i + 1];
diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.exp b/gdb/testsuite/gdb.base/vla-optimized-out.exp
index 39abb795c8..b27569ed1e 100644
--- a/gdb/testsuite/gdb.base/vla-optimized-out.exp
+++ b/gdb/testsuite/gdb.base/vla-optimized-out.exp
@@ -18,7 +18,7 @@ 
 standard_testfile
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \
-	  {debug optimize=-O1}] } {
+	  {debug optimize=-O1 additional_flags=-DNOCLONE}] } {
     return -1
 }