| Message ID | fe13fbb5-e4b9-7af6-801d-070e84496ef3@ericsson.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 118491 invoked by alias); 15 Jun 2018 15:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118372 invoked by uid 89); 15 Jun 2018 15:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=unavailable version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Jun 2018 15:14:24 +0000 Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 77.D9.31169.BC7D32B5; Fri, 15 Jun 2018 17:14:19 +0200 (CEST) Received: from ESESBMR506.ericsson.se (153.88.183.202) by ESESSHC023.ericsson.se (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 15 Jun 2018 17:14:18 +0200 Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESBMR506.ericsson.se (153.88.183.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 15 Jun 2018 17:14:18 +0200 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 15 Jun 2018 17:14:18 +0200 Received: from [142.133.60.240] (192.75.88.130) by BN7PR15MB2387.namprd15.prod.outlook.com (2603:10b6:406:8c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Fri, 15 Jun 2018 15:14:15 +0000 Subject: Re: [PATCH 1/2] Bump to autoconf 2.69 and automake 1.15.1 To: Nick Clifton <nickc@redhat.com>, Simon Marchi <simon.marchi@polymtl.ca>, <gdb-patches@sourceware.org>, <binutils@sourceware.org> References: <20180615004309.29913-1-simon.marchi@polymtl.ca> <df0ee0e1-8e97-ffb6-edb2-c0aee39b262f@redhat.com> <eeeca5ba-4f35-7deb-78fc-3eb73bf6f31a@ericsson.com> <2845ca26-32ad-5b7f-0872-bff6c062cbe0@redhat.com> From: Simon Marchi <simon.marchi@ericsson.com> Message-ID: <fe13fbb5-e4b9-7af6-801d-070e84496ef3@ericsson.com> Date: Fri, 15 Jun 2018 11:14:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <2845ca26-32ad-5b7f-0872-bff6c062cbe0@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0088.namprd05.prod.outlook.com (2603:10b6:803:22::26) To BN7PR15MB2387.namprd15.prod.outlook.com (2603:10b6:406:8c::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e231280-e13f-49b0-c9de-08d5d2d2a8a9 X-MS-TrafficTypeDiagnostic: BN7PR15MB2387: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Forefront-PRVS: 0704670F76 Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2018 15:14:15.2054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e231280-e13f-49b0-c9de-08d5d2d2a8a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2387 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
June 15, 2018, 3:14 p.m. UTC
On 2018-06-15 10:58 AM, Nick Clifton wrote: > Hi Simon, > >>> Also the config/override.m4 file still contains a hard coded requirement >>> for autoconf 2.64 exactly. >> >> Are you talking about this? >> >> dnl Fix 2.64 cross compile detection for AVR and RTEMS >> dnl by not trying to compile fopen. >> m4_if(m4_defn([m4_PACKAGE_VERSION]), [2.64], >> [m4_foreach([_GCC_LANG], [C, C++, Fortran, Fortran 77], >> [m4_define([_AC_LANG_IO_PROGRAM(]_GCC_LANG[)], m4_defn([AC_LANG_PROGRAM(]_GCC_LANG[)]))])]) > > Nope - this: > > dnl Ensure exactly this Autoconf version is used > m4_ifndef([_GCC_AUTOCONF_VERSION], > [m4_define([_GCC_AUTOCONF_VERSION], [2.64])]) > > Around line 30 in <binutils-src>/config/override.m4. My patch contains this hunk, doesn't it?
Comments
Hi Simon, > My patch contains this hunk, doesn't it? Nope! But that is the change that I was expecting. :-) > diff --git a/config/override.m4 b/config/override.m4 > index b5ce6545ab69..d3e815bb1b40 100644 > --- a/config/override.m4 > +++ b/config/override.m4 > @@ -29,7 +29,7 @@ m4_copy_force([_AC_PREREQ], [AC_PREREQ]) > > dnl Ensure exactly this Autoconf version is used > m4_ifndef([_GCC_AUTOCONF_VERSION], > - [m4_define([_GCC_AUTOCONF_VERSION], [2.64])]) > + [m4_define([_GCC_AUTOCONF_VERSION], [2.69])]) Cheers Nick
On 2018-06-15 11:30 AM, Nick Clifton wrote: > Hi Simon, > >> My patch contains this hunk, doesn't it? > > Nope! But that is the change that I was expecting. :-) I'm confused, we must not be looking at the same thing! Go here: https://sourceware.org/ml/gdb-patches/2018-06/msg00385.html Search for diff --git a/config/override.m4 b/config/override.m4 What do you see? Simon
Hi Simon, > Go here: > > https://sourceware.org/ml/gdb-patches/2018-06/msg00385.html Ah - I only applies the second part of the patch: https://sourceware.org/ml/gdb-patches/2018-06/msg00386.html Oops! Cheers Nick
diff --git a/config/override.m4 b/config/override.m4 index b5ce6545ab69..d3e815bb1b40 100644 --- a/config/override.m4 +++ b/config/override.m4 @@ -29,7 +29,7 @@ m4_copy_force([_AC_PREREQ], [AC_PREREQ]) dnl Ensure exactly this Autoconf version is used m4_ifndef([_GCC_AUTOCONF_VERSION], - [m4_define([_GCC_AUTOCONF_VERSION], [2.64])]) + [m4_define([_GCC_AUTOCONF_VERSION], [2.69])]) dnl Test for the exact version when AC_INIT is expanded. dnl This allows to update the tree in steps (for testing)