Patchwork [v2] This patch replaces the linear search in find_pc_sect_line with a binary search for faster performance.

login
register
mail settings
Submitter Stephen Roberts
Date March 13, 2018, 5:39 p.m.
Message ID <1520962763-24018-1-git-send-email-stephen.roberts@arm.com>
Download mbox | patch
Permalink /patch/26300/
State New
Headers show

Comments

Stephen Roberts - March 13, 2018, 5:39 p.m.
I've made all the suggested changes except for one - I break on a specific line because the code is templatized so I can't set breakpoints on specific methods.
I know I could use rbreak, but I feel that this would make the test less clear and would include the overhead of looking up functions by regex, which is not relevant to this fix.
If you still think I should go ahead and use rbreak, let me know.

My (condensed) test results are as follows:

testsuite/perftest.sum with fix:
template-breakpoints cpu_time 1 1.3e-05, min 1.3e-05, max 1.3e-05, data [1.3000000000040757e-05]
...
template-breakpoints cpu_time 8 3.15342, min 3.15342, max 3.15342, data [3.153419999999999]
template-breakpoints cpu_time 9 3.604275, min 3.604275, max 3.604275, data [3.6042750000000012]
template-breakpoints wall_time 1 1.78813934326e-05, min 1.78813934326e-05, max 1.78813934326e-05, data [1.7881393432617188e-05]
...
template-breakpoints wall_time 8 3.1534011364, min 3.1534011364, max 3.1534011364, data [3.1534011363983154]
template-breakpoints wall_time 9 3.60431694984, min 3.60431694984, max 3.60431694984, data [3.6043169498443604]
template-breakpoints vmsize 1 432200, min 432200, max 432200, data [432200]
...
template-breakpoints vmsize 8 432200, min 432200, max 432200, data [432200]
template-breakpoints vmsize 9 432200, min 432200, max 432200, data [432200]

testsuite/perftest.sum without fix:
template-breakpoints cpu_time 1 2.10000000003e-05, min 2.10000000003e-05, max 2.10000000003e-05, data [2.1000000000270802e-05]
...
template-breakpoints cpu_time 8 20.710144, min 20.710144, max 20.710144, data [20.710144]
template-breakpoints cpu_time 9 22.907159, min 22.907159, max 22.907159, data [22.907158999999993]
template-breakpoints wall_time 1 2.19345092773e-05, min 2.19345092773e-05, max 2.19345092773e-05, data [2.193450927734375e-05]
...
template-breakpoints wall_time 8 20.7102570534, min 20.7102570534, max 20.7102570534, data [20.710257053375244]
template-breakpoints wall_time 9 22.9072520733, min 22.9072520733, max 22.9072520733, data [22.907252073287964]
template-breakpoints vmsize 1 432200, min 432200, max 432200, data [432200]
...
template-breakpoints vmsize 8 432200, min 432200, max 432200, data [432200]
template-breakpoints vmsize 9 432200, min 432200, max 432200, data [432200]


This patch addresses slowness when setting breakpoints, especially in
heavily templatized code. Profiling showed that find_pc_sect_line in
symtab.c was the performance bottleneck.  The original logic performed a
linear search over ordered data. This patch uses a binary search, as
suggested by comments around the function.  There are no behavioural
changes, but gdb is now faster at setting breakpoints in template code.
Tested using on make check on an x86 target. The optimisation speeds up
the included template-breakpoints.py performance test by a factor of 7
on my machine.

ChangeLog:

2018-03-08  Stephen Roberts  <stephen.roberts@arm.com>

        * gdb/symtab.c (find_pc_sect_line): now uses binary search.

gdb/testsuite/

        * gdb.perf/template-breakpoints.cc: New file.
        * gdb.perf/template-breakpoints.exp: New file.
        * gdb.perf/template-breakpoints.py: New file.
---
 gdb/symtab.c                                    | 22 +++---
 gdb/testsuite/gdb.perf/template-breakpoints.cc  | 97 +++++++++++++++++++++++++
 gdb/testsuite/gdb.perf/template-breakpoints.exp | 65 +++++++++++++++++
 gdb/testsuite/gdb.perf/template-breakpoints.py  | 33 +++++++++
 4 files changed, 206 insertions(+), 11 deletions(-)
 create mode 100644 gdb/testsuite/gdb.perf/template-breakpoints.cc
 create mode 100644 gdb/testsuite/gdb.perf/template-breakpoints.exp
 create mode 100644 gdb/testsuite/gdb.perf/template-breakpoints.py
Yao Qi - March 14, 2018, 10:31 a.m.
Stephen Roberts <stephen.roberts@arm.com> writes:

> I've made all the suggested changes except for one - I break on a specific line because the code is templatized so I can't set breakpoints on specific methods.
> I know I could use rbreak, but I feel that this would make the test less clear and would include the overhead of looking up functions by regex, which is not relevant to this fix.
> If you still think I should go ahead and use rbreak, let me know.
>

That is fine by me.

>  
> -      for (i = 0; i < len; i++, item++)
> -	{
> -	  /* Leave prev pointing to the linetable entry for the last line
> -	     that started at or before PC.  */
> -	  if (item->pc > pc)
> -	    break;
> +    auto pc_compare = [](const CORE_ADDR & pc,
> +			 const struct linetable_entry & lhs)->bool

The indentation looks wrong.  It needs six spaces before "auto" instead
of four spaces.

> +    {
> +      return pc < lhs.pc;
> +    };
>  
> -	  prev = item;
> -	}
> +    struct linetable_entry *first = item;
> +    struct linetable_entry *last = item + len;
> +    item = std::upper_bound (first, last, pc, pc_compare);
> +    if (item != first)
> +      prev = item - 1;		/* Found a matching item.  */

Otherwise, patch is good to me.  If no one has comments in three days,
you can push it in.

Do you have a sourceware account?  With that account/ssh key, you can
push your commit to gdb repository.
https://sourceware.org/cgi-bin/pdw/ps_form.cgi
Joel Brobecker - March 26, 2018, 4:14 p.m.
> 2018-03-08  Stephen Roberts  <stephen.roberts@arm.com>
> 
>         * gdb/symtab.c (find_pc_sect_line): now uses binary search.

Quick note: I fixed up the ChangeLog to remove the leading "gdb/"
in the filename.

Patch

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 5671953..37a78df 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3046,8 +3046,6 @@  find_symbol_at_address (CORE_ADDR address)
    find the one whose first PC is closer than that of the next line in this
    symtab.  */
 
-/* If it's worth the effort, we could be using a binary search.  */
-
 struct symtab_and_line
 find_pc_sect_line (CORE_ADDR pc, struct obj_section *section, int notcurrent)
 {
@@ -3214,15 +3212,17 @@  find_pc_sect_line (CORE_ADDR pc, struct obj_section *section, int notcurrent)
       if (item->pc > pc && (!alt || item->pc < alt->pc))
 	alt = item;
 
-      for (i = 0; i < len; i++, item++)
-	{
-	  /* Leave prev pointing to the linetable entry for the last line
-	     that started at or before PC.  */
-	  if (item->pc > pc)
-	    break;
+    auto pc_compare = [](const CORE_ADDR & pc,
+			 const struct linetable_entry & lhs)->bool
+    {
+      return pc < lhs.pc;
+    };
 
-	  prev = item;
-	}
+    struct linetable_entry *first = item;
+    struct linetable_entry *last = item + len;
+    item = std::upper_bound (first, last, pc, pc_compare);
+    if (item != first)
+      prev = item - 1;		/* Found a matching item.  */
 
       /* At this point, prev points at the line whose start addr is <= pc, and
          item points at the next line.  If we ran off the end of the linetable
@@ -3247,7 +3247,7 @@  find_pc_sect_line (CORE_ADDR pc, struct obj_section *section, int notcurrent)
       /* If another line (denoted by ITEM) is in the linetable and its
          PC is after BEST's PC, but before the current BEST_END, then
 	 use ITEM's PC as the new best_end.  */
-      if (best && i < len && item->pc > best->pc
+      if (best && item < last && item->pc > best->pc
           && (best_end == 0 || best_end > item->pc))
 	best_end = item->pc;
     }
diff --git a/gdb/testsuite/gdb.perf/template-breakpoints.cc b/gdb/testsuite/gdb.perf/template-breakpoints.cc
new file mode 100644
index 0000000..726270a
--- /dev/null
+++ b/gdb/testsuite/gdb.perf/template-breakpoints.cc
@@ -0,0 +1,97 @@ 
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright (C) 2018 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <iostream>
+
+template <int I, int J, int K, int VAL>
+struct ThirdDimension
+{
+  int
+  value () const
+  {
+    ThirdDimension<I, J, K - 1, VAL> d3;
+    return d3.value();
+  }
+};
+
+template <int I, int J, int VAL>
+struct ThirdDimension<I, J, 0, VAL>
+{
+  int
+  value () const
+  {
+    // Please note - this testcase sets a breakpoint on the following line.
+    // It is therefore sensitive to line numbers. If any changes are made to
+    // this file, please ensure that the testcase is updated to reflect this.
+    std::cout << "Value: " << VAL << std::endl;
+    return VAL;
+  }
+};
+
+template <int I, int J, int K, int VAL>
+struct SecondDimension
+{
+  int
+  value () const
+  {
+    SecondDimension<I, J - 1, K, VAL> d1;
+    ThirdDimension<I, J, K, VAL> d2;
+    return d1.value() + d2.value();
+  }
+};
+
+template <int I, int K, int VAL>
+struct SecondDimension<I, 0, K, VAL>
+{
+  int
+  value () const
+  {
+    ThirdDimension<I, 0, K, VAL> d2;
+    return d2.value();
+  }
+};
+
+template <int I, int J, int K, int VAL>
+struct FirstDimension
+{
+  int
+  value () const
+  {
+    FirstDimension<I - 1, J, K, VAL> d1;
+    SecondDimension<I, J, K, VAL> d2;
+    return d1.value() + d2.value();
+  }
+};
+
+template <int J, int K, int VAL>
+struct FirstDimension<0, J, K, VAL>
+{
+  int
+  value () const
+  {
+    SecondDimension<0, J, K, VAL> d2;
+    return d2.value();
+  }
+};
+
+int
+main (int argc, char *argv[])
+{
+  FirstDimension<EXPANSION_DEPTH, EXPANSION_DEPTH, EXPANSION_DEPTH, 1> product;
+  std::cout << product.value() << std::endl;
+  return 0;
+}
diff --git a/gdb/testsuite/gdb.perf/template-breakpoints.exp b/gdb/testsuite/gdb.perf/template-breakpoints.exp
new file mode 100644
index 0000000..d69553d
--- /dev/null
+++ b/gdb/testsuite/gdb.perf/template-breakpoints.exp
@@ -0,0 +1,65 @@ 
+# Copyright (C) 2018 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# This test case is to test the performance of GDB when setting breakpoints
+# on heavily temlatized C++ code.
+
+# Parameters:
+# EXPANSION_DEPTH: knob to control how many times template expansions occur
+
+load_lib perftest.exp
+
+if [skip_perf_tests] {
+	return 0
+}
+
+standard_testfile .cc
+set executable $testfile
+set expfile $testfile.exp
+
+# make check-perf RUNTESTFLAGS='template-breakpoints.exp EXPANSION_DEPTH=40'
+if ![info exists EXPANSION_DEPTH] {
+	set EXPANSION_DEPTH 40
+}
+
+PerfTest::assemble {
+	global EXPANSION_DEPTH
+	global srcdir subdir srcfile
+
+	set compile_flags {c++ debug}
+	lappend compile_flags "additional_flags=-DEXPANSION_DEPTH=${EXPANSION_DEPTH}"
+
+	if { [gdb_compile "$srcdir/$subdir/$srcfile" ${binfile} executable $compile_flags] != ""} {
+		return -1
+	}
+
+	return 0
+} {
+	global binfile
+
+	clean_restart $binfile
+
+	if ![runto_main] {
+		fail "can't run to main"
+		return -1
+	}
+
+	return 0
+} {
+
+	gdb_test "python TemplateBreakpoints().run()"
+
+	return 0
+}
diff --git a/gdb/testsuite/gdb.perf/template-breakpoints.py b/gdb/testsuite/gdb.perf/template-breakpoints.py
new file mode 100644
index 0000000..d85941b
--- /dev/null
+++ b/gdb/testsuite/gdb.perf/template-breakpoints.py
@@ -0,0 +1,33 @@ 
+# Copyright (C) 2018 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+from perftest import perftest
+
+class TemplateBreakpoints (perftest.TestCaseWithBasicMeasurements):
+    def __init__(self):
+        super (TemplateBreakpoints, self).__init__ ("template-breakpoints")
+
+    def warm_up(self):
+        for _ in range(0, 2):
+            gdb.Breakpoint("template-breakpoints.cc:38").delete()
+
+    def _do_test(self, bpcount):
+        for _ in range(1, bpcount):
+            gdb.Breakpoint("template-breakpoints.cc:38").delete()
+
+    def execute_test(self):
+        for bpcount in range(1, 10):
+            tfunc = lambda bound_bpcount=bpcount: self._do_test(bound_bpcount)
+            self.measure.measure(tfunc, bpcount)