Patchwork [gdb/testsuite] Use %progbits in watch-loc.c

mail settings
Submitter Thomas Preud'homme
Date March 1, 2018, 7:02 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/26143/
State New
Headers show


Thomas Preud'homme - March 1, 2018, 7:02 p.m.

While using @progbits in .pushsection work on some targets, it does not
work on arm target where this introduces a comment. This patch replaces
its use in gdb.dlang/watch-loc.c by %progbits which should work on all
targets since it is used in target-independent elf/section7.s GAS test.

ChangeLog entry is as follows:

*** gdb/testsuite/ChangeLog ***

2018-03-01  Thomas Preud'homme  <>

	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.

Is this ok for master?

Best regards,

Yao Qi - March 2, 2018, 11:44 a.m.
Thomas Preudhomme <> writes:

> 2018-03-01  Thomas Preud'homme  <>
> 	* gdb.dlang/watch-loc.c: Use %progbits instead of @progbits.

Patch is good to me.  A nit, can you update
gdb.mi/dw2-ref-missing-frame-func.c as well? @progbits is used there as well.


diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c
index 06fcc8922b43712dd36ce84600203427477ff69d..46810bcd2372ebc69c4c66e46ec9ee5b80f98b1a 100644
--- a/gdb/testsuite/gdb.dlang/watch-loc.c
+++ b/gdb/testsuite/gdb.dlang/watch-loc.c
@@ -38,7 +38,7 @@  main (void)
    generated by GCC.  (.gdb_index includes a gdb-generated map
    instead.)  */
 asm (
-"	.pushsection	.debug_aranges,\"\",@progbits \n"
+"	.pushsection	.debug_aranges,\"\",%progbits \n"
 "	.4byte	.Laranges_end - .Laranges_start \n"	// Length of Address Ranges Info
 ".Laranges_start: \n"
 "	.2byte	0x2 \n"	// DWARF Version