Patchwork [v3,4/5] Document the new "-a" command line option for gcore

login
register
mail settings
Submitter Sergio Lopez
Date Dec. 4, 2017, 8:17 a.m.
Message ID <20171204081716.5414-5-slp@redhat.com>
Download mbox | patch
Permalink /patch/24706/
State New
Headers show

Comments

Sergio Lopez - Dec. 4, 2017, 8:17 a.m.
gdb/ChangeLog:
2017-11-29  Sergio Lopez  <slp@redhat.com>

	* NEWS (Changes since GDB 8.0): Announce new "-a"
	command line option for gcore.

gdb/doc/ChangeLog:
2017-11-29  Sergio Lopez  <slp@redhat.com>

	* gdb.texinfo (gcore man): Document new "-a" command line option.
---
 gdb/NEWS            | 5 +++++
 gdb/doc/gdb.texinfo | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Eli Zaretskii - Dec. 4, 2017, 3:25 p.m.
> From: Sergio Lopez <slp@redhat.com>
> Cc: Sergio Lopez <slp@redhat.com>
> Date: Mon,  4 Dec 2017 09:17:15 +0100
> 
> gdb/ChangeLog:
> 2017-11-29  Sergio Lopez  <slp@redhat.com>
> 
> 	* NEWS (Changes since GDB 8.0): Announce new "-a"
> 	command line option for gcore.
> 
> gdb/doc/ChangeLog:
> 2017-11-29  Sergio Lopez  <slp@redhat.com>
> 
> 	* gdb.texinfo (gcore man): Document new "-a" command line option.

OK, but...

>  @c man begin OPTIONS gcore
>  @table @env
> +@item -a
> +Dump all memory mappings.  The actual effect of this option depends on the
> +Operating System.  On @sc{gnu}/Linux, it will disable
> +@code{use-coredump-filter} and enable @code{dump-excluded-mappings}.

...should we have a cross-reference here to where the above commands
are described?

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 1372552a37..ce84fe7924 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -52,6 +52,11 @@ 
 
   ** The "complete" command now mimics TAB completion accurately.
 
+* New command line options (gcore)
+
+-a
+  Dump all memory mappings.
+
 * Python Scripting
 
   ** New events gdb.new_inferior, gdb.inferior_deleted, and
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 7b25912e49..88d6820998 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -42948,7 +42948,7 @@  Richard M. Stallman and Roland H. Pesch, July 1991.
 
 @format
 @c man begin SYNOPSIS gcore
-gcore [-o @var{filename}] @var{pid}
+gcore [-a] [-o @var{filename}] @var{pid}
 @c man end
 @end format
 
@@ -42962,6 +42962,11 @@  running without any change.
 
 @c man begin OPTIONS gcore
 @table @env
+@item -a
+Dump all memory mappings.  The actual effect of this option depends on the
+Operating System.  On @sc{gnu}/Linux, it will disable
+@code{use-coredump-filter} and enable @code{dump-excluded-mappings}.
+
 @item -o @var{filename}
 The optional argument
 @var{filename} specifies the file name where to put the core dump.