Patchwork Fix Python rbreak tests setting too many breakpoints

login
register
mail settings
Submitter Phil Muldoon
Date Nov. 29, 2017, 4:32 p.m.
Message ID <5ce5db13-f5c7-a4f2-9e5e-0e669580f2eb@redhat.com>
Download mbox | patch
Permalink /patch/24600/
State New
Headers show

Comments

Phil Muldoon - Nov. 29, 2017, 4:32 p.m.
Pedro noticed that when glibc debug info is installed the Python
rbreak fails by setting far too many breakpoints.  This patch excludes
these symbols by setting "nosharedlibrary" before the tests run.

Cheers

Phil

--

2017-11-29  Phil Muldoon  <pmuldoon@redhat.com>

	* gdb.python/py-rbreak.exp: Set nosharedlibrary before tests.

 
 	* gdb.cp/psymtab-parameter.cc (func): Change return type back to long.
Pedro Alves - Nov. 29, 2017, 4:35 p.m.
On 11/29/2017 04:32 PM, Phil Muldoon wrote:
> Pedro noticed that when glibc debug info is installed the Python
> rbreak fails by setting far too many breakpoints.  This patch excludes
> these symbols by setting "nosharedlibrary" before the tests run.

OK.

Thanks,
Pedro Alves

Patch

diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp
index 5aaf2975c9..3cf158bb02 100644
--- a/gdb/testsuite/gdb.python/py-rbreak.exp
+++ b/gdb/testsuite/gdb.python/py-rbreak.exp
@@ -32,6 +32,7 @@  if ![runto_main] then {
     return 0
 }
 
+gdb_test_no_output "nosharedlibrary"
 gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \
     "get all function breakpoints" 0
 gdb_test "py print(len(sl))" "11" \