Message ID | 1511463187-19063-1-git-send-email-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 91336 invoked by alias); 23 Nov 2017 18:53:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 91319 invoked by uid 89); 23 Nov 2017 18:53:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-ClientProxiedBy:sk:AM3PR07 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 18:53:21 +0000 Received: from ESESSHC012.ericsson.se (Unknown_Domain [153.88.183.54]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 4F.5E.09556.E19171A5; Thu, 23 Nov 2017 19:53:18 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.54) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 23 Nov 2017 19:53:18 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Thu, 23 Nov 2017 18:53:16 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [pushed] Fix clang warnings about copy elision Date: Thu, 23 Nov 2017 13:53:07 -0500 Message-ID: <1511463187-19063-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR08CA0087.namprd08.prod.outlook.com (2603:10b6:404:b6::25) To AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) X-MS-Office365-Filtering-Correlation-Id: 5fc971b1-ac05-44b2-3f6b-08d532a37536 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600025)(4604075)(2017052603199); SRVR:AM3PR07MB308; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 3:fCv5amb+jeyisLSZkrF7adYsUlLXjXpZL6DSIPzcFXChF8svcTsJ6nkozgmWCw1WmjyalaEdH9LPIJKp/ETzC8qX005KQwNKK8rPUEfis4OxrcbcDbBpnyrdBBuv+Zcoo4hLxyTBK9PBwJ7A2zkts+zLa6OJlzZ5hhgQXNNfSgfqF1rlhPL4XQ7SEUSZfCK3i2h8Wbi8vxJL43/xzHzx0rMIvDywBYoh9xP6Kbduageb4tD21sLdsHCp3a8ldi+R; 25:DiJAoK9LQ1yAC1ULAbJ9CmtrzF8lRmuv7Xd1IJ+sn9YVgCDt4B+nH/V2GQtfgXKbU6tq3P2LGN+2vSJ3KfiNQUVgniacoVNCIUnYXyXUaenc1riRuZT9beyNUsC1UaCfmrkA9dRGKr9SCW6VLiJwgmtBnZqwMtbTMpd3ZZe7LevtoBUx3Y9pwputY0r55Z55DnF26eeJQvzl4CIJxnOWw92v6tSP5NvuzAlDNNzYQubEKq7A+jjvcxsJCCMbnn+SRpj8ciGcROX2qF7hCM6NYN10imYwX0BFUHWzRNnxZWCLJ6qGpisYRiZuDvjFNhFwdjVyyHMh/qv+OPIA8rYWYOZUGjIMatR2xysAZxDYH+Q=; 31:LNayqiy8OS8o4iJQfcx6LR3mwyP5a7xjen4Xf3y+RrL2bQcdlmc+1LuOjE809Z3IzUhnAh9PTxj+pRKY5tx3sk+cjtqnIeZWEHuBUfWIJO46syNAD041XrG1dNFAnnH64m67oeRzHlsWaoB7MFR7b3o1yWKQ0swFyLmZekoUjdFaiKtV5/Foa+09/hFHiFZ/GE9SUubteI+zVKPWFtpDHHe9TZAd1ggP6MSo2dni3Vg= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PR07MB308: X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 20:hR7++AyNVZoQTsxJPTw9gEyVK7eNDtkYoiZXZlMI5ZjnTJuPQUcbmj5lVpKhUjbAcG1jfBabJ02m0trP7pb0xqvVQaIZZ8myfgJKIM7nk3L1D6Sz2DB35Q4x1dFq1MsMIUiNIHK0jiS9/CIbjJNDAZ7JSE5BWVKa21ReybIzaUQrdI/3WFT7f2dLr1FxZgJ2x2ceF3MlLPBQXQ6HeNz1EB7DlmJ4yExzfM83U9GI2foZv28nz14XOMUxj4KGd13xF4MocIcMu1Hyrh3A+3mXcI/ZY+YkK74u8hyedWsws6aWv10SOWpp3L6CyDdVS0Q/ldgH4nI0bnyJh0bgaUxtkDN5VfM8LpftMQPWsWdOKfYibZtIpJX1fu0dCJGMQ6nP98PzIxch7DYjdLdcbEyPLHkT3KPr3zRncxusM21fSmY27FFD9f+PYgsuv+YRqoNAuX+1Ywa8ZK8hO/L7lfLqu5ldZe+ABHjqfmiLf41PbKdz/USsI/SUymSGuy+1XDn4; 4:z06gLalSiHT2JaVKh1qzRbqBWeRWaRrVdW9QKasirGgKqSBqu+4xbCeP+LsgdaLVHaletszRObE7QDe9m46lQtwn/WK8UCASUk8tdlqsvWN+gqj2APDgLoeYiTWLU7aq0TxRZJP5o1ySRajvTNwyaiC7t+y6v5y2t5Bz0Je1OuLRQ1tjflv3FbonIME/v6zDc6YopLcl2uQhG7ttF8roRwCuBdgyC0MTuQJLZU8cG2hcft+uujcfQ215fRCDYcHKBx9m/Kr6anU7HlLGfsd+9aSptENglTNIKnKW7/weWLu+L6o9nodZhKzF/urWY0Hbf1kKNh9VMTN6nLn1BnFIVHd1TE1UIoIHTqsB+7NHxOk= X-Microsoft-Antispam-PRVS: <AM3PR07MB308E9E2FB1D423AFAED6FC9ED210@AM3PR07MB308.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(37575265505322)(131327999870524); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3231022)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR07MB308; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR07MB308; X-Forefront-PRVS: 05009853EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(366004)(39860400002)(346002)(376002)(54534003)(199003)(377424004)(189002)(5660300001)(66066001)(101416001)(68736007)(50986999)(47776003)(105586002)(48376002)(5003940100001)(2361001)(50466002)(33646002)(52116002)(8676002)(97736004)(305945005)(2351001)(107886003)(81166006)(3846002)(4001150100001)(6916009)(2906002)(81156014)(6116002)(53936002)(36756003)(6506006)(6512007)(8936002)(6666003)(4326008)(189998001)(16526018)(25786009)(316002)(86362001)(50226002)(575784001)(6486002)(7736002)(478600001)(16586007)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR07MB308; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR07MB308; 23:lydoZQZmmo016jEKUOG1Q7ZfGm4LbyDt0n3cO6S1oS?= =?us-ascii?Q?12otwxM1EwE733+lpWZf5UZNMzCz7+Y3thOxWKawJCFTjmYqYHB7ZWa3hV4o?= =?us-ascii?Q?Vnp+3YNp0SwS7GI+cemyLYQa3mkbP5U4mYVEihFZ8MYxP9B8GOmngmAW4XPY?= =?us-ascii?Q?KRRZ2Oog57EXh2CnMH62Giq+9Mn01r6GrKOBN8SrSbpbCDm1Wusvfwscu25N?= =?us-ascii?Q?WIf/rGPYBlSxcujOWL9AJcmfuACxVXF3xZ99trTfnv+GoUmIMI3A/SXje3FV?= =?us-ascii?Q?Z+18W8pkfaW5TMfMuOEiviuqEShWCqpW7Owzs3ybet+xVL2q1vKs2bZGAc5y?= =?us-ascii?Q?I71LY6SUwRoWTe9OI8nJATJCKXSYhoUmViDMR+ty1FZcUlSq/capvXlwcoUu?= =?us-ascii?Q?noiMLC2zOYmsVKpdd9kDMv/jhzG9clteXi9YeFkXXaC/TCnLKrGaauQ9NByU?= =?us-ascii?Q?Orz/ylUDYVARkq2PlJOEDRpkIIT37EOfuwaCEpEZmR81ro07q2CB5O42Vrqd?= =?us-ascii?Q?7ZRvUGRvFyOKCAkzU+BTkeN3nPW68EYY6SmPYdvwGweejlk1wKcfRqNakiBx?= =?us-ascii?Q?cZeEZkM/x9tWMRiVIYhhSIiLaZAUl9OMYc7H3i+hArJtmw87oINKdZH3GRel?= =?us-ascii?Q?r1S4BsYJdYFFG7WrG7gRMfv/4tKNKxorR0o6j+2w2XvpzTYEoxGVBTfjXv+w?= =?us-ascii?Q?FR/ldB30hbJd6onk/5o2yMWWGlm/qzvDTE9P6XPTyES6kWIHho83QnHRjHih?= =?us-ascii?Q?ghZvOKGV7VmfjC4IFSnVq9Gb70l92kR9AX4SCXvA9IJ5avze33KZv1nUYo4+?= =?us-ascii?Q?Jw1gjxC30cRHnKo+3T2tms1Itv7YM1WaUEWvt/qt5m4PCsJLEcvSidKLK8dr?= =?us-ascii?Q?KtCtYjWWxqva94pX8OTHRR2548RbRvv6c07OFYB2qyZImjxSc9BH2GB9Doft?= =?us-ascii?Q?LbDxdidAOw0JjJvq6gF3D+TMnSBjutOU6JPp7GqSjgLIgRmK/sx7M9Ni5Ts0?= =?us-ascii?Q?Jf990pllplYTeYNyolkOoXB+mFOOsMYnhOB8rc1CYAm9KiLXHSFrEcfdfR5r?= =?us-ascii?Q?wukuOFZlmTCmrbY9qSmlx5bCerzGshybQODbYZowOvZyrIOLn9EzbENLm6rM?= =?us-ascii?Q?y64ONzGgE9TUL+A73tCxn/T30XauQ/2B3DQA3aXokaiFFkSqUjnjYbl/mkck?= =?us-ascii?Q?9H+1/ZLf+c1b7UART/tyU8dzBA9vximX2VjxwnTapueeu+mJUq9m59CgynzI?= =?us-ascii?Q?9ahMUMKnGXgPvfhYc=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 6:3k6iAkqyBlPucy6Xg5UxxrppPliiRLyxg1gmJreVLCt1H+jJuUDIP/nCUFAxZlZvmj9NPI39D1TLL2Q8loXMagbeylwS4WD2Ox7J1P3lZOmBuhB8Gcw3VYaWeIjUVoQsT6C1MoEUp56G6HwHopi17/AMtblWuZzDRnf3ZohjeIPDK1yiV9zpOdcaCmYiaEt7mqwafhtv0BVNGPXZtL3dm71Q9Ri2hxC1ieeMV3FFRTxTdjTcdIPYswzEhNP6J3XOPsk8QM1luvy50RUSwamKI5pyY1Fffdg3mNnCK2F3XgDWE+m1aMxDA9w8ZwEbZzxQ62L2KXzaqPE7HOVuyifbe47GGwlKjoEUd3M7E2tK03c=; 5:OUYc2wQGr1i71DbRlSlv9cU6KSiCZ/L2d7apCxvD4L/BP0zr7+iGiBWEi44s0p2HUSSpHtswNUmwFfxVx8Huzkoo45QHyzp1gdmthunDwRjaXP5P8+tHmzMlDLQGGm8d+e+MnrVdT7n6SWwjVaSXxDV4+nUdxVJ+4/h/F06yjC8=; 24:HTMglUMC/pBZq9g3Cn4JZUzNPCV3b/T/qaXhVsA0wjkJx1iiVER9o9Id8302Lsq/UtZS6Su+xw45BKK1l8qNG7vUZGy7UWTykR+vlgg6PS4=; 7:AjcuPmPRRteDgsVuFXbYRyQkOACOzEzPEhuHuz29piLDveyyGkQEIiUJ87H1Dhqztj1oopG1AiBeuizQtD1NHMQY9hKdOlmRcDeEqWBdv+b31cqDe1xEBwhbQsgeJTeqUWHzH8AjqfjF+FLLQmWO/MOsVklnLqGWY8uz0vw8C0vQ6HLrxNyValKw3Zpu7e0b+Ak3Jw2nfY3BOqZKt+7U4PO1enoENnSoORcQ3imp5FN91lnLJjpZ0CHpKR1uv/l9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2017 18:53:16.5653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc971b1-ac05-44b2-3f6b-08d532a37536 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB308 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Nov. 23, 2017, 6:53 p.m. UTC
When building with clang, I get: /home/emaisin/src/binutils-gdb/gdb/osdata.c:107:9: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] std::move (std::string (body_text))); ^ /home/emaisin/src/binutils-gdb/gdb/osdata.c:107:9: note: remove std::move call here std::move (std::string (body_text))); ^~~~~~~~~~~ ~ /home/emaisin/src/binutils-gdb/gdb/osdata.c:181:10: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] return std::move (osdata); ^ /home/emaisin/src/binutils-gdb/gdb/osdata.c:181:10: note: remove std::move call here return std::move (osdata); ^~~~~~~~~~~ ~ Indeed, those two std::move are unnecessary. gdb/ChangeLog: * osdata.c (osdata_end_column, get_osdata): Remove std::move. --- gdb/ChangeLog | 4 ++++ gdb/osdata.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3fdeae1..bb3bf4e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-11-23 Simon Marchi <simon.marchi@ericsson.com> + * osdata.c (osdata_end_column, get_osdata): Remove std::move. + +2017-11-23 Simon Marchi <simon.marchi@ericsson.com> + * varobj.c (struct varobj_dynamic) <children_requested_>: Rename back to... <children_requested>: ... this. diff --git a/gdb/osdata.c b/gdb/osdata.c index f013d0f..a82cbf1 100644 --- a/gdb/osdata.c +++ b/gdb/osdata.c @@ -104,7 +104,7 @@ osdata_end_column (struct gdb_xml_parser *parser, osdata_item &item = osdata->items.back (); item.columns.emplace_back (std::move (data->property_name), - std::move (std::string (body_text))); + std::string (body_text)); } /* The allowed elements and attributes for OS data object. @@ -178,7 +178,7 @@ get_osdata (const char *type) if (osdata == NULL) error (_("Can not fetch data now.")); - return std::move (osdata); + return osdata; } const std::string *