Message ID | 1511195683-2055-9-git-send-email-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 102458 invoked by alias); 20 Nov 2017 16:35:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102375 invoked by uid 89); 20 Nov 2017 16:35:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 16:35:15 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id AE.F1.07741.144031A5; Mon, 20 Nov 2017 17:35:13 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 20 Nov 2017 17:35:12 +0100 Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Mon, 20 Nov 2017 16:35:11 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@polymtl.ca> Subject: [PATCH 08/19] Remove usage of find_inferior in linux_mourn Date: Mon, 20 Nov 2017 11:34:32 -0500 Message-ID: <1511195683-2055-9-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> References: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY4PR03CA0075.namprd03.prod.outlook.com (2603:10b6:910:4d::16) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2694b3bb-2755-43c3-ef77-08d53034abe4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 3:WRJV7gX9F1KGoA3AL0U2ux43o2rMC9nKdjlT1qVOAyFLDlz99jv5winzsPl4C8ocymH/qWX+5i/Xj25mZZtE4WvlZ+8Upb96isvYlClLIwOK/fYy6t+LFnrHeH3SmgezTEiEHdz49JiCIBBeKzV1aUa+NhtqL2aem99xdQCXgieUlOmzMCBivsAXRO0UpMJHvmeqi9hBK1hYBqAsm/J9JM+YifEJ4BPt6xME5NHR3w1vFyZD2oZ1ebogZk4g8DP4; 25:VOyZM2REhafEc/wz7GlhKneu3b/RT2zH71BJLlhp2P1+8vAJLTzdC2rtOAjrN0AtSd8Q5d9FAjlWvUeNOrhD2Zl8v3UM9Xsiq3SchhDd45JmRm8xp84Eypz3I5q9VkfKBXKnTC5n0YBD7rZLCe52MFc++mY8p0ZrwUDeFTSqZ/8cs9MdKj+3nbOnN4/jEm3UOf9rOFwSpTnwXlXKLDwtvftreDIRZTvHihxPfo4jkbdI00P7+pW9y4DsJ7v6jyEa/JaKUd8/KtfmCda/MpEL00jqVnBVJgm4xND6Js/F4Hw/VL15WqLUisNHDXQlVMd6sXQ68m5D/uqtQDHkd+P338ucp3LJCTSEZ6eHjxszjHA=; 31:DsKq/DyFqzZ7893/KCojEoTxnxnXS6bbYjuaklS9uQFbHp6YKs943JBRDa4kFJhqdnLLJd9I4jsXaoXSfE9szDEp32O1CX5nMV8Z6bu1xo28r/aX+bBfSwfmN9TvQOSYZf5PfSJe5O8nWMQ85CgBsdviS1KVqnEcd/c0pghI6k8MPCIA72E0EdHa4dAR+zMy4arhXMHrvCSYsooLvhONuw+Ar25J4mUwOi3YpgjTe+A= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 20:4941+AMZoeyXSe2WQ5bd7/S8s+/ndGCAIm6sjfoWmgrruJodP/FnFtkjPgAfSwaMBpUgWdTTTmO7RzqnwdwrWy/X/hHy/GGW4Fh/wHJKpFLStgbwEgPrSnmMF/2IT3pTShUL19Qefc2Ib3+W6pcxycArgmy8EHuVIlKrhvadSgHl4AhnZ162Dr54A1T9iJuSZow2a1liiK2P/u3rFZNGqfivRzVv5D1aKw87e95RUHLMousowq5TddCcu2XT2VlyFDHHm0FKIWQoAVUGjQnOl+MRxqKK2NoiCa7UP5RafChLKqusvNPaponoQuKItSUTol3+/ihK6U58jsEjJsbbP+oB79pqRNC489o89XcfnpXdQo6vMrz75anKx890sUoZ54PjJllaXgm/i57W/VHjYHVWSFkvMmothTMiFzCcc1hl4gsbNglGLmE3aYJ0d+5MxJyMapEw5SQMsA9W2I4dXu0RW0Fe+MLuK7VbLbfYpqNlLmN/kNisRiQzKne62WE9; 4:I4mpbLhnT2tsfaHIgv8A16Wr5naUz8Lis9JAyscxg0PWvs+B00vXAIUGXdjVI7ukmwWMPygKvOVxI+TDkiC383Pny2Be1FeVm5Tg0SUGZ4UR6oVAeosYnKbB5OXP5f+9HNNB9q4IOFgEJAAcDZL7h13/Y3m5j09lRNTs2l+oATEtweftr22oGK2rr2nR907QPdBVwXtgm6hYNPrzRNfs3NDi8XcrvBuQDIzOxSNgappPQHCDpPrquV6A57AMjKqrENJA03L6G8iPQiuoG4dWPDt0YbaV03UwC7MeeeHYOgfhAOd5wgMRVIO/WPbmTLGe X-Microsoft-Antispam-PRVS: <AMSPR07MB310D54407BF36F22C31EF49ED220@AMSPR07MB310.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(3231022)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB310; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB310; X-Forefront-PRVS: 04976078F0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(54534003)(3846002)(97736004)(66066001)(5003940100001)(33646002)(16526018)(50986999)(76176999)(6666003)(81156014)(305945005)(7736002)(81166006)(6512007)(5660300001)(316002)(6506006)(6486002)(16586007)(6916009)(2950100002)(101416001)(8676002)(2351001)(2906002)(105586002)(36756003)(47776003)(86362001)(50466002)(48376002)(50226002)(8936002)(106356001)(68736007)(2361001)(53936002)(478600001)(25786009)(6116002)(4326008)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB310; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB310; 23:hYn8WXF3/nPs7nFa+G6cX4bJAxQzweUCoUo7P3vplC?= =?us-ascii?Q?nr+zceYh1uyvxZ0MHeKSk58iC/YhhyVK7b+0ZqQJP4DhGKQ2Pca55O0KyI5M?= =?us-ascii?Q?5P5RR8D4/ylXDxft4Q0LOTmQtZVWoBbY3+YY/9GF+21Pc2rsDTt+Qec2GVBG?= =?us-ascii?Q?g7CVXGx8ObfXD1b1KyHWlIgcZgHdoG/MktZ5YfejgzMrihRduSFdJ8f4rZAW?= =?us-ascii?Q?2o5WdttAiaTi5jD649VkSW9a+cVOk5ahjUUWe8tR68idZZn0QbwgF2dEWjdx?= =?us-ascii?Q?U95pCdjc0AapCgnRhffxD48Y2GTW6hYYB2JDEEyFmtV+yBgknEUwTj5SANmt?= =?us-ascii?Q?+I/s3FqDGpZ+VPZJHvIS9JexfPDgNQPdMMJqs+u55CnclB7MjGITKxOtjyC/?= =?us-ascii?Q?yaG7McFnM9+07C1ovvkBc7XYSKha1nYOm335B75jtugKVUfG5BjeA1y6t0Qo?= =?us-ascii?Q?Bu59X+aHfuqPCKKzTPK7vElmyyv5d3GpqsfVfrz0DTxU010ir/rfCtmzSCHF?= =?us-ascii?Q?ll3nf+U78m+uOjAquFHbWZe+gTrUo532NdSz6X55I2Z1Qqlvro+kslUn76UU?= =?us-ascii?Q?hFxUQmvbGQ2gbX0JIew+UQKktIJZFrBS5l8D4Ndg9wLnRvDMePtAgaZ5AWfa?= =?us-ascii?Q?lQ4C7sHvtdaxAZKKkmqbjqQLimjSLthDu7moGlA290tFrFFJ9LGLToBB3u3R?= =?us-ascii?Q?PNxci6UQdT179x7W30usjEoFUnmn8zZfYPF+KNipsyivJR2srg+yE32Na2ld?= =?us-ascii?Q?HRq4mY1NfFuOf4qmaRFJ1za2f5LzQbaJzqWikyQMcFrN6yXB6B10sE5YytDB?= =?us-ascii?Q?2tCPbeQxYPpoCS+pRGbYkKuxObhh/Fr86GqI0eXMgSGSia8pBM50rCMY592K?= =?us-ascii?Q?Hj4LdG2I6rTQQjpGXNUU8wplhs0liHGAilvXAg/85RpF6zlzXML5qp8DY7Kz?= =?us-ascii?Q?myWfsGO9X2Bc7WrkyOg3xyIB3LuZBK7X9hbSFUkpz9HccGPfk9J3qHAZE+ta?= =?us-ascii?Q?lYsbhYFQu0JeV7CAzho1yyGWOaIeXFdif01vCneNHyJ0YO0zwJ5SVNQtkNat?= =?us-ascii?Q?6yohqordQRWdquoO+nbl9u1VQh++anOrpMuFUvI+RU/vy02UIrE4pgpklg/B?= =?us-ascii?Q?fBRgbO/gu4349vZqTQ5NyuFytKWELr?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 6:KJ0JXMoHG3ipEglwoBpFzoinVO9vUGrE96guS1ecE14neB8aPHAgZAlP+JehsIk9tyZ+mVPbHApaq3+pOJVP3fS5brF/rM06LHVC2IwEfYqhw5HSm6b/WLfdZ/ukabXYRqIBaM+agFHVXot6mbBaNU1vyPFfhBxC3h4i6+A/OLJeyGm/FryXkD0C8KvHawsb8i7LyEOrqJ7euQbhUJIiCNXcpyuQbYWtkDWI8qa/w7cveMWF+lNTJQ3YaYXlgq01xpNWV35xA+85eicWKCYLvE9nGtA86VtfW8jbHKwhKRUGnZyELBZme7mU3XDpezXB9xUDZd8yELhKnXZmZpcXO7AZamI7R3J/SklKfjg+LUo=; 5:xIQ/6XywJ82Dh69LJT5LOt5IHbmFrlN16EQ3/eSCMGB0VZxSxZjxQRaXMX2e0FlHzsGjNltru12F6MpnrbCeVOueqEFntg9lSuJtaQhSSuErnq62oPNBUQlnCX0KbA4ul2pGN0ZB80aO3B4cMNxs0E2p5gxFTFwtPCWyn+dM4Hg=; 24:lsHp5qYm/fujL7WDOeRz0y8lVVFnk0krk0qb/LqMnCeDNS3hi+Lp8fS+s1o1vdP5IKqv9xNGc3DKM9VvxBj6znZG/iRU7aUf0iBCph7GpZk=; 7:x+DHoHlbp2M6JdozHgC9TasoRFKBQzc0I6tOCGcy1c6GfWdQw/fJ8gRSOMTj54JksnrhdkEP3ksA0UmjfTitcUW+wLlbnKAqoKzLnyKsFphWUw0Mbszt8R/C8Fm23w4ExELPg9+VQfL4/E1emCiSM8kneNrGer4diH8dHMLPyYGHnP6ku7F/z0g+azrmqBUpeQDZo5DoIkN+JZX1YEEHgMy8CwCwPTsN/ovgv/bH+aF/tS6ljColucjyYUlycLF5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2017 16:35:11.5633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2694b3bb-2755-43c3-ef77-08d53034abe4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Nov. 20, 2017, 4:34 p.m. UTC
From: Simon Marchi <simon.marchi@polymtl.ca>
Replace with for_each_thread with pid filtering. The callback becomes
trivial enough that it's better to inline it.
gdb/gdbserver/ChangeLog:
* linux-low.c (delete_lwp_callback): Remove.
(linux_mourn): Use for_each_thread.
---
gdb/gdbserver/linux-low.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index a4e19ba..6ec9a16 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -1642,18 +1642,6 @@ linux_detach (int pid) /* Remove all LWPs that belong to process PROC from the lwp list. */ -static int -delete_lwp_callback (thread_info *thread, void *proc) -{ - struct lwp_info *lwp = get_thread_lwp (thread); - struct process_info *process = (struct process_info *) proc; - - if (pid_of (thread) == pid_of (process)) - delete_lwp (lwp); - - return 0; -} - static void linux_mourn (struct process_info *process) { @@ -1663,7 +1651,10 @@ linux_mourn (struct process_info *process) thread_db_mourn (process); #endif - find_inferior (&all_threads, delete_lwp_callback, process); + for_each_thread (process->pid, [] (thread_info *thread) + { + delete_lwp (get_thread_lwp (thread)); + }); /* Freeing all private data. */ priv = process->priv;