Move x86 specific tunables to x86/dl-tunables.list
Commit Message
On Tue, Jun 20, 2017 at 11:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Jun 20, 2017 at 11:36 AM, Rodriguez Bahena, Victor
> <victor.rodriguez.bahena@intel.com> wrote:
>> -----Original Message-----
>>
>> From: <libc-alpha-owner@sourceware.org> on behalf of Siddhesh Poyarekar
>> <siddhesh@gotplt.org>
>> Date: Tuesday, June 20, 2017 at 9:36 AM
>> To: "H.J. Lu" <hjl.tools@gmail.com>, Adhemerval Zanella
>> <adhemerval.zanella@linaro.org>
>> Cc: GNU C Library <libc-alpha@sourceware.org>
>> Subject: Re: [PATCH] tunables: Add IFUNC selection and cache sizes
>>
>>>On Tuesday 20 June 2017 07:11 PM, H.J. Lu wrote:
>>>> Since ifunc and others are handled in the same name space, I have to
>>>> make non_temporal_threshold, .. as well as ifunc x86 specific. Will it
>>>>be
>>>> OK?
>>>
>>>I'm going to add ifunc selection for aarch64 soon, so it makes sense to
>>>have that generic. You could name the arch-specific tunables as
>>>x86_non_temporal_threshold and so on.
>>
>> What does it mean arch-specific? ( haswell / skyline / ... )
>>
>
> It is x86 vs aarch64.
>
This patch moves x86 specific tunables to sysdeps/x86/dl-tunables.list.
Any comments?
Comments
On 20/06/2017 16:13, H.J. Lu wrote:
> On Tue, Jun 20, 2017 at 11:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Jun 20, 2017 at 11:36 AM, Rodriguez Bahena, Victor
>> <victor.rodriguez.bahena@intel.com> wrote:
>>> -----Original Message-----
>>>
>>> From: <libc-alpha-owner@sourceware.org> on behalf of Siddhesh Poyarekar
>>> <siddhesh@gotplt.org>
>>> Date: Tuesday, June 20, 2017 at 9:36 AM
>>> To: "H.J. Lu" <hjl.tools@gmail.com>, Adhemerval Zanella
>>> <adhemerval.zanella@linaro.org>
>>> Cc: GNU C Library <libc-alpha@sourceware.org>
>>> Subject: Re: [PATCH] tunables: Add IFUNC selection and cache sizes
>>>
>>>> On Tuesday 20 June 2017 07:11 PM, H.J. Lu wrote:
>>>>> Since ifunc and others are handled in the same name space, I have to
>>>>> make non_temporal_threshold, .. as well as ifunc x86 specific. Will it
>>>>> be
>>>>> OK?
>>>>
>>>> I'm going to add ifunc selection for aarch64 soon, so it makes sense to
>>>> have that generic. You could name the arch-specific tunables as
>>>> x86_non_temporal_threshold and so on.
>>>
>>> What does it mean arch-specific? ( haswell / skyline / ... )
>>>
>>
>> It is x86 vs aarch64.
>>
>
> This patch moves x86 specific tunables to sysdeps/x86/dl-tunables.list.
>
> Any comments?
>
>
LGTM, thanks.
From 3d6a433311d99dced1378d44b9f37736594e631f Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 20 Jun 2017 12:09:56 -0700
Subject: [PATCH] Move x86 specific tunables to x86/dl-tunables.list
* elf/dl-tunables.list: Move x86 specific tunables to ...
* sysdeps/x86/dl-tunables.list: Here. New file.
---
elf/dl-tunables.list | 12 ------------
sysdeps/x86/dl-tunables.list | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 12 deletions(-)
create mode 100644 sysdeps/x86/dl-tunables.list
@@ -87,17 +87,5 @@ glibc {
type: STRING
security_level: SXID_IGNORE
}
- x86_non_temporal_threshold {
- type: SIZE_T
- security_level: SXID_IGNORE
- }
- x86_data_cache_size {
- type: SIZE_T
- security_level: SXID_IGNORE
- }
- x86_shared_cache_size {
- type: SIZE_T
- security_level: SXID_IGNORE
- }
}
}
new file mode 100644
@@ -0,0 +1,34 @@
+# x86 specific tunables.
+# Copyright (C) 2017 Free Software Foundation, Inc.
+# This file is part of the GNU C Library.
+
+# The GNU C Library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+
+# The GNU C Library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# Lesser General Public License for more details.
+
+# You should have received a copy of the GNU Lesser General Public
+# License along with the GNU C Library; if not, see
+# <http://www.gnu.org/licenses/>.
+
+glibc {
+ tune {
+ x86_non_temporal_threshold {
+ type: SIZE_T
+ security_level: SXID_IGNORE
+ }
+ x86_data_cache_size {
+ type: SIZE_T
+ security_level: SXID_IGNORE
+ }
+ x86_shared_cache_size {
+ type: SIZE_T
+ security_level: SXID_IGNORE
+ }
+ }
+}
--
2.9.4