Patchwork vfprintf: Remove unused argument from printf_unknown

login
register
mail settings
Submitter Florian Weimer
Date June 19, 2017, 4:23 p.m.
Message ID <20170619162319.1424E402AEC3C@oldenburg.str.redhat.com>
Download mbox | patch
Permalink /patch/21109/
State New
Headers show

Comments

Florian Weimer - June 19, 2017, 4:23 p.m.
2017-06-19  Florian Weimer  <fweimer@redhat.com>

	* stdio-common/vfprintf.c (printf_unknown): Remove unused argument.
	(printf_positional): Adjust.

Patch

diff --git a/stdio-common/vfprintf.c b/stdio-common/vfprintf.c
index 0a5e541..9cd4683 100644
--- a/stdio-common/vfprintf.c
+++ b/stdio-common/vfprintf.c
@@ -1272,8 +1272,7 @@  static int printf_positional (_IO_FILE *s,
 			      const char *grouping, THOUSANDS_SEP_T);
 
 /* Handle unknown format specifier.  */
-static int printf_unknown (FILE *, const struct printf_info *,
-			   const void *const *) __THROW;
+static int printf_unknown (FILE *, const struct printf_info *) __THROW;
 
 /* Group digits of number string.  */
 static CHAR_T *group_number (CHAR_T *, CHAR_T *, CHAR_T *, const char *,
@@ -2035,19 +2034,8 @@  printf_positional (_IO_FILE *s, const CHAR_T *format, int readonly_format,
 
 	  LABEL (form_unknown):
 	  {
-	    unsigned int i;
-	    const void **ptr;
-
-	    ptr = alloca (specs[nspecs_done].ndata_args
-			  * sizeof (const void *));
-
-	    /* Fill in an array of pointers to the argument values.  */
-	    for (i = 0; i < specs[nspecs_done].ndata_args; ++i)
-	      ptr[i] = &args_value[specs[nspecs_done].data_arg + i];
-
 	    /* Call the function.  */
-	    function_done = printf_unknown (s, &specs[nspecs_done].info,
-					    ptr);
+	    function_done = printf_unknown (s, &specs[nspecs_done].info);
 
 	    /* If an error occurred we don't have information about #
 	       of chars.  */
@@ -2079,8 +2067,7 @@  printf_positional (_IO_FILE *s, const CHAR_T *format, int readonly_format,
 /* Handle an unknown format specifier.  This prints out a canonicalized
    representation of the format spec itself.  */
 static int
-printf_unknown (FILE *s, const struct printf_info *info,
-		const void *const *args)
+printf_unknown (FILE *s, const struct printf_info *info)
 
 {
   int done = 0;