Patchwork manual: Complete @standards in creature.texi.

login
register
mail settings
Submitter Rical Jasan
Date June 16, 2017, 11:09 a.m.
Message ID <20170616110951.24732-1-ricaljasan@pacific.net>
Download mbox | patch
Permalink /patch/21044/
State New
Headers show

Comments

Rical Jasan - June 16, 2017, 11:09 a.m.
* creature.texi (_THREAD_SAFE): Annotate as obsolete.
	(_REENTRANT): Likewise.
---
 manual/creature.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Florian Weimer - June 16, 2017, 12:24 p.m.
On 06/16/2017 01:09 PM, Rical Jasan wrote:
> 	* creature.texi (_THREAD_SAFE): Annotate as obsolete.
> 	(_REENTRANT): Likewise.

Content-wise, this looks correct to me (the macros are obsolete).

Thanks,
Florian
Zack Weinberg - June 16, 2017, 1:10 p.m.
On Fri, Jun 16, 2017 at 8:24 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 06/16/2017 01:09 PM, Rical Jasan wrote:
>>       * creature.texi (_THREAD_SAFE): Annotate as obsolete.
>>       (_REENTRANT): Likewise.
>
> Content-wise, this looks correct to me (the macros are obsolete).

And as far as I was able to determine when I made them aliases for
_POSIX_C_SOURCE=199506L, they were never part of any standard we track
conformance with, either, so I also endorse this change.

zw
Rical Jasan - June 17, 2017, 4:19 a.m.
On 06/16/2017 06:10 AM, Zack Weinberg wrote:
> On Fri, Jun 16, 2017 at 8:24 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 06/16/2017 01:09 PM, Rical Jasan wrote:
>>>       * creature.texi (_THREAD_SAFE): Annotate as obsolete.
>>>       (_REENTRANT): Likewise.
>>
>> Content-wise, this looks correct to me (the macros are obsolete).
> 
> And as far as I was able to determine when I made them aliases for
> _POSIX_C_SOURCE=199506L, they were never part of any standard we track
> conformance with, either, so I also endorse this change.

Since not being from any particular standard is kind of an odd case,
should we maybe say something like, "These macros are not known to have
ever been part of any standard.", maybe at the end of the description?

In general, I would like to see anything that gets marked as Obsolete
with something in the description that provides a bit of history.

Rical

Patch

diff --git a/manual/creature.texi b/manual/creature.texi
index eb30b0118d..96f8ee0a0c 100644
--- a/manual/creature.texi
+++ b/manual/creature.texi
@@ -211,7 +211,7 @@  cause them to be disabled.
 
 @defvr Macro _REENTRANT
 @defvrx Macro _THREAD_SAFE
-@standardsx{_REENTRANT, GNU, (none)}
+@standards{Obsolete, (none)}
 These macros are obsolete.  They have the same effect as defining
 @code{_POSIX_C_SOURCE} with the value @code{199506L}.