[1/1] Need _KMEMUSER for including sys/proc.h on netbsd

Message ID 20170605121100.GA3277@SDF.ORG
State New, archived
Headers

Commit Message

coypu June 5, 2017, 12:11 p.m. UTC
  ---
 gdb/bsd-kvm.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

John Baldwin June 6, 2017, 5:44 p.m. UTC | #1
On Monday, June 05, 2017 12:11:01 PM coypu wrote:
> ---
>  gdb/bsd-kvm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
> index 98e24283..f872fc08 100644
> --- a/gdb/bsd-kvm.c
> +++ b/gdb/bsd-kvm.c
> @@ -17,6 +17,7 @@
>     You should have received a copy of the GNU General Public License
>     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>  
> +#define _KMEMUSER 1
>  #include "defs.h"
>  #include "cli/cli-cmds.h"
>  #include "command.h"
> 

This is ok with me.  FreeBSD doesn't use _KMEMUSER for anything, but for
FreeBSD we use an out-of-tree libkvm target instead of this one anyway.
  
coypu June 23, 2017, 2:38 a.m. UTC | #2
On Tue, Jun 06, 2017 at 10:44:25AM -0700, John Baldwin wrote:
> On Monday, June 05, 2017 12:11:01 PM coypu wrote:
> > ---
> >  gdb/bsd-kvm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
> > index 98e24283..f872fc08 100644
> > --- a/gdb/bsd-kvm.c
> > +++ b/gdb/bsd-kvm.c
> > @@ -17,6 +17,7 @@
> >     You should have received a copy of the GNU General Public License
> >     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> >  
> > +#define _KMEMUSER 1
> >  #include "defs.h"
> >  #include "cli/cli-cmds.h"
> >  #include "command.h"
> > 
> 
> This is ok with me.  FreeBSD doesn't use _KMEMUSER for anything, but for
> FreeBSD we use an out-of-tree libkvm target instead of this one anyway.
> 

Same for this one, if it's ok, can it be committed?
Thanks
  
coypu June 29, 2017, 3:38 p.m. UTC | #3
On Tue, Jun 06, 2017 at 10:44:25AM -0700, John Baldwin wrote:
> On Monday, June 05, 2017 12:11:01 PM coypu wrote:
> > ---
> >  gdb/bsd-kvm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
> > index 98e24283..f872fc08 100644
> > --- a/gdb/bsd-kvm.c
> > +++ b/gdb/bsd-kvm.c
> > @@ -17,6 +17,7 @@
> >     You should have received a copy of the GNU General Public License
> >     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> >  
> > +#define _KMEMUSER 1
> >  #include "defs.h"
> >  #include "cli/cli-cmds.h"
> >  #include "command.h"
> > 
> 
> This is ok with me.  FreeBSD doesn't use _KMEMUSER for anything, but for
> FreeBSD we use an out-of-tree libkvm target instead of this one anyway.
> 
> -- 
> John Baldwin

ping?
  

Patch

diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
index 98e24283..f872fc08 100644
--- a/gdb/bsd-kvm.c
+++ b/gdb/bsd-kvm.c
@@ -17,6 +17,7 @@ 
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#define _KMEMUSER 1
 #include "defs.h"
 #include "cli/cli-cmds.h"
 #include "command.h"