Message ID | 20170227185535.11586-1-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 43832 invoked by alias); 27 Feb 2017 18:56:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 43821 invoked by uid 89); 27 Feb 2017 18:56:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=Hx-languages-length:1478, H*r:sk:DB4PR07, HX-Microsoft-Antispam-PRVS:sk:DB4PR07, H*RU:sk:DB4PR07 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Feb 2017 18:56:13 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by (Symantec Mail Security) with SMTP id BD.FB.32680.B4674B85; Mon, 27 Feb 2017 19:56:12 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Feb 2017 19:55:53 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by DB4PR07MB394.eurprd07.prod.outlook.com (10.141.236.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.7; Mon, 27 Feb 2017 18:55:51 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: Simon Marchi <simon.marchi@ericsson.com> Subject: [PATCH obv] Use range-based for loop in remote_add_target_side_condition Date: Mon, 27 Feb 2017 13:55:35 -0500 Message-ID: <20170227185535.11586-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY4PR21CA0001.namprd21.prod.outlook.com (10.172.122.139) To DB4PR07MB394.eurprd07.prod.outlook.com (10.141.236.17) X-MS-Office365-Filtering-Correlation-Id: 7a76168d-4f71-4f5b-0203-08d45f42407e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB4PR07MB394; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB394; 3:It1dN27XEdfjeWxcnGdN/Wls/CP4SG+kTbWQIW3JkamAvHf0hwUXr7yN1KbdUanQsqzLtVixdc1Rw+flJCSqQyVxm/FpvAqg62Pz3eWExDWlMUhYaYTY74LmdbxtGHl6oZ+i8qieHndg2KSzMAJDQUagMb1jY1JWbxs20/5mTQ70+I69iuW8+YMUCx5mbt93zhZTmo28bgibmL3LGNu3ggHvkjfXqsOHHxSA/+3u+fQMcua/PUTuEp5p/Or+sdyjSlqYJJ9q3M4Qdr4gELe9gg==; 25:KbBWdyIAhRwUC1081QLfN7azjFarTFfjFI94YWJZMHsAmtTBdx9v8f6jDyTcZhFlmBCEs/u2FT8ERIRlBy9zgMarBMonHIhoR5QPXVeCzgKvmabTMZQXsgMYX3982duOiDxoaR7zbqvIpx1M8MibpEU0g7kccSbW1NEzW7KyZcX4ltWNCJYwyRSmag1mCLtKpw9SqgJavfxpiT7nd5CNis1+qhE4SEewYWrRDRUg/7zt41KUGMUof0VvoHojccu+puOkpQRiomHk1yvRbShnEY1d9XQrTs+Q5DCOqIRdwwkd3u6hpS1YSlw7PWTg+/0V+VDb36yyywREnWU92dSJ6kHK38aseexDopdLAtqHEdfudTAGr8Bf+89sPon3f74aMkw4pMj+Eodm/1LdHyYDtg2JwMgfLsoB4N1AsyAapgXuCxM9ZDaV36nSeOwYn4PAHaDSCrJZnhnpPZ3whxh0Vg== X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB394; 31:nxk3Mhf6FpHYB32jkelf5niWZ8tubvoLTZvX7djzWOjk1v7VYCSI+eb7prxKVBfZ4fs0T7yiwMyIZyY0ysRQg4TwsYQcSPVKfF66OYZEc64X7Ec+JThBlYHsg1ZqD0m/+9QTmgXD81jnJiuplGib3qIaw3l5JHFFExwSlFdPGlQaposYDtJfVXCYj2v6bA9OmOd4iiCJzP7R1PHbokLWXNgKc3+0OUEFvoilKlzC6jk=; 20:bP6nA46nyo1rfe8MU35aM7VjnrchLe/ObjPsa3BPa5qrt346jcgvdR84y9R6dTkxmdzut6NymR65KFhOP1V89WSbC8ZnM4iiqt8rZrFLEAgs311QygwkMTQIp9DOKKcYgvpjmLowWJehOT4ecFocIRIQYqQN89dwQMAMlHlp0YzcglsXt1liLOJJUdnidId9REhzlG+fxoSXSmgfxT18+F4osOTXsBWzhIkjUnwEjef7HPNQWkBuUzg0MzT+uzatDkbwwTgs5zarEjTJpy0wOy/mSylajkp5z6+m9btCGrZBqyATL+zndVUd0k9Crhga6Va9m8b7cflIyB0LZl1vG8FiU3gyIhbNk1L3ghh3eFQ6EdFgi2kiMuDQ+sZY7uxUt4n2PyKgiJhm51kARiLG1jYO+A3dMPiu/Ib3LREoz0b2MJm1vAZBpf8TguZPXXWeKg+isskqnRSt+7IzSA8C/Gp+uAuPpFNs1lic266Xm0Dwrq/dgUDBGtB5x7D7Uh7J X-Microsoft-Antispam-PRVS: <DB4PR07MB394D09D66729D33792902C3ED570@DB4PR07MB394.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(20161123558025)(6072148); SRVR:DB4PR07MB394; BCL:0; PCL:0; RULEID:; SRVR:DB4PR07MB394; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB394; 4:jacanY8OQr2yzyZjCiEnpAs0bnChVS/8Vs+9P/7K4NQ/jAgbnlK0Yq6f4u5Er4H34TGMVZcE6yUCvrsrlls0krSTnJNh67kfgs0FXceakrcV8qafG3wWxyfpvirYjBdiVB8/WqbIZ9BfT9iaWlB0DRch+atkiPFt001yEGb9mgx78VxGrOe56h7Pow2bbWLyvHsW2gPtgiPVg3FkLkYmVkhz0GpqsGxLRLRipv6H4Ircmt0fwaJUw3SJ80fkRgpddcXebz63LAT8SKj84Dc3rMeqd0rFK1iI3Gzc3C7+oPe8UUU7Je/xIj1wrK2sb5pk/jErJMdzkOHXWbuVj7VUMomyp4oCKE6FpdxMzC+MtQwAyb40fSyd38Bx78pkrby2+6bpcdwE0Gfkrla0rTOnhgHR75rEjFOgqtCl1gUJqUxujZCRZTjOvu9vw7IeThVv49GLpDxX1tODrcK45ysqPKyPGGkZTUzxfCyxWoq1+NuwEMxjx5wArVC2ZZoNkXUjegvq4c511CIht5/6afdNHdFHYmmSQzcFMa0lDoR1OY+vaxcaSgZtwdkQx80SZaIeIE8yTHj/GMn9NzgMH2nKv/y6xb5MS/pOU1vABBEwCjKpimFQYc99I7HwHACQlt9FKEiqOoK7Oyd9vo8RGnKW+Q== X-Forefront-PRVS: 02318D10FB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(377424004)(189002)(69234005)(54534003)(68736007)(5003940100001)(189998001)(66066001)(47776003)(50986999)(101416001)(107886003)(38730400002)(110136004)(36756003)(42186005)(2351001)(8676002)(97736004)(105586002)(6486002)(106356001)(48376002)(25786008)(92566002)(81156014)(6916009)(86362001)(4326007)(53936002)(1076002)(33646002)(5660300001)(7736002)(6506006)(2906002)(6116002)(305945005)(50226002)(3846002)(50466002)(6666003)(6512007)(450100001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR07MB394; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR07MB394; 23:EPTCTFaEzh68g79rPFi69otY6GGe+C5xSHZouP0XlT?= =?us-ascii?Q?/0Z073AMaC7uxb84zAsVtX3YbVAdirK7AXgpLw20c77keq6U3daXB3QNrJ3X?= =?us-ascii?Q?qadcVax9cHE5YIG6VIobOWBCjWIVVRQYePKCN4oU6+mFm30sSmSqriKHcm7N?= =?us-ascii?Q?8gU0gdocUMXW4E+VJUXjCRQdfZnYFhK2Rsmvxa3uko+EA8TmBP7c5RnXEVGJ?= =?us-ascii?Q?JZW7K8nuR0nxTA2L7MCl0Nsc9uHdrrTQAZEVvk+3Gqor8CWsg+CgBfSUQo8o?= =?us-ascii?Q?2ltA4DrP+F45mQKtumm/9E6kq/kUK3IAJ0SIdBmmrv7af9jGYvFTZMrc6SdV?= =?us-ascii?Q?3j8BqpOBg5yaGSJAkNO7z2jcFwWHvvNBEGsrVRPu4XSAImt5nvWMCR/qeKwx?= =?us-ascii?Q?ARcYT7tqbGoAc7WCaxGaNmnLVz9pZwcHpdRTeqsg3eI1hKi+FWTAojXfzxq9?= =?us-ascii?Q?ijQM6uRFvuHk5cMEkbubdLvvSQobySWSNdOfPNpz/uElCEg4PUutv7H9lgLv?= =?us-ascii?Q?aIUzM/BnICwW6+BUCUYd3WC8n/9qf0CQAL+5i8JfKrZ75Y+B94elwu94OTze?= =?us-ascii?Q?XE7US3EkE/I9Evvcy4x3vtchs3/FvDmmTw2Rtkw91suDen7SW1iVlfipQaUs?= =?us-ascii?Q?PZ4SKo6UuBeo7B7Uawd8/ac4wWsBy9JYovkzR8S9Vm647LqfTH95EFkS6GoD?= =?us-ascii?Q?dhrobasmPOUaPkK22PiVO9ZVAu5uAzVQ0lLLMseYKzgIoGf2DjX2yEb7vonf?= =?us-ascii?Q?yRxOlhO7EGhmsQHqaSi/cv8E6D9cht6TijizCqot6fBzgjnTbvqR7K9nA5hD?= =?us-ascii?Q?sp5kPTQ+LL+/rer45t+EpC7lJySy2vbaGK0LU5Mn6IBX69bkaI1zagDx2oBU?= =?us-ascii?Q?TRoGqB87gBiV5L4o2A18yipPlYRXoA2Y0qJDU7C+CHfERFOjHDjkV3GFDVfo?= =?us-ascii?Q?uWBJmiHg5jYNARwXsQgNK0iccQ50+zS4jZoKmBCyuTm3W48TlbGcGNgVAmGQ?= =?us-ascii?Q?eJLVxOUgWqcEhyG0fsrfnz30Fem3pHamuRIGZw0an9Hh1tQqbU/0IiCOUzhA?= =?us-ascii?Q?pChMcHWT6MJ61p5y2N6BKOpLFl5miuKregK5L59uDrKA4JTyBjiIJeaO60Sx?= =?us-ascii?Q?WZt+8DWmVRwMX37Vlf5TiuIv7XZyI7n1EHjqN+umIRiwMiXwuvnTdZl6Fxp0?= =?us-ascii?Q?g/3ZiY8gQWcWreVRxiJPi9Tzf47JuMjbuR?= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB394; 6:LrHYDFgqSOkYNL9jr1U4TzKe8X2adqRYUOHvaOQHnbjfPIXkN5EgjXEvgeGyjEJrYfUjwtr2ULNyvf+3H8hVv88Bz3smO/KSnx/sp+46L8z0r51Dz6L/anvJuoE5azDRDCrntAnn7WT5pY3XxeTyXCvy4aA4dFi8hyX/1MKBXYYTXVnCSeKu+yDjgf23HQIaTaXO99NMioc6+VYqpXP9jLLF5B5QtSHU8rSg4+4iEmwYRn7AYVWTvOGO4/edyxuRXubBR4zca79lOuE0YUyPWV5F7+a510EKLDsImA2EGkeQrAyrV694wK7dM6EprjGnnL/oIMM1RiEWEifTorFvjgJuUwcT5XG3RgIijTk9SAZiahAxeECjI6vvcv00nd7iXymUBz/HqgtNwj0jAtdcVg==; 5:0nzm+E9dkmTsnglaJipFS9jVBz5/2sSJN534A0Ttv7O4nzvvjW2Utvc4MU6cHMVA5AjxpMDC6VDIT4DTXQwFwG8P8WGboyVa6aZe2osR3NZpWqn/e5uKyQfRta+z6RLO+M36EppGgZgFQUeIMr/U/A==; 24:NLKpg1WsetephOHzqk9eEJicsBTIaPHkAkRtJxUCI/qYYqV1uO5zSnNmVTFNVsXr0aeMPD+XoGnoXXkxwyI2YNZedjmPTd+9/uyQOD2zBxM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB394; 7:colGMdxgTZ4NAd3SUd5cI9nEZ4AXrMfy3QF5Q7gU35lwfMa9CSDyC/1OllWVmW4lP0ccHzm03xWb4L/Uc+upkHR5WvbqdyCie7+a/XQjkQ6lLxmQlMMXt1Nvjksv8iIMKI47HdfeHrIjp8+uxQhlZ7hjXxRUsTfgAPf77bJeFqyvBTAIAKMSxGT2STbej9j94x2LX0Qcn6jWeUCJGkrjrcqU9p5lGSHjqBEzSlpyMCc35to/P2k7JMXu5PVDe2mffEm55oRJjZ1Ek8iB0l388qHwXgniCZ90RXBDJIrYUu6Jp1xzY14HW7nN/R5E237Abkz6rx1qL9Hv8Afac4LXTg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2017 18:55:51.3843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB394 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Feb. 27, 2017, 6:55 p.m. UTC
FYI, I pushed this as obvious. Using a range based for loop makes this code a bit more clean and readable. The comment above is clearly erroneous, so I've updated it. gdb/ChangeLog: * remote.c (remote_add_target_side_condition): Use range-based for loop. Update comment. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 6 ++---- 2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a7be8266ea..a872f1bfb9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-02-27 Simon Marchi <simon.marchi@ericsson.com> + + * remote.c (remote_add_target_side_condition): Use range-based + for loop. Update comment. + 2017-02-27 Yao Qi <yao.qi@linaro.org> * f-typeprint.c (f_print_type): Check "varstring" is empty first. diff --git a/gdb/remote.c b/gdb/remote.c index 87fb6e02ea..aedbd08cc4 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9664,11 +9664,9 @@ remote_add_target_side_condition (struct gdbarch *gdbarch, xsnprintf (buf, buf_end - buf, "%s", ";"); buf++; - /* Send conditions to the target and free the vector. */ - for (int ix = 0; ix < bp_tgt->conditions.size (); ix++) + /* Send conditions to the target. */ + for (struct agent_expr *aexpr : bp_tgt->conditions) { - struct agent_expr *aexpr = bp_tgt->conditions[ix]; - xsnprintf (buf, buf_end - buf, "X%x,", aexpr->len); buf += strlen (buf); for (int i = 0; i < aexpr->len; ++i)