Patchwork SPARC64: update localplt.data

login
register
mail settings
Submitter Aurelien Jarno
Date June 30, 2016, 10:26 p.m.
Message ID <1467325577-32277-1-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/13540/
State New
Headers show

Comments

Aurelien Jarno - June 30, 2016, 10:26 p.m.
Commits d81f90cc and 89faa0340 replaced called to __isnan and __isinf
by the corresponding GCC builtins. In turns GCC emits calls to _Qp_cmp.
We should therefore add _Qp_cmp to localplt.data as otherwise the
elf/check-localplt test fails with:

   Extra PLT reference: libc.so: _Qp_cmp

A similar change has already been done for SPARC32 in commit 6ef1cb95.

Changelog:
	* sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data: Add _Qp_cmp.
---
 ChangeLog                                           | 4 ++++
 sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data | 1 +
 2 files changed, 5 insertions(+)
David Miller - July 1, 2016, 8:38 a.m.
From: Aurelien Jarno <aurelien@aurel32.net>
Date: Fri,  1 Jul 2016 00:26:17 +0200

> Commits d81f90cc and 89faa0340 replaced called to __isnan and __isinf
> by the corresponding GCC builtins. In turns GCC emits calls to _Qp_cmp.
> We should therefore add _Qp_cmp to localplt.data as otherwise the
> elf/check-localplt test fails with:
> 
>    Extra PLT reference: libc.so: _Qp_cmp
> 
> A similar change has already been done for SPARC32 in commit 6ef1cb95.
> 
> Changelog:
> 	* sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data: Add _Qp_cmp.

Looks good to me.

Patch

diff --git a/ChangeLog b/ChangeLog
index 9131b1f..497bfe5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@ 
+2016-06-30  Aurelien Jarno  <aurelien@aurel32.net>
+
+	* sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data: Add _Qp_cmp.
+
 2016-06-30  Andreas Schwab  <schwab@suse.de>
 
 	[BZ #20262]
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
index 633cfe4..2323551 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
@@ -1,4 +1,5 @@ 
 libc.so: _Qp_add ?
+libc.so: _Qp_cmp ?
 libc.so: _Qp_div ?
 libc.so: _Qp_feq ?
 libc.so: _Qp_fge ?