From patchwork Wed Oct 14 11:11:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 40718 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 930983861812; Wed, 14 Oct 2020 11:11:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 930983861812 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602673887; bh=5M3p0wDF7mGEtFRZ74T9lLXspsqpR2Fk8ZQcRaVKrUI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=EG9N7eQy8h6qV8JiJQcHNn03NIzfwfIZfVzM9YBSX/lQr9m81U0qh/buF5qQiccFl NLHr3Yy8h5f93Zk0LXYeDPeF9WmBGyx6WhGrWriMPPdRoqKuFEIoKxrOnkD2QLhNhx FJX/LWgs4tvLQjbujDuJWjOgA/eNeJBoVn6nRn9o= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E669F3861812 for ; Wed, 14 Oct 2020 11:11:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E669F3861812 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-rvPqeYu6OB-V7FPOJfbWrg-1; Wed, 14 Oct 2020 07:11:08 -0400 X-MC-Unique: rvPqeYu6OB-V7FPOJfbWrg-1 Received: by mail-wr1-f71.google.com with SMTP id i6so1124510wrx.11 for ; Wed, 14 Oct 2020 04:11:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=5M3p0wDF7mGEtFRZ74T9lLXspsqpR2Fk8ZQcRaVKrUI=; b=IKmSvp+MGe3tbiGI//dQSKXnnIenBGcs7PKXd5b9Ymkqpt98XBtgHZUZQE341AgpCJ 0pjGyZ8ok0tXWMOBzyWmX2Z5auC0Jz2NKa9WPe6797iI2eooAfYY4hSh1QUBHKW5Jsjs 1T+z89hs+l2sl/2Vklj1dK5bMtElukLtZrZtOsu1pyOJg5s8oHYBzI9/ARhyGwG2TN1O UmQOqsvXVMCFzWC20J3p3obBa8gM+BKl7KjVJMfTZtw37LJ50Q9Rd9pVQLb1Hd8jgWWy Iwh28B0zyH731bk4w70Mk1k2yAk2fU95p7cmc/axtHT4HxEQy7EUUqhK64T0GHg+CQHi niRw== X-Gm-Message-State: AOAM530zzBvU5U5/DYsPHDbpuBGgsMqHIhIdOCfezjgyQTa31m3DXQem WZUxl0qDw3WLYSfZtWJ3a3ChB8ij7tMMUAkYbDAg14/2ZB7dP9YFeX9+Lrk7pu5xnHDeBTLdoHn NXs5qLTHEWG18VOx8gdls X-Received: by 2002:a1c:40d5:: with SMTP id n204mr2843980wma.148.1602673867136; Wed, 14 Oct 2020 04:11:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfYBPZ/TxIIZIxRnvixoeSL3NHwCImh0KKNZMBliqfe9iQbwi9TVMxoORSx2MNgR74t4Lp3A== X-Received: by 2002:a1c:40d5:: with SMTP id n204mr2843959wma.148.1602673866854; Wed, 14 Oct 2020 04:11:06 -0700 (PDT) Received: from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130]) by smtp.gmail.com with ESMTPSA id u5sm4790333wru.63.2020.10.14.04.11.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 04:11:06 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 5770F5800FC; Wed, 14 Oct 2020 13:11:05 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH] configure: Support ABIGAIL_NO_OPTIMIZATION_DEBUG environment variable Organization: Red Hat / France X-Operating-System: Fedora 34 X-URL: http://www.redhat.com Date: Wed, 14 Oct 2020 13:11:05 +0200 Message-ID: <87tuux9i5y.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hello, When working in development environments with compiler versions that might be very bleeding edge (like the Fedora Rawhide distribution) it might be worthwhile to disable all compiler optimization to have a better debugging experience. In practice, I bumped into this need again and again. So I am adding this ABIGAIL_NO_OPTIMIZATION_DEBUG environment variable to basically allow the "-g -O0" combination, if need be. This patch obviously doesn't change any existing behaviour if the user doesn't set this newly introduced environment variable. * configure.ac: Set the CXXFLAGS and CFLAGS to "-g -O0 -Wall -Wextra -Werror" if the ABIGAIL_NO_OPTIMIZATION_DEBUG is set. Signed-off-by: Dodji Seketeli Applied to master. --- configure.ac | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index 904a726e..84a781a2 100644 --- a/configure.ac +++ b/configure.ac @@ -626,6 +626,11 @@ if test x$ABIGAIL_DEBUG != x; then CXXFLAGS="$CXXFLAGS -Og -g3 -ggdb" fi +if test x$ABIGAIL_NO_OPTIMIZATION_DEBUG != x; then + CFLAGS="-g -O0 -Wall -Wextra -Werror" + CXXFLAGS="-g -O0 -Wall -Wextra -Werror" +fi + if test x$ENABLE_ASAN = xyes; then CFLAGS="$CFLAGS -fsanitize=address" CXXFLAGS="$CXXFLAGS -fsanitize=address"