From patchwork Mon May 23 19:14:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 54310 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4E813857413 for ; Mon, 23 May 2022 19:15:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4E813857413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1653333321; bh=bZgnDi2aTv0gL320oB5s3zgZiRjhE1tNTFek+W4LEVY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=H+L/Q9mtC+tEU9lDDbTdW03tLf3anvC32eeM3aleIruvYAuQR9NcoMg30vfgMeLUs 7KlpwiHoNpj80QVx2eF2lBuxXTmw6jqlry8hZygFPqzrPV2cgud2jUtbKemkiYvzWi XvTvMYQkcXcTeWxx5Ensc5eZby38rzg76dZwkLgY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7C26D3856278 for ; Mon, 23 May 2022 19:14:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C26D3856278 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-QueqbcyJPAuoBt41nVtXfg-1; Mon, 23 May 2022 15:14:17 -0400 X-MC-Unique: QueqbcyJPAuoBt41nVtXfg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A41F63817A63; Mon, 23 May 2022 19:14:16 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E56B401E3B; Mon, 23 May 2022 19:14:16 +0000 (UTC) To: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Subject: [committed] jit: use 'final' and 'override' where appropriate Date: Mon, 23 May 2022 15:14:12 -0400 Message-Id: <20220523191412.3784267-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-715-g58c9c7407a1a99. gcc/jit/ChangeLog: * jit-recording.h: Add "final" and "override" to all vfunc implementations that were missing them, as appropriate. Signed-off-by: David Malcolm --- gcc/jit/jit-recording.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h index 2dd8a957ca7..0dfb42f2676 100644 --- a/gcc/jit/jit-recording.h +++ b/gcc/jit/jit-recording.h @@ -721,14 +721,14 @@ public: /* Strip off the "const", giving the underlying type. */ type *unqualified () final override { return m_other_type; } - virtual bool is_same_type_as (type *other) + bool is_same_type_as (type *other) final override { if (!other->is_const ()) return false; return m_other_type->is_same_type_as (other->is_const ()); } - virtual type *is_const () { return m_other_type; } + type *is_const () final override { return m_other_type; } void replay_into (replayer *) final override; @@ -744,7 +744,7 @@ public: memento_of_get_volatile (type *other_type) : decorated_type (other_type) {} - virtual bool is_same_type_as (type *other) + bool is_same_type_as (type *other) final override { if (!other->is_volatile ()) return false; @@ -754,7 +754,7 @@ public: /* Strip off the "volatile", giving the underlying type. */ type *unqualified () final override { return m_other_type; } - virtual type *is_volatile () { return m_other_type; } + type *is_volatile () final override { return m_other_type; } void replay_into (replayer *) final override; @@ -1051,7 +1051,7 @@ public: void replay_into (replayer *r) final override; - virtual bool is_union () const final override { return true; } + bool is_union () const final override { return true; } private: string * make_debug_string () final override;