From patchwork Sat May 7 01:43:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 53568 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 491F83857357 for ; Sat, 7 May 2022 01:43:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 491F83857357 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651887816; bh=XBTkd8jJc+q2SvsENEG/T0ajoLIdTQN88Jm/y/Yp11k=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=BXUUgBhqAMxEJfjLDbSFUJDRmKHS2J3yQfj+BNqLm9n0ZDh9uY/tg2A48vRHr0Sp3 /MfwPUuE/8hp8rh3607rCKYGV3J/JJ8BA0CtzoDVNRWnJftVW2UaUhMsZB3OU0l6wL PAKM7Kx7sV2CIv74wm2XWBHbXT6BGARODN0ba9Z0= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9A0E63858C53 for ; Sat, 7 May 2022 01:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A0E63858C53 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 246KnAul019339 for ; Sat, 7 May 2022 01:43:29 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3frwntfjk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 07 May 2022 01:43:29 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2471ZQA8039192 for ; Sat, 7 May 2022 01:43:28 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fwf7004cp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 07 May 2022 01:43:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hoJu7a93y+zrw6t0aDsakidMuSi8eGVkDJI3zr8Lgj8YJm1SIGU8Nxgc/OEHxE4zt8qOasFHQQuVdFfErWuzEHkRagsRGvpibLm+63njRI57StoPFIoVMm10lNVyalcs77fwXYEod+PWeF9a5FMe8R6vGGfApg2CpXfD/lumrZygMPv57HsVM758lAClmhZo6GqRK4Bk8O0BvmW+ZUiC/8hY8YCEFPxUx6v/6d093+2OPm1jjLBSACKwnKhx09XmUaPqNFX9GJyxW53J3pdgSc8bOeScgCKVWPZ28RQcdq2hHbnzqRsM3B5+g7oJ+aT4I/EcAAgiup9aPzZnZNuHHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XBTkd8jJc+q2SvsENEG/T0ajoLIdTQN88Jm/y/Yp11k=; b=km5HVcubiy007j3rXdL8v6nyPyCQ1Y+5vc1msawqcr4qF1NB0OU+DwUHnLqECyeZOjaUFgyKt6gkKQe/tT5tSlgQW+zxlUDleaRQjR2rf2A5rNRQfxWN4K7W/BLQmnKokQUpdwTfnzYF0RFOAXXBi4zbrxQ4ibuTrdYfDaDB9eUyKs58js+5fT6VLBY0LQ4sxk9vGOEhNQItwHZLdKbFhYLfZDwOD5HbdtiAwHH1LjlWyUcL7zinCXWZA8CacJwUuzD19DFEnIoHp+lN3OP9yftodfjz9aIDCSQ+ta9NZPRbcRNBEeQ4p8IFEAh7SMpvQstlI3nC/DVyl/FYuUxxqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by BLAPR10MB5347.namprd10.prod.outlook.com (2603:10b6:208:328::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 01:43:26 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::c88b:fab4:f199:fc1b]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::c88b:fab4:f199:fc1b%4]) with mapi id 15.20.5227.021; Sat, 7 May 2022 01:43:25 +0000 To: libabigail@sourceware.org Subject: [PATCH v3] ctf-reader: shows incomplete summary changes Date: Fri, 6 May 2022 20:43:05 -0500 Message-Id: <20220507014305.1416381-1-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220502224626.748068-1-guillermo.e.martinez@oracle.com> References: <20220502224626.748068-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: BYAPR11CA0045.namprd11.prod.outlook.com (2603:10b6:a03:80::22) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc2f7087-88ae-4cd9-045b-08da2fcaf828 X-MS-TrafficTypeDiagnostic: BLAPR10MB5347:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uRDFtCb8bM8Yp+mAuHYE6IvDQVd0IRLIuDSrqxyGhhk+Ndiyqi57+PEjK/0ggiP3IQbBypkvOgOK+iVdlyv2v+i69iHNq8RLEGKTLDI28iXgDT0LQBRU2CEpH2CprLQ0atqPiBwiu9mHA3W2K8K4c4VsBb1AbImfLNydWCqaIzmEJUJUuJticNifQDirOg2PdT+kkvbaPV3V5SzuQmtvEWcnUbDnrgtMl28s4POIGoiN/zdQc2g0sa1LnXyxlPDPzhIdMAaNPauFvBGzMqMWiF8gScZkTsZuCPa40eu3aLB5sjdT0SJXIpThj6G5UpVmj4lEXCr/mDrlabBU/xARt9RttYRyCwaMtY5HT2wOFOGZy5roBMjm1JMp2Soq4LxpYqplQYsRlGT31nLNX/wUbgBqlvN8OKtPfyQjKv9CvnYWFKnRC+uq9WQYa44u3fzFqvPZeB/aoFPCfHtJgYadWEsifaSpr7N3KDN880yZgrWXIc7VNDfA96tAbgzpifq0jVBCN48dv7gcshp+JkSzcRL39T5LG3uREGSayl4iHQZxni/962leHGE6+M3/D3rOYSmhRWdCBCv0L1e0Oof3SXOEHXKfsmKCeV0uTi+P+djFdUuLM7YtLGRdpNIK8k/iG6V2eGykL16JD07OGJPu4/aWHy5hLAMLl3a/NjBiiXVFU7J/T0Fl1E86qFcbEQSU0zzr4wFCfUhJ5fph+9DMB8tlLOTVqy/cdTPL379DGUE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(6916009)(6512007)(6486002)(508600001)(6666004)(52116002)(2906002)(966005)(316002)(86362001)(38100700002)(103116003)(107886003)(36756003)(83380400001)(2616005)(8676002)(66476007)(66556008)(66946007)(1076003)(8936002)(4326008)(186003)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: S/HGvynBx1Gt6hhIk/FHKwr2FUI1oQZ5+juqnV5U3sAQYbgLwEcOVrAmGQvfJWS6vs9TxL0nve9IKXKV3ZAkObwRnlUw4IKX6wGHkA+Fftx7HqGFkinGbkEEjvF7eE6EMzSX5G2GfkOynJpczp7lGGkxovDAYkkluNRSGH7f8VHRsBES7YOULJbDHUuwf3YbQCym6kL7Ml4RykTnKczquXJTqDi6nsHbe4QDDUcthsA1TGV1reKVveuldBH8DqXEevsbprMJpF/v97OFJctEi5yi9j8oKU3QIT5ekxVrzPrxXYckVW0Ll+IgakNysUXVLMs9qVfJBy9xhxmi7IijH+URu46GLCVTguni2XcEnSCAriqzuGZo74Zg4w5FnVGWU+XlTfoSsqH40kcY3qvs/N/T91Z62tEtQFKQ62peVUclFR0vu2pWKFxRv5c8p2QMraserlAWnW0KxPLuvOxLhAjUTArLwvrfv+QRHSUO3bwTV4kEteoPUCjRBxnYPVdHVXxnh/LOsOHXNpZazIWsvFdkWX29QZFHARLXyGPP8rH/04XDRuuWsKgmdRXUqinHDrGHKIHY/yH8n3C5EIHS1DuJ/Vzk8UaiOZqywq1EP7Ogpdo1DQpM/E54E1jwsarSvhar3eCYHp3ULjDhQKNytftUKEAzjKqHx0L7bhP2S5ew3HY2Q1Kig6Capc+FooE7+PdUjFRzv0qxkFbtdQQd4fmy+GrCeuwQRpMW5OFUYPFPc5GhMeT+uXookaa4Kjut4sk+LATVHmo/dqdQjLpIec0VCRLTTAeFjDYqACO3s/JX/wX04k2UC00weuHXHcdvorhJxhMG0B1ytxg96DRHIEwTKkFfWqGhU2UDaPJxdGPavCHteQ8hp6nvbJRXTE/N9uXA/9DnsmLr03gOIsV51NW2FbmFvz9WjRMgZ+VSSZlVoynPPk4rhIG5Sj/JQR8en0LtqQJ5ELqx6UOpbZ6bHUDqt6fFSizi9vZLZUOtmN3BYjcoiiAC02M8tlffdpgW90xzKx/XiAwXSE2dS4QTbUqGPOVBI6OYanZBIYhJYFnKajFkix2Tait/YW5sxPu5wc7jA8YW50ArmSi5tMJS/Cx2mV50BLKWkvPGX0DXriZHcQ9HHAOwtroNBaeZjkY98IsW49VAiIqUuK76MoqYc03PxTtDnXJytvCg2lMMO8ZveucM8b1shElI9zaONi/mBaxPtglX+gbb1x3yap2ns9Wg4STDweivfhu2nuN6CH5TXVfqtsulsljFeGCRwLQZFO2K8yPnTi5EvhvFDxq3Sm7CoBddebMMTzpPEcjl2ytThmOTMsds8FIeEgBxS7mWnJItEFEINLyU8uLsUH57EmbVHXxvtTj9yMK+1O6x3EGLt1Yri6LJwtiFHGTnBfMSrOneXFCCXLAFlehlwYXTRdd+vGdrpEZ/0O/hNJVeI8NqbFyHwOjaWpOTRsADJ7J2NdsBzvEOt+CGqoMLcXwPsagEl0/Mo0s5sVg8pnuqaIBc3zOMWdMUW1R6GYelUB24J2M5/cOJEeByygr7EhcF7Khk6BghH9bhs/WqwS1UdffpfZWpaCWB3dO6lxRxtBbxQppI/HXmrQmUFJCY1a1mpYEcaylZpni0ghWtgFUMa/RR7RpFb5bTiXb3W/ITmf/aZ/jW3q3jXCTKkioLowo9fsZbcVGvujhei2WuRTVAFX9zmtHVLPIOFq57nZqpKORnMDPSUy4C0ea5smnETR/Pba9GN9CGywm75Qo783HI43ud/zNDtf7qnVKSh4C5+acvj6LUpXvf X-MS-Exchange-AntiSpam-MessageData-1: Ahu7e/L5euYlUw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc2f7087-88ae-4cd9-045b-08da2fcaf828 X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2022 01:43:24.9146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r5AXhKxLOFbQzYk3bCp3i4ySfgopews7X7W4Txbb61qlhBC7+wx0f3ID5KZhEqJD97rhaIBSF17El/x7aJBfvfWbzfM5A/XhxbHRLoolGVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5347 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-05-06_07:2022-05-05, 2022-05-06 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205070007 X-Proofpoint-ORIG-GUID: snGUSjxobYvC1VHFmsYKWAQ0j3Qpy-yq X-Proofpoint-GUID: snGUSjxobYvC1VHFmsYKWAQ0j3Qpy-yq X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello libabigail team, This is the patch v3 to improves the output summary changes using CTF reader. Changes from v2: * Rebase against master and work in latest comments of depending patch: https://sourceware.org/pipermail/libabigail/2022q2/004340.html Comments are highly appreciated, Kind Regards, Guillermo During corpus comparison with ctf support, summary changes for functions and variables are shown like to the binaries doesn't have ctf debug information, even though they were compiled with '-gctf' compiler modifier, e.g: 2 Removed function symbols not referenced by debug info: [D] elf32_test_main@@ELFUTILS_1.7 [D] elf64_test_main@@ELFUTILS_1.7 So, expected changes summary should be: 2 Removed functions: [D] 'function long int elf32_test_main()' {elf32_test_main@@ELFUTILS_1.7} [D] 'function long int elf64_test_main()' {elf64_test_main@@ELFUTILS_1.7} * src/abg-ctf-reader.cc (read_context::exported_decls_builder_): Add new data member. (read_context::exported_decls_builder): Add new get/set member functions. (read_context::maybe_add_{fn,var}_to_exported_decls): Likewise. (read_context::initialize): Initialize exported_decls_builder_ member. (read_context::build_ir_node_for_variadic_parameter_type): Add new function. (read_context::process_ctf_function_type): Add additional code to handle function's variadic parameter. (read_context::process_ctf_archive): Rename variable for clarity from `ctf_var_type' to `ctf_sym_type', using new member functions `maybe_add_{fn,var}_to_exported_decls'. (read_context::read_corpus): Set `exported_decls_builder'. * tests/test-read-common.cc (test_task::run_abidw): Fix error message. * tests/data/test-read-ctf/test-PR26568-1.o.abi: Adjust test case. * tests/data/test-read-ctf/test-PR26568-2.o.abi: Likewise. * tests/data/test-read-ctf/test-anonymous-fields.o.abi Likewise. * tests/data/test-read-ctf/test5.o.abi: Likewise. * tests/data/test-read-ctf/test7.o.abi: Likewise. --- src/abg-ctf-reader.cc | 104 ++++++++++++++++++++++++--- tests/data/test-read-ctf/test5.o.abi | 1 + tests/data/test-read-ctf/test7.o.abi | 1 + tests/test-read-common.cc | 4 +- 4 files changed, 101 insertions(+), 9 deletions(-) base-commit: c96463e1ad974b7c4561886d7a3aa8a3c9a35607 prerequisite-patch-id: 781b026536589341e1e4378d9529fe258633bb53 diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 030f8fc8..5cb6fe19 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -84,6 +84,52 @@ public: corpus_sptr cur_corpus_; corpus_group_sptr cur_corpus_group_; + corpus::exported_decls_builder* exported_decls_builder_; + + /// Setter of the exported decls builder object. + /// + /// Note that this @ref read_context is not responsible for the live + /// time of the exported_decls_builder object. The corpus is. + /// + /// @param b the new builder. + void + exported_decls_builder(corpus::exported_decls_builder* b) + {exported_decls_builder_ = b;} + + /// Getter of the exported decls builder object. + /// + /// @return the exported decls builder. + corpus::exported_decls_builder* + exported_decls_builder() + {return exported_decls_builder_;} + + /// If a given function decl is suitable for the set of exported + /// functions of the current corpus, this function adds it to that + /// set. + /// + /// @param fn the function to consider for inclusion into the set of + /// exported functions of the current corpus. + void + maybe_add_fn_to_exported_decls(function_decl* fn) + { + if (fn) + if (corpus::exported_decls_builder* b = exported_decls_builder()) + b->maybe_add_fn_to_exported_fns(fn); + } + + /// If a given variable decl is suitable for the set of exported + /// variables of the current corpus, this variable adds it to that + /// set. + /// + /// @param fn the variable to consider for inclusion into the set of + /// exported variables of the current corpus. + void + maybe_add_var_to_exported_decls(var_decl* var) + { + if (var) + if (corpus::exported_decls_builder* b = exported_decls_builder()) + b->maybe_add_var_to_exported_vars(var); + } /// Getter of the current corpus group being constructed. /// @@ -228,6 +274,7 @@ public: is_elf_exec = false; symtab.reset(); cur_corpus_group_.reset(); + exported_decls_builder_ = 0; } ~read_context() @@ -379,6 +426,26 @@ process_ctf_base_type(read_context *ctxt, return result; } +/// Build the IR node for a variadic parameter type. +/// +/// @param ctxt the read context to use. +/// +/// @return the variadic parameter type. +static decl_base_sptr +build_ir_node_for_variadic_parameter_type(read_context &ctxt, + translation_unit_sptr tunit) +{ + + ir::environment* env = ctxt.ir_env; + ABG_ASSERT(env); + type_base_sptr t = env->get_variadic_parameter_type(); + decl_base_sptr type_declaration = get_type_declaration(t); + if (!has_scope(type_declaration)) + add_decl_to_scope(type_declaration, tunit->get_global_scope()); + canonicalize(t); + return type_declaration; +} + /// Build and return a function type libabigail IR. /// /// @param ctxt the read context. @@ -429,11 +496,24 @@ process_ctf_function_type(read_context *ctxt, function_decl::parameter_sptr parm (new function_decl::parameter(arg_type, "", location(), - vararg_p && (i == argc - 1), + false, false /* is_artificial */)); function_parms.push_back(parm); } + if (vararg_p) + { + type_base_sptr arg_type = + is_type(build_ir_node_for_variadic_parameter_type(*ctxt, tunit)); + + function_decl::parameter_sptr parm + (new function_decl::parameter(arg_type, "", + location(), + true, + false /* is_artificial */)); + function_parms.push_back(parm); + } + result = dynamic_pointer_cast(ctxt->lookup_type(ctf_dictionary, ctf_type)); if (result) @@ -1131,22 +1211,22 @@ process_ctf_archive(read_context *ctxt, corpus_sptr corp) for (const auto& symbol : symtab_reader::filtered_symtab(*symtab, filter)) { std::string sym_name = symbol->get_name(); - ctf_id_t ctf_var_type; + ctf_id_t ctf_sym_type; if ((corp->get_origin() & corpus::LINUX_KERNEL_BINARY_ORIGIN) || ctxt->is_elf_exec) - ctf_var_type= ctf_lookup_variable (ctf_dict, sym_name.c_str()); + ctf_sym_type= ctf_lookup_variable (ctf_dict, sym_name.c_str()); else - ctf_var_type = ctf_lookup_by_symbol_name(ctf_dict, sym_name.c_str()); + ctf_sym_type = ctf_lookup_by_symbol_name(ctf_dict, sym_name.c_str()); - if (ctf_var_type == (ctf_id_t) -1) + if (ctf_sym_type == (ctf_id_t) -1) continue; - if (ctf_type_kind (ctf_dict, ctf_var_type) != CTF_K_FUNCTION) + if (ctf_type_kind (ctf_dict, ctf_sym_type) != CTF_K_FUNCTION) { const char *var_name = sym_name.c_str(); type_base_sptr var_type = lookup_type(ctxt, corp, ir_translation_unit, - ctf_dict, ctf_var_type); + ctf_dict, ctf_sym_type); if (!var_type) /* Ignore variable if its type can't be sorted out. */ continue; @@ -1160,11 +1240,13 @@ process_ctf_archive(read_context *ctxt, corpus_sptr corp) var_declaration->set_symbol(symbol); add_decl_to_scope(var_declaration, ir_translation_unit->get_global_scope()); + var_declaration->set_is_in_public_symbol_table(true); + ctxt->maybe_add_var_to_exported_decls(var_declaration.get()); } else { const char *func_name = sym_name.c_str(); - ctf_id_t ctf_sym = ctf_var_type; + ctf_id_t ctf_sym = ctf_sym_type; type_base_sptr func_type = lookup_type(ctxt, corp, ir_translation_unit, ctf_dict, ctf_sym); if (!func_type) @@ -1180,6 +1262,8 @@ process_ctf_archive(read_context *ctxt, corpus_sptr corp) func_declaration->set_symbol(symbol); add_decl_to_scope(func_declaration, ir_translation_unit->get_global_scope()); + func_declaration->set_is_in_public_symbol_table(true); + ctxt->maybe_add_fn_to_exported_decls(func_declaration.get()); } } @@ -1357,6 +1441,10 @@ read_corpus(read_context *ctxt, elf_reader::status &status) return corp; } + // Set the set of exported declaration that are defined. + ctxt->exported_decls_builder + (ctxt->cur_corpus_->get_exported_decls_builder().get()); + int errp; if (corp->get_origin() & corpus::LINUX_KERNEL_BINARY_ORIGIN) { diff --git a/tests/data/test-read-ctf/test5.o.abi b/tests/data/test-read-ctf/test5.o.abi index f7bcdeb1..1dafd13e 100644 --- a/tests/data/test-read-ctf/test5.o.abi +++ b/tests/data/test-read-ctf/test5.o.abi @@ -32,6 +32,7 @@ + diff --git a/tests/data/test-read-ctf/test7.o.abi b/tests/data/test-read-ctf/test7.o.abi index a13af174..ca572400 100644 --- a/tests/data/test-read-ctf/test7.o.abi +++ b/tests/data/test-read-ctf/test7.o.abi @@ -26,6 +26,7 @@ + diff --git a/tests/test-read-common.cc b/tests/test-read-common.cc index 9681ac27..b441945c 100644 --- a/tests/test-read-common.cc +++ b/tests/test-read-common.cc @@ -95,6 +95,8 @@ test_task::run_abidw(const string& extargs) { string abidw = string(get_build_dir()) + "/tools/abidw"; string drop_private_types; + set_in_abi_path(); + if (!in_public_headers_path.empty()) drop_private_types += "--headers-dir " + in_public_headers_path + " --drop-private-types"; @@ -103,7 +105,7 @@ test_task::run_abidw(const string& extargs) if (system(cmd.c_str())) { error_message = string("ABIs differ:\n") - + in_elf_path + + in_abi_path + "\nand:\n" + out_abi_path + "\n";