From patchwork Sun Apr 24 15:53:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dodji at seketeli dot org X-Patchwork-Id: 53150 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8ABC1385734D for ; Sun, 24 Apr 2022 15:55:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8ABC1385734D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650815704; bh=OXt22KtJJeHgMsjPFtPn2fw/bNNV2JtUxCrJemK5RZk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=ratssrhWvWO3JgjOFiCt4Sh0KWhFyOaccF/BR1U3DTI4NN0cQ7qhuELU5XE48z0f9 aKZwv9/p/hN0Y2K4rsHXCUGj+zuDMKfjVPzq3V5mjVL2iSCEJQBz6NoBph9WWOYbqt 9nfxybyjWg/BNgBflgHwqUjqio4gcD8K0cCldhpQ= X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id B9D373856258; Sun, 24 Apr 2022 15:53:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9D373856258 To: elfutils-devel@sourceware.org Subject: [Bug tools/28724] eu-elfclassify --no-stdin option is not effect Date: Sun, 24 Apr 2022 15:53:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: elfutils X-Bugzilla-Component: tools X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mark at klomp dot org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution cc Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: mark at klomp dot org via Elfutils-devel From: dodji at seketeli dot org Reply-To: mark at klomp dot org Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org Sender: "Elfutils-devel" https://sourceware.org/bugzilla/show_bug.cgi?id=28724 Mark Wielaard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC| |mark at klomp dot org --- Comment #1 from Mark Wielaard --- Thanks, that was obviously a typo in the source. Nobody noticed before because --no-stdin is the default. But it did indeed not work when given explicitly. Fixed with: commit 6398e94e9ac9a170da088768198d4a2b6e989e19 (HEAD -> master, origin/master, origin/HEAD) Author: Mark Wielaard Date: Sun Apr 24 17:48:39 2022 +0200 elfclassify: Fix --no-stdin flag The no-stdin option was using the wrong flag, classify_flag_stdin, instead of classify_flag_no_stdin. https://sourceware.org/bugzilla/show_bug.cgi?id=28724 Signed-off-by: Mark Wielaard diff --git a/src/ChangeLog b/src/ChangeLog index 6ef81862..fd87ce2f 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2022-04-24 Mark Wielaard + + * elfclassify.c (main): Use classify_flag_no_stdin for no-std in options. + 2022-04-19 Mark Wielaard * readelf.c (get_dyn_ents): Define dyn_mem outside the while loop. diff --git a/src/elfclassify.c b/src/elfclassify.c index 2f70b29a..25fe9a65 100644 --- a/src/elfclassify.c +++ b/src/elfclassify.c @@ -946,7 +946,7 @@ separated by newlines"), 2 }, { "stdin0", classify_flag_stdin0, NULL, 0, N_("Also read file names to process from standard input, \ separated by ASCII NUL bytes"), 2 }, - { "no-stdin", classify_flag_stdin, NULL, 0, + { "no-stdin", classify_flag_no_stdin, NULL, 0, N_("Do not read files from standard input (default)"), 2 }, { "compressed", 'z', NULL, 0, N_("Try to open compressed files or embedded (kernel) ELF images"),