From patchwork Wed Apr 20 08:50:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 53068 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3F2B3858C53 for ; Wed, 20 Apr 2022 08:51:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3F2B3858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1650444664; bh=DZtbve9KuBtNMHKffDq7O64Kwmu69tVoSn8NM29DcGM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mc6uhX09mxg6gPAQw6bCPuMulUinBO4+8/wHHhc9EmHoNJatu3VrlMlNxATpSdTCg 3vkMM83HBRuGBXoasunGsekyphE+ot7r0ZzehNvBkiLVoWgQodEuHEtGlLcg/dRRDr eo+zhHRCarVsMRSiq/jrSGbFSlzOKp6gL0QZhs4I= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10083.outbound.protection.outlook.com [40.107.1.83]) by sourceware.org (Postfix) with ESMTPS id 1FE813858D3C for ; Wed, 20 Apr 2022 08:50:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FE813858D3C Received: from AS9PR06CA0562.eurprd06.prod.outlook.com (2603:10a6:20b:485::32) by AM0PR08MB4593.eurprd08.prod.outlook.com (2603:10a6:208:fd::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 08:50:29 +0000 Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:485:cafe::c6) by AS9PR06CA0562.outlook.office365.com (2603:10a6:20b:485::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Wed, 20 Apr 2022 08:50:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19 via Frontend Transport; Wed, 20 Apr 2022 08:50:29 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Wed, 20 Apr 2022 08:50:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5ba316d4fb8ae00f X-CR-MTA-TID: 64aa7808 Received: from 0852d1705aa9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 782F0A44-4821-44D4-B2F5-ED9146D04EAA.1; Wed, 20 Apr 2022 08:50:22 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0852d1705aa9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Apr 2022 08:50:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arDcxhi3b30g0iTz6MCfn6UdCSpHSZ5zjKEHnNOVXTcpDh0+8UNG9rYz/Tv/hyc/5hyiyfCG8hPZd6INZ3HHcYiEiQeYhjS2zkIef4+yz4zYaNwJ+r+LjNDfmVQodCkIMMiI6Wf5eY0bdh0qq6W7otMCIgv6/hSfLo3J0bnjcbYDqpzP+OxMHh7QaB6cc/tj8Mc/+iVMGOnueuwI/qYQu8ST948QShxEj0zQ5JCbY44RQas1YzgzSmGMHqSZiI4Ox9QI2Pjzz4wIB1h8f65lM++/bMlchLm7EVL4InH/c/OD438bl1Pa+9u4ORL3Jhxj1+WXDtUqQvDMOmblsOdCPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZtbve9KuBtNMHKffDq7O64Kwmu69tVoSn8NM29DcGM=; b=dt0/UMhoN2CL/Bz4zXWVIWceTFrd/UMWkg6+gHYxFNF1HhaexE2Yj0A92lDB3Gzp1TjSsIfm6kOSaVIlIm60c7EoxeFHNHPuG6UGb016t/0/j0PWak9zIFJ9SK0PkWgNKhX1EJdCsDg+S7tcKUVdbZrnL17jM/MPekRnvH+X7iPoVPGUvVluWIFcLOOZrXS5cTMAeeZ2Q0fM/S+l6zma6Z/PF38nb/OllbxYgU4m/h5tQgCgUs3EKATKUcVyV32V60rAKn3LiyeoVJLbf5YmyCQzncK1TD50zyp9gaAQ9Ak9CYD/Gs7wVa2VxqrLATiVOz3xZvnmpGd6XWRw8YDZRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from AS9PR06CA0261.eurprd06.prod.outlook.com (2603:10a6:20b:45f::23) by VI1PR08MB3150.eurprd08.prod.outlook.com (2603:10a6:803:46::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 20 Apr 2022 08:50:19 +0000 Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::c9) by AS9PR06CA0261.outlook.office365.com (2603:10a6:20b:45f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Wed, 20 Apr 2022 08:50:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Wed, 20 Apr 2022 08:50:18 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Wed, 20 Apr 2022 08:50:18 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Wed, 20 Apr 2022 08:50:17 +0000 Received: from e129018.arm.com (10.57.95.6) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 20 Apr 2022 08:50:17 +0000 To: Subject: [PATCH] arm: Restrict support of vectors of boolean immediates (PR target/104662) Date: Wed, 20 Apr 2022 10:50:03 +0200 Message-ID: <20220420085003.55338-1-christophe.lyon@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: fec2402d-5790-41b8-6236-08da22aad26a X-MS-TrafficTypeDiagnostic: VI1PR08MB3150:EE_|AM5EUR03FT058:EE_|AM0PR08MB4593:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZfqUSqNPXIpRe2tNIOaQv105ak4Df7kFVgwmNDsd8gUELo8FY64z8ei/UhdhsuymiLr5l03JJj1+LadVH2sMGsy817Mjc2HByCdw1tf0MYjfcyCCg+QdhDyd2M+MVhKXCrf9HqBfM1qhdh44izoyohdyv1b//MGv+vhGiVCdb2CXPOqq1FCa2X38Tl6AC1RFqlLygbkkV9Kztl3N66GBhPqS+PDQ6l3/QFkZMGZZ4RX6UMnN4WEn5axp8aLydtmrR1m/+CpPQg700PfwAbM0DXTj1vhPtuZD4fkwtaq3cwkU/ARGE31sVstBdglA7G3xGibUlLM8gBJi7HMNTkVHnm7t53XjQvCnFRCYnw9oR9IhYkVlFhM9xMD0pOUrUVPCzZtTJTfevjttfKIrgPsvAXru2L590VWaloP/q4E8bKsrvs2zVVBNBEmd6dxNXCw9/uJ66yDDz6cQmXixQJq6TNXkHxhcW8EJJgOBf+BWm03Q985uJllvBxfbx3eT2U1QszgfxOl53bLZf8n7vgyBZZAYzP6LFwrXtHkHy2JqSlQsRhxclKVFaap4mhJz/mYzarWChnamFYmX2XWhSYiLNmTXNMXTVWMgrnoo4b3FZX3tESSsAHUYL5DyXltJrgxPN0LMnllQwJaf8hPxNEALKkkSDGVyiNmTBEML8WgQj4RnL9RMRd4nhX56SfKzxPxmSFCAnparSdrqNa4AwF9FRl1+pNIU2oa8zL4CYzi/PGjYKvz28vOo7eqnrGVWhmAuV8rGZyTk76dnbkWkbQRwEMbi535ThussfPb2p5cL54arN7ijYQ7PgZO3f9OFRdbe X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(2906002)(84970400001)(508600001)(70586007)(70206006)(44832011)(1076003)(86362001)(8676002)(4326008)(2616005)(6666004)(8936002)(5660300002)(26005)(186003)(47076005)(7696005)(40460700003)(336012)(82310400005)(426003)(6916009)(36756003)(316002)(36860700001)(81166007)(356005)(14773001)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3150 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0feef294-ad71-42e7-5b11-08da22aacbfb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EMzN2Mjs3VaFheNJUjq4gKAi6yWLndJQaW9mpJ1CwENZcJk6rrVZQZEcQv+2bjBlQRPkaG3sWufTQhKIDkM0e5/js3ZcGCId8332yiwEVCdL9jNEPsER49WDwObf1b8x8YyHRtrJRvU/UbCEMCx179SvtT5QrL2389NFh+3CiGtI1M1Tl2UPTsZQ3V+gWCe5M9374GlPOifdnPLMuRHgALCt1/a9j1AlxuGL4/fcgSPM3wjX9kVA+BZr7YEJQSmpgY4F4nFYaFnPMQUT3qLqQE7hxuVgY22ck72MEHcj69GoxFwS/tbxt7h2bDWGGYAWUwVxp/OGfNg6XcrOZoJ8dplv2G7bzsdAvHFEQnUozgHtJidvzrjyC4pdO7PfuiOSTyP1m7iRpjL8JfVDFfJuk0vaYmj1W46C4vw6mhrB4KfGAS+ZyObt2FswrgpqzZXzC+nNeoGM4ndLgIDRRyztKpwRwJ/AVQzphIYmNSBAg1KDvgMu4Q+2pbyOtHYG6sOl67fQTyWbOVymvNaI8Im7Ni8dXjkqS4CQ7pIAcanPKrXgXMGPNoEYqcjzLvGVH6DCgfz80/iC7VFAx2P9L0xdzK++wC4hvi4wC+WJZK0cDx6KkfRtSNh9BheGxVOweOL+ybFccXw++ITLEsojGnKkkX62Dxb14IQbmbFdm5xphMwuXVwlSlEo6bdsTPfKpQSZ+VMBOG3lpifY0kT1x10IS9qEL+d2eFGj08prbE4qmalb0+8mSb9xWQvbkEpL0OrJZrcQm73ciUnCwoTJ67QHcLbXwWozfLwEspjV25Hfo/8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(86362001)(2906002)(7696005)(8936002)(426003)(336012)(82310400005)(84970400001)(6666004)(36860700001)(81166007)(316002)(26005)(70586007)(40460700003)(44832011)(2616005)(1076003)(6916009)(70206006)(186003)(5660300002)(47076005)(36756003)(4326008)(8676002)(14773001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 08:50:29.5849 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fec2402d-5790-41b8-6236-08da22aad26a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4593 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This simple patch avoids the ICE described in the PR: internal compiler error: in simd_valid_immediate, at config/arm/arm.cc:12866 with an early exit from simd_valid_immediate if we are trying to handle a vector of booleans and MVE is not enabled. We still get an ICE when compiling the existing gcc.dg/rtl/arm/mve-vxbi.c without -march=armv8.1-m.main+mve: error: unrecognizable insn: (insn 7 5 8 2 (set (reg:V4BI 114) (const_vector:V4BI [ (const_int 1 [0x1]) (const_int 0 [0]) repeated x2 (const_int 1 [0x1]) ])) -1 (nil)) during RTL pass: ira but there's little we can do since the testcase explicitly creates vectors of booleans which do need MVE. That is the reason why I do not add a testcase. 2022-04-19 Christophe Lyon PR target/104662 * config/arm/arm.cc (simd_valid_immediate): Exit when input is a vector of booleans and MVE is not enabled. --- gcc/config/arm/arm.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc index 14e2fdfeafa..69a18c2f157 100644 --- a/gcc/config/arm/arm.cc +++ b/gcc/config/arm/arm.cc @@ -12849,6 +12849,9 @@ simd_valid_immediate (rtx op, machine_mode mode, int inverse, || n_elts * innersize != 16)) return -1; + if (!TARGET_HAVE_MVE && GET_MODE_CLASS (mode) == MODE_VECTOR_BOOL) + return -1; + /* Vectors of float constants. */ if (GET_MODE_CLASS (mode) == MODE_VECTOR_FLOAT) {