From patchwork Thu Apr 7 04:29:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Meissner X-Patchwork-Id: 52695 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E1223858C2D for ; Thu, 7 Apr 2022 04:30:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E1223858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1649305822; bh=8zBAzJnuBxkDhGt2sYU6rsU0le4EcumDd4Mjf50uSS0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=v9GFI6sFt41IfScWW3i7hgk/AID3vdUTyrC+qoSzha59kXBg1BT/cDq7tylDg3xBW 6xkt6VbOjk7L23De40eIDXPnu8cvJZVVJOCKw3Qi1aYoDQKkEvmcrKd9l39kNrQKUn TbytovCFjX1TmQASXywAfuuEqytWJ+sffBpPz+Nw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B15993858D37; Thu, 7 Apr 2022 04:29:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B15993858D37 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23739Uxv013726; Thu, 7 Apr 2022 04:29:50 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f95vxfh6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 04:29:49 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 2374SoOb016548; Thu, 7 Apr 2022 04:29:49 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f95vxfh6n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 04:29:49 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2374RAJ9015926; Thu, 7 Apr 2022 04:29:48 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma03dal.us.ibm.com with ESMTP id 3f6e4a4q9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 04:29:48 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2374Tl3M18743554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Apr 2022 04:29:47 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5B631AC066; Thu, 7 Apr 2022 04:29:47 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1970BAC05B; Thu, 7 Apr 2022 04:29:47 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.65.244.27]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 7 Apr 2022 04:29:47 +0000 (GMT) Date: Thu, 7 Apr 2022 00:29:45 -0400 To: gcc-patches@gcc.gnu.org, Michael Meissner , Segher Boessenkool , David Edelsohn , Peter Bergner , Will Schmidt , ebotcazou@gcc.gnu.org Subject: [PATCH] Disable float128 tests on VxWorks, PR target/104253. Message-ID: Mail-Followup-To: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Peter Bergner , Will Schmidt , ebotcazou@gcc.gnu.org MIME-Version: 1.0 Content-Disposition: inline X-TM-AS-GCONF: 00 X-Proofpoint-GUID: VkNScnvroteoSoz_1Fy8wqfFo3870VxL X-Proofpoint-ORIG-GUID: 29icBZLL8jv9Hc0ZLWi6BARaPmz6LXPK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-06_13,2022-04-06_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204070021 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_MANYTO, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Michael Meissner via Gcc-patches From: Michael Meissner Reply-To: Michael Meissner Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Disable float128 tests on VxWorks, PR target/104253. In PR target/104253, it was pointed out the that test case added as part of fixing the PR does not work on VxWorks because float128 is not supported on that system. I have modified the three tests for float128 so that they are manually excluded on VxWorks systems. In looking at the code, I also added checks in check_effective_target_ppc_ieee128_ok to disable the systems that will never support VSX instructions which are required for float128 support (eabi, eabispe, darwin). I have run the tests on my usual Linux systems (little endian power10, little endian power9, big endian power8), but I don't have access to a VxWorks system. Eric does this fix the failure for you? If it does fix the failure, can I apply the patch to the master branch and backport it to GCC 11 and GCC 10? Sorry about the breakage. 2022-04-07 Michael Meissner gcc/testsuite/ PR target/104253 * lib/target-supports.exp (check_ppc_float128_sw_available): Do not run float128 tests on VxWorks. (check_ppc_float128_hw_available): Likewise. (check_effective_target_ppc_ieee128_ok): Do not run float128 tests on VxWorks. Also disable systems that do not support VSX instructions. --- gcc/testsuite/lib/target-supports.exp | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index ff8edbd3e17..a4142eaee27 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -2318,10 +2318,12 @@ proc check_ppc_mma_hw_available { } { proc check_ppc_float128_sw_available { } { return [check_cached_effective_target ppc_float128_sw_available { # Some simulators are known to not support VSX/power8/power9 - # instructions. For now, disable on Darwin. + # instructions. For now, disable on Darwin. Disable on VxWorks as + # well. if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] - || [istarget *-*-darwin*]} { + || [istarget *-*-darwin*] + || [istarget *-*-vxworks]} { expr 0 } else { set options "-mfloat128 -mvsx" @@ -2344,10 +2346,11 @@ proc check_ppc_float128_sw_available { } { proc check_ppc_float128_hw_available { } { return [check_cached_effective_target ppc_float128_hw_available { # Some simulators are known to not support VSX/power8/power9 - # instructions. For now, disable on Darwin. + # instructions. For now, disable on Darwin and VxWorks. if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] - || [istarget *-*-darwin*]} { + || [istarget *-*-darwin*] + || [istarget *-*-vxworks]} { expr 0 } else { set options "-mfloat128 -mvsx -mfloat128-hardware -mpower9-vector" @@ -2370,8 +2373,12 @@ proc check_ppc_float128_hw_available { } { # See if the __ieee128 keyword is understood. proc check_effective_target_ppc_ieee128_ok { } { return [check_cached_effective_target ppc_ieee128_ok { - # disable on AIX. - if { [istarget *-*-aix*] } { + # disable on AIX, Darwin, VxWorks and targets that don't support VSX. + if { [istarget *-*-aix*] + || [istarget powerpc-*-eabi] + || [istarget powerpc*-*-eabispe] + || [istarget *-*-darwin*] + || [istarget *-*-vxworks]} { expr 0 } else { set options "-mfloat128"