From patchwork Mon Mar 28 13:34:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 52412 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C1833857C41 for ; Mon, 28 Mar 2022 13:40:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C1833857C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1648474811; bh=GDXvj+jBZ3mBcffEKDMfBQ3iCj/iUsLU/91fAyMGhDw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pS7/BsNLKl2y/OJSBwyssJYPn+YCHW5hFS5QIcbY+rHECskPTRPOGNqQGlVeAdrC4 X2sWH0vf758Fg/J/kkg8w0lzfCVhvvkNOrHHSIJDD+gpJh0+RMDYaq5tytbLEUuv5j uZLbVeTRDrlC3nLZPGW6YgSZemJvJ5rz0dGNVbUc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BFB8D385782D for ; Mon, 28 Mar 2022 13:34:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFB8D385782D Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-3lgZLThGNqW6hXrl3oU6Rg-1; Mon, 28 Mar 2022 09:34:26 -0400 X-MC-Unique: 3lgZLThGNqW6hXrl3oU6Rg-1 Received: by mail-qt1-f200.google.com with SMTP id h11-20020ac87d4b000000b002e1c9a3ae51so12238502qtb.0 for ; Mon, 28 Mar 2022 06:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=GDXvj+jBZ3mBcffEKDMfBQ3iCj/iUsLU/91fAyMGhDw=; b=BgMFsNWhnQ7MOxtvfUL4LSD4B8sJ2eAi0FYnIJ2pJn8jv4D1azII3M9ubn4OUI6of/ oHD1Wf6ady0/lqAgNVvwiiBRumRPHYKc+LwEVaNP2vps0osU9aqAH8qHK07LwqDjf3a2 W5qyaOzisjZVKUk9YaEmX/qoQVCpiFIFH/GK+pwnzISEhhVLiA17mmptfUATCvrFlbKj VExW2M4pOl7oRd/snDcvCx9ReG54b//z99ODlY0Q7g4vY0a4pr3XJlIHb+2gZFWeuU39 dXMHnC9plusp5Q9M88uAQ+LeudYaAPA8erjVOrQMry0KCcd2Z9pSa3xXH7BwJjm9PNyf UQIA== X-Gm-Message-State: AOAM533HH052AMaKlTmgIq2r/pJ4r5e6iVJk4KTUgqUN0SfMvCcOH/CQ wYvfRmHuRk2Nd9cKha/D6hboigt/pdE1wIJrCWIVGsksAdZKEhvXwh4w38dBB1NjwadLIl513Uv IMvS5JRLbMu9sKYIf2JUIfloNfTgAg/Rzi2w/F5GNBBr/24sJqRbHePHLkfXk6VnOgw== X-Received: by 2002:ac8:5f0d:0:b0:2e1:ee49:36c1 with SMTP id x13-20020ac85f0d000000b002e1ee4936c1mr21539542qta.589.1648474466034; Mon, 28 Mar 2022 06:34:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/pxNsDJ27fTXW3xjz+s974hXXE4CMufXT9SCZrIlE1Vf4h2KzqrxJ9ZY+JgugUlg0uan5CQ== X-Received: by 2002:ac8:5f0d:0:b0:2e1:ee49:36c1 with SMTP id x13-20020ac85f0d000000b002e1ee4936c1mr21539496qta.589.1648474465637; Mon, 28 Mar 2022 06:34:25 -0700 (PDT) Received: from barrymore.redhat.com (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id bs10-20020a05620a470a00b00680ae2f3decsm6449788qkb.8.2022.03.28.06.34.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 06:34:24 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [pushed] c++: visibility of local extern [PR103291] Date: Mon, 28 Mar 2022 09:34:22 -0400 Message-Id: <20220328133422.2586321-1-jason@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jason Merrill via Gcc-patches From: Jason Merrill Reply-To: Jason Merrill Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" When setting up the hidden namespace-scope decl for a local extern, we also need to set its visibility. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/103291 gcc/cp/ChangeLog: * name-lookup.cc (push_local_extern_decl_alias): Call determine_visibility. gcc/testsuite/ChangeLog: * g++.dg/ext/visibility/visibility-local-extern1.C: New test. --- gcc/cp/name-lookup.cc | 3 +++ .../g++.dg/ext/visibility/visibility-local-extern1.C | 10 ++++++++++ 2 files changed, 13 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C base-commit: bc86a86a4f2c057bc0e0be94dcbb8c128ae7f717 prerequisite-patch-id: 09e711b54e7911a4a04bd7808abc1b73ae4482ba prerequisite-patch-id: 566cf0772894d0c6a842b2e0ca62eb1d5ae8ad33 prerequisite-patch-id: b1def7e83e76c1652efb483cb2b67e472d15b720 prerequisite-patch-id: 12973b1310781ff6ce5c9792ea689f0673fc5251 prerequisite-patch-id: 8dcc4ecc29dbe7b290325412af70613171456714 prerequisite-patch-id: 0e11ad2f06a4b425182bca51bd5a85eedd3ce8cd prerequisite-patch-id: 1c17a86736dd239bc62ee4619599fc89f0cf5908 diff --git a/gcc/cp/name-lookup.cc b/gcc/cp/name-lookup.cc index 3c7b626350f..c833b84ca8a 100644 --- a/gcc/cp/name-lookup.cc +++ b/gcc/cp/name-lookup.cc @@ -3476,6 +3476,9 @@ push_local_extern_decl_alias (tree decl) && CP_DECL_THREAD_LOCAL_P (decl) && alias != error_mark_node) set_decl_tls_model (alias, DECL_TLS_MODEL (decl)); + + /* Adjust visibility. */ + determine_visibility (alias); } } diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C new file mode 100644 index 00000000000..40c20199d0c --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C @@ -0,0 +1,10 @@ +// PR c++/103291 +// { dg-additional-options -fpic } +// { dg-final { scan-assembler-not "@GOTPCREL" } } + +#pragma GCC visibility push(hidden) + +int hidden_fetch(void) { + extern const int hidden_global; + return hidden_global; +}