From patchwork Wed Mar 23 13:44:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 52253 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DBC0D386EC38 for ; Wed, 23 Mar 2022 13:44:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DBC0D386EC38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648043097; bh=8O4M+OjHdmlmJx+sQje5nzAT2+qd3H7K0DqSkIoSMCQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YSFQtTCYpkHOOwrEq4bv1OWc4KoaJxpMu3PTHcKdDoZ+CErL14pXkVdR6mEibCQ2I /arLlCw1jvDKJDzOjPnZlarxHkkWRXHCY07nQae6HobJDySWZWD9cxM2HjEuU3L5E1 BimXGO+lOANTp8oaM+0v2FF4eAV07O8VKt/4rAwY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id E9CB53858405 for ; Wed, 23 Mar 2022 13:44:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9CB53858405 Received: by mail-ot1-x336.google.com with SMTP id o20-20020a9d7194000000b005cb20cf4f1bso1089694otj.7 for ; Wed, 23 Mar 2022 06:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8O4M+OjHdmlmJx+sQje5nzAT2+qd3H7K0DqSkIoSMCQ=; b=7GAB43DQHi21+1REIBtdi1YdDPHkKeOIHiQjmqEzy9zp3h068DIAhw4nb0CKAp2bhG T2lMLOwhK7SRz1aMaUdhRUJz91+8Gli0he17heraXeKRTJbJh7uVNh7++shaBpKR2m/a ONgMB6LkKx5qjx2FFuACtJyPWxPzY56OE5t66cFXSX7DbdRe6pl9rtnjqHO2vnWoYKGu RBr7UIMZzpsOKsSukXaLLZgqdmu7HLWQ4h7C256u2A22Si8rhfmtjd/8Jf4uWrnz5UaW j6Y09YEAYdhrixLCtQjVZYsoCXgkVnpJOViIXK+Nh4uxPpvWLWcgDSJf1n1OiHs3N8hT dZ/Q== X-Gm-Message-State: AOAM533K1vxxvKojLvx8pYa4+onMMUMJzEUm2rOqNR3OsSKgSrU+2uLI 923fQOPId0Ky2cYzLZbCwNUDpRzXzjb2rA== X-Google-Smtp-Source: ABdhPJx9O2urT914JtfazA/EP+SesYl7XYqj3C+1rh+UyHB64/wBdPQOMxXq6exw68ee3s0yviKAEw== X-Received: by 2002:a9d:6f0a:0:b0:5b2:4473:107c with SMTP id n10-20020a9d6f0a000000b005b24473107cmr11939322otq.285.1648043074766; Wed, 23 Mar 2022 06:44:34 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:2d55:7794:d006:fba1:8b8f]) by smtp.gmail.com with ESMTPSA id 190-20020a4a0dc7000000b003244ae0bbd5sm40765oob.7.2022.03.23.06.44.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:44:34 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [COMMITTED] elf: Remove inline _dl_dprintf Date: Wed, 23 Mar 2022 10:44:30 -0300 Message-Id: <20220323134430.2579444-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It is not used on rtld and ldsodef interfaces are meant to be used solely on loader. It also removes the only usage of gcc extension __builtin_va_arg_pack. --- sysdeps/generic/ldsodefs.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h index 9878e7e87e..44750461a9 100644 --- a/sysdeps/generic/ldsodefs.h +++ b/sysdeps/generic/ldsodefs.h @@ -816,20 +816,9 @@ extern void _dl_debug_printf_c (const char *fmt, ...) /* Write a message on the specified descriptor FD. The parameters are interpreted as for a `printf' call. */ -#if IS_IN (rtld) || !defined (SHARED) extern void _dl_dprintf (int fd, const char *fmt, ...) __attribute__ ((__format__ (__printf__, 2, 3))) attribute_hidden; -#else -__attribute__ ((always_inline, __format__ (__printf__, 2, 3))) -static inline void -_dl_dprintf (int fd, const char *fmt, ...) -{ - /* Use local declaration to avoid includign . */ - extern int __dprintf(int fd, const char *format, ...) attribute_hidden; - __dprintf (fd, fmt, __builtin_va_arg_pack ()); -} -#endif /* Write LENGTH bytes at BUFFER to FD, like write. Returns the number of bytes written on success, or a negative error constant on