From patchwork Thu Mar 10 11:18:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 51840 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B850C3857C7D for ; Thu, 10 Mar 2022 11:18:52 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 18A0D3858404 for ; Thu, 10 Mar 2022 11:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18A0D3858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,170,1643702400"; d="scan'208,223";a="72815801" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 10 Mar 2022 03:18:36 -0800 IronPort-SDR: 2f1WtShZZ7cpIhxyBtWdl74YvYcksBOoY00gb3/3SMFt9rs7omKdIvayJ0qVRjcSEwDiOHSdrb AmQmfEA3vXF+f34X5Ezcj0MzI1a8S4j1/uj3vNa0readwjBQ3sHrxbL2h3QqXF3D7Qz5w3py13 CZR1DRlqFa9aKlOc6k6v00aAiteoSucPafZIVbEC+2Gm4S2UIwPfaIbeQwofdql5+mgtj7qXPE o8v1p+byXCgIbl6g6H7IB7A1xJi2f61WGqZgp8wM1s1nRz5fzaR08DVVKlLFxlDY+IiEwuaFgJ EeA= From: Thomas Schwinge To: Subject: Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774] In-Reply-To: <87tuc6m55y.fsf@euler.schwinge.homeip.net> References: <20180813172151.6bfcece3@squid.athome> <524d9017-e7f0-87a2-6a62-9b23abd65ac2@codesourcery.com> <94ac317d-5e4c-7738-4b22-b59d29dc114a@codesourcery.com> <20180815174637.7f7f9666@squid.athome> <1532490C-015A-4F89-8512-FD9751C7EEA4@gmail.com> <20180816164643.01e26476@squid.athome> <20181211150811.47a032cf@squid.athome> <20190603170245.4a62a0ad@squid.athome> <87fsolsaq4.fsf@euler.schwinge.homeip.net> <87tuc6m55y.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Thu, 10 Mar 2022 12:18:28 +0100 Message-ID: <87r17am4xn.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julian Brown , Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2022-03-10T12:13:29+0100, I wrote: > On 2022-02-14T16:56:35+0100, I wrote: >> [...] give rise to "[12 Regression] ICE in >> expand_gimple_stmt_1, at cfgexpand.c:3932 since r12-980-g29a2f51806c". > > Pushed to master branch commit 687091257820f4a6a005186437917270ecd27416 > "Add 'gfortran.dg/goacc-gomp/pr102330-{1,2,3}.f90' [PR102330]", see > attached: currently XFAILed with 'dg-ice'. Well, and as I should figure out, the very same problem/fix is what causes/cures recently-filed "OpenACC 'kernels' decomposition: internal compiler error: 'verify_gimple' failed, with 'loop' with explicit 'seq' or 'independent'"! Pushed to master branch commit 448741533a75862ebf51d8e73eb1dd1f6a47eec5 "Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774]", see attached: currently XFAILed with 'dg-ice'. Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From 448741533a75862ebf51d8e73eb1dd1f6a47eec5 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 3 Mar 2022 18:00:52 +0100 Subject: [PATCH] Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774] ..., currently XFAILed with 'dg-ice'. PR middle-end/104774 gcc/testsuite/ * c-c++-common/goacc/kernels-decompose-pr104774-1.c: New file. --- .../goacc/kernels-decompose-pr104774-1.c | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c new file mode 100644 index 00000000000..776f4d6befa --- /dev/null +++ b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c @@ -0,0 +1,41 @@ +/* { dg-additional-options "--param openacc-kernels=decompose" } */ + +/* { dg-additional-options "-fchecking" } + { dg-ice TODO } */ + +/* { dg-additional-options "-fopt-info-all-omp" } */ + +/* { dg-additional-options "--param=openacc-privatization=noisy" } + Prune a few: uninteresting, and potentially varying depending on GCC configuration (data types): + { dg-prune-output {note: variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} } */ + +int arr_0; + +void +foo (void) +{ +#pragma acc kernels /* { dg-line l_compute1 } */ + /* { dg-note {OpenACC 'kernels' decomposition: variable 'k' declared in block requested to be made addressable} {} { target *-*-* } l_compute1 } */ + /* { dg-note {variable 'k' made addressable} {} { target *-*-* } l_compute1 } */ + /* { dg-note {variable 'k' declared in block is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_compute1 } */ + /* { dg-note {variable 'arr_0\.0' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} {} { target *-*-* } l_compute1 } */ + { + int k; + + /* { dg-note {parallelized loop nest in OpenACC 'kernels' region} {} { target *-*-* } .+1 } */ +#pragma acc loop seq /* { dg-line l_loop_k1 } */ + /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k1 } */ + for (k = 0; k < 2; k++) + arr_0 = k; + + /* { dg-note {parallelized loop nest in OpenACC 'kernels' region} {} { target *-*-* } .+1 } */ +#pragma acc loop independent reduction(+: arr_0) /* { dg-line l_loop_k2 } */ + /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k2 } */ + for (k = 0; k < 2; k++) + arr_0 += k; + } +} +/* { dg-bogus {error: non-register as LHS of binary operation} {} { xfail *-*-* } .-1 } + { dg-bogus {error: invalid RHS for gimple memory store: 'var_decl'} {} { xfail *-*-* } .-2 } + { dg-allow-blank-lines-in-output 1 } + { dg-excess-errors ICE } */ -- 2.34.1