From patchwork Wed Mar 9 10:24:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 51813 X-Patchwork-Delegate: azanella@linux.vnet.ibm.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 023143858416 for ; Wed, 9 Mar 2022 10:24:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 023143858416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1646821486; bh=ya9ii81APoHenJPGh8tIMeqACh+re0cBxXnefM0SJjU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=bw+dEvj5RTKwB1puwZrqF+gUlDQWSZLZ/xFDlp+6Xx8h2lobcYYPfKh1MxyDUFHWq 50DqPTqsFeUAazENVIPC4QASgrxtkB4v6LL0zcifbfLd/INTZvkDgt3SdQ6ZKrcRrR BwB93MqlsT3RnolQUg4E6up1L1mnFdUva7qtOnao= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AC3B03858D28 for ; Wed, 9 Mar 2022 10:24:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC3B03858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-yuBmlwujNyWjSyXVB4xHWg-1; Wed, 09 Mar 2022 05:24:20 -0500 X-MC-Unique: yuBmlwujNyWjSyXVB4xHWg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 376781854E2A; Wed, 9 Mar 2022 10:24:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C7C982E5C; Wed, 9 Mar 2022 10:24:17 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing Date: Wed, 09 Mar 2022 11:24:16 +0100 Message-ID: <877d9377an.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The elf/dso-sort-tests-src subdirectory is not changed by this commit, so it seems that the cut-and-paste error was not material. This was reported by some downstream static analysis tool. Reviewed-by: Adhemerval Zanella --- scripts/dso-ordering-test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py index 0b526aff45..2dd6bfda18 100644 --- a/scripts/dso-ordering-test.py +++ b/scripts/dso-ordering-test.py @@ -551,17 +551,17 @@ def process_testcase(t): if obj in t.deps: deps = t.deps[obj] if '*' in deps: - t.deps[obj].remove('*') + deps.remove('*') t.add_deps([obj], non_dep_tgt_objs) if obj in t.callrefs: deps = t.callrefs[obj] if '*' in deps: - t.deps[obj].remove('*') + deps.remove('*') t.add_callrefs([obj], non_dep_tgt_objs) if "#" in t.deps: deps = t.deps["#"] if '*' in deps: - t.deps["#"].remove('*') + deps.remove('*') t.add_deps(["#"], non_dep_tgt_objs) # If no main program was specified in dependency description, make a