From patchwork Fri Jan 28 17:54:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 50548 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F3713947C38 for ; Fri, 28 Jan 2022 18:06:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F3713947C38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1643393217; bh=p/DLWuRu/36CzIkCSgj4BvkK2iMAOUB6hBdpFM3Oerc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=xBl5awleTQm1/kD+EswjFJszAbCGE0orbxuhrBOT8PxUiFTU918AzWZJugE+k6yuQ XbNRChqrFNxGEXjWHIoGbFXwGchNlINKVxpnOtPkK2o+79RsUjrYZUBhq2Q9iUfwY6 AwaSgIiznEQEx/CMA5JsXOWXFViynIivIiN4krjU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 74000386EC3C for ; Fri, 28 Jan 2022 17:54:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74000386EC3C Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-Hj1zWioCPxi13z5fYP5CDA-1; Fri, 28 Jan 2022 12:54:05 -0500 X-MC-Unique: Hj1zWioCPxi13z5fYP5CDA-1 Received: by mail-qk1-f198.google.com with SMTP id q5-20020a05620a0d8500b004738c1b48beso5375021qkl.7 for ; Fri, 28 Jan 2022 09:54:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p/DLWuRu/36CzIkCSgj4BvkK2iMAOUB6hBdpFM3Oerc=; b=8Mrpre0/5OVta0dk5hWngOtb/I6PQYqb3xqRqrRNJCudZ6+XzYoYkLLlp813kkzXSU 049KOya4oKEbaoOzfWehhanxAFD7YI0CUdLCJ+6qv7BDSD5EbXG07PCMU2NBUG1/fVzE 3lWJvpVUDGV6HLKEKEj1RgwdbBxoDvSANOl6jwCbFRRI0St0jc3VqvEjv6U9CtkowmJp X/uEJtOWtGoWVC3Es2hi8b4f+GV0ucwapInfq38rI232xOmhElwEoyZSjg5yRIkon4Pb +Kd5re9IB2RjG5+TEwODkjeCmq5jM5AVut+Z2IaSxGdVA8E/IbTVtbDjZktUt/e9tAuO Fmaw== X-Gm-Message-State: AOAM530wGgCiJRwANlPtbipis7YvNPQ9Nw4pXjAJV4ew8rn9CovaevxG rczmiHai2OlXAVHXA/88KtKi6kg8r3emAnp4aNRdMXKBrpX+5IExnbBZmlVM+GwhUb4/nc9ooPl kghXu+1zqa/J3Cg8s0AJXl1iTwKf8xsI9/yR6PIThn2dEwRSrCjGvSMl52oauxszOIYw= X-Received: by 2002:a05:620a:45ac:: with SMTP id bp44mr6422485qkb.451.1643392444734; Fri, 28 Jan 2022 09:54:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXDyyoJ1HM1uQYPJV4ZSbbserDjbbkXI4bmjYDhX2eQJiR3JHbPkoktCZEoZjMswj0mSayVA== X-Received: by 2002:a05:620a:45ac:: with SMTP id bp44mr6422471qkb.451.1643392444452; Fri, 28 Jan 2022 09:54:04 -0800 (PST) Received: from localhost.localdomain (ool-18e40894.dyn.optonline.net. [24.228.8.148]) by smtp.gmail.com with ESMTPSA id n18sm3748475qkp.2.2022.01.28.09.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 09:54:04 -0800 (PST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] c++: bogus warning with value init of const pmf [PR92752] Date: Fri, 28 Jan 2022 12:54:01 -0500 Message-Id: <20220128175401.1367284-1-ppalka@redhat.com> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Patrick Palka via Gcc-patches From: Patrick Palka Reply-To: Patrick Palka Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Here we're emitting a -Wignored-qualifiers warning for an intermediate compiler-generated cast of 0 to 'method-type* const' as part of value initialization of a const pmf. This patch suppresses the warning by stripping cv-quals from this pointer type before performing the cast. Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? PR c++/92752 gcc/cp/ChangeLog: * typeck.cc (build_ptrmemfunc): Strip cv-quals from the pointer type after building the pmf type. gcc/testsuite/ChangeLog: * g++.dg/warn/Wignored-qualifiers2.C: New test. --- gcc/cp/typeck.cc | 1 + .../g++.dg/warn/Wignored-qualifiers2.C | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 gcc/testsuite/g++.dg/warn/Wignored-qualifiers2.C diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc index 11c9d8aff3e..0ce1cd3b6c8 100644 --- a/gcc/cp/typeck.cc +++ b/gcc/cp/typeck.cc @@ -9593,6 +9593,7 @@ build_ptrmemfunc (tree type, tree pfn, int force, bool c_cast_p, /* Handle null pointer to member function conversions. */ if (null_ptr_cst_p (pfn)) { + type = cv_unqualified (type); pfn = cp_build_c_cast (input_location, type, pfn, complain); return build_ptrmemfunc1 (to_type, integer_zero_node, diff --git a/gcc/testsuite/g++.dg/warn/Wignored-qualifiers2.C b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers2.C new file mode 100644 index 00000000000..c4c37545c02 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers2.C @@ -0,0 +1,17 @@ +// PR c++/92752 +// { dg-do compile } +// { dg-additional-options "-Wignored-qualifiers" } + +struct X; + +template +struct Wrap { + T data; + Wrap() : data() {} +}; + +typedef int (X::*type)(); +Wrap x; +#if __cpp_initializer_lists +const type t{}; +#endif