From patchwork Thu Jul 16 18:32:57 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: dodji at seketeli dot org
 <sourceware-bugzilla@sourceware.org>
X-Patchwork-Id: 40118
Return-Path: <libabigail-bounces@sourceware.org>
X-Original-To: patchwork@sourceware.org
Delivered-To: patchwork@sourceware.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 2C4C338930E7;
	Thu, 16 Jul 2020 18:32:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C4C338930E7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1594924378;
	bh=/h5xcU/A/xdp6SeVli2CCFQcOUQy4SozGwmqvJJNp7c=;
	h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe:
	 List-Archive:List-Help:List-Subscribe:From:Reply-To:From;
	b=RcqkUR9d8wDq7r16zPVN8OLnluhkLoHzKaV3KLHyhdXZa03l0i4AFvDmaHWaUkwhz
	 6p5MArkGqLdlnB/uchKGJNt1HqBLbct09Fgxo8APlsIS2pTEX3E7UB5RG8mxGziFxv
	 v0UkYi91qn7AebfRVHHIDNrnje39/StSPhUFHCHc=
X-Original-To: libabigail@sourceware.org
Delivered-To: libabigail@sourceware.org
Received: by sourceware.org (Postfix, from userid 48)
 id AD45338930D7; Thu, 16 Jul 2020 18:32:57 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD45338930D7
To: libabigail@sourceware.org
Subject: [Bug default/26135] Wrong linkage name causes anonymous classes
 miscomparison
Date: Thu, 16 Jul 2020 18:32:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: libabigail
X-Bugzilla-Component: default
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gprocida+abigail at google dot com
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dodji at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26135-9487-3Wx4TktluI@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26135-9487@http.sourceware.org/bugzilla/>
References: <bug-26135-9487@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-Patchwork-Original-From: gprocida+abigail at google dot com via Libabigail
 <libabigail@sourceware.org>
From: dodji at seketeli dot org <sourceware-bugzilla@sourceware.org>
Reply-To: gprocida+abigail at google dot com
 <sourceware-bugzilla@sourceware.org>
Errors-To: libabigail-bounces@sourceware.org
Sender: "Libabigail" <libabigail-bounces@sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=26135

--- Comment #5 from Giuliano Procida <gprocida+abigail at google dot com> ---
This is the patch I was working on that caused me to take a closer look.


This was an attempt to reduce the gap in behaviour between early and late type
canonicalisation by the DWARF reader.

--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -3496,7 +3496,8 @@ public:
        int tag = dwarf_tag(const_cast<Dwarf_Die*>(die));
        if ((tag == DW_TAG_structure_type
             || tag == DW_TAG_class_type
-            || tag == DW_TAG_union_type)
+            || tag == DW_TAG_union_type
+            || tag == DW_TAG_enumeration_type)
            && die_is_anonymous(die))
          {
            location l = die_location(*this, die);