From patchwork Tue Sep 1 12:55:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 142630 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AAE94BA2E31 for ; Tue, 1 Sep 2026 12:56:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AAE94BA2E31 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fMHW7lXR X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id DFC2A4BA23E8 for ; Tue, 1 Sep 2026 12:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFC2A4BA23E8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DFC2A4BA23E8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788267368; cv=none; b=gUVzYye7oxYazr4wZuxuJKmLbHhrpwAYxmQkfFh/IkKt3nkAcBtIrE2sk3/4o9BtOE11VWVwvAMckK5zgF4FqbFs9JxLE7CglBDhV6NeGOTQMRbsSqED/fc7umv20Qz6QmXLP1tfbrthqe33RwnWjPVpn5XFCKxFyEsk/wOIuPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788267368; c=relaxed/simple; bh=gA4yf61MIgmzhSDds6/9WLau4u1pHaU36qcZ0GkE3uM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=MJJdwXNiecv8NsypHdLEJumWsUxoW0DMYf4r6p05Iy2y+c8+ZdkG1DpzYdXv8zVuxhqZoLrWiIwj4xD0OzSh/EX3jHM5mFGy9sIQWCNMiEch5PSBv2Dp4QkMT1BRam2rrLAhfRsGMNJpSe55IugBpINQOTc77Aox/Y93hX8gVSI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fMHW7lXR DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DFC2A4BA23E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788267367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=XXSwZ9sC/JJtuzbsv17ovnwn1DUoq86kNuvR2T5Dz3c=; b=fMHW7lXRgU1JOp66yT0VdUgsH4geJxmznJzbed4VQW41ysZ4N0a+mtx9Y22SJ12sahys6N 3yop8l/wsGL4TOSW6a8egrqcXUjpnr855I9t2kSxlyWQv/oal1C60HgJYr/YUlofuAe8GP qMDKxugseR8B67NESLPCqD1+mo4etRM= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-9_ZTiiXjPpmhPv7yo9aNIw-1; Tue, 01 Sept 2026 08:55:56 -0400 X-MC-Unique: 9_ZTiiXjPpmhPv7yo9aNIw-1 X-Mimecast-MFC-AGG-ID: 9_ZTiiXjPpmhPv7yo9aNIw_1788267355 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-788e076423aso754389137.3 for ; Tue, 01 Sep 2026 05:55:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788267355; x=1788872155; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WvHXOPtSGgZXU9crPaxf5IbNw91+ew3O+mBEeIXHwWI=; b=DKD2Ji4A5gjGQimZbKaBcep0Leo7u6Vm5+J4x5Y1bu8MEq2ND/YDX8z9mJhJQyqDwG ZuPJkNtmVnOOEdGj+Bp3BlnnPbnvIKTgzo1PbereO+tSbtSiCwYR5DsIE7mAsq1Nkk6d PctQUAucvuBITAi4STrZ1VsLWcb3Gj39CkD1Q0OU2zOq8NzdsSuX/tIOWE3Trwka5XEs 0154LkgFc4G3vQ/dmneEs0MwtLxZju73SX8oGTlH0WWSAVID3CYT2RkVoAytvs8h5xAA znMyRYpRLKNug/rOUFl3+qkyB1/KH9yPlQrL68TB3p8x29HDHPZvpJDUSLPqLsGp/Iy5 /qYA== X-Gm-Message-State: AFuF++kTUCNFT/LEtgPW6Ou4CpptnPg5jfI8OLSy609iRSZk/TTZWO93 bPB/jqcvWKgSQL2ZNCgYgitcUNBeAR3HSPtBCVew69N+JvpqyS9PHcICzkbLSVO1U+NLSnwMyt3 d6TMbn/1+eQA04zNA98xKlQCKq89rRrYjHvGmKDhqrdW1O75LzHt1CiyLcwHxruQpMLNDSCUSW8 BPk0VKvQqBXhvOZwLDbKkGpv/VRrq5dAi832+HTuBfjFmrvg== X-Gm-Gg: AR+sD1222P8OtLGzwQ30KaJObVn6qmsfy8tGoUeW9ytMUJd+ySN2VisJ/NJhXP5ReeL typ9YoT6StWqbWSheOFGEHbLvet7whXJt+3V2eFH8HH7bgAPN9J48Y/xYj9A3GyX5hxHkOPaYkV KZQZxoSLlKT9QPF05GY4DvZOdImILXMeTCdkhlRG92clx3VtFqfkzwsiEvkiyW9PO9LDVTxgi2c xHA+8WSqMKnVC+jJUM5ZwDXOUBJ6PLoqhpRQVGzMuiQO7/0MgVSLJecvOfIU6pA6mj2UDktsmd4 A8lTNVwm05NkgrwV+GfJ3raJ9q0uOYzctdek5rxFTV33iU7zqbQgw7mvMQzcqMUYVENEt+39sNo hX7bcyn455VJ4o998uloJRsHN6aSl9Va2gKt8oY2VYaIETEknSSyXkRIP X-Received: by 2002:a05:6102:4415:b0:784:b6e7:cee0 with SMTP id ada2fe7eead31-789fc1883c8mr2812499137.3.1788267355501; Tue, 01 Sep 2026 05:55:55 -0700 (PDT) X-Received: by 2002:a05:6102:4415:b0:784:b6e7:cee0 with SMTP id ada2fe7eead31-789fc1883c8mr2812463137.3.1788267354866; Tue, 01 Sep 2026 05:55:54 -0700 (PDT) Received: from [192.168.50.116] (pool-99-240-151-212.cpe.net.cable.rogers.com. [99.240.151.212]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-98056e2433fsm2002882241.7.2026.09.01.05.55.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 05:55:54 -0700 (PDT) Message-ID: <5211af84-32a4-4ed8-8ab4-c9a441424f02@redhat.com> Date: Tue, 1 Sep 2026 08:55:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: gcc-patches From: Andrew MacLeod Subject: [COMMITTED] PR tree-optimization/127154 - Dont access unused fields in set_prange. X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: asPS7dUnQnmzeaeCpWqZ-R37cqyPMHcH-1PEbDnUGcQ_1788267355 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_PBL, SPF_HELO_PASS, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org There is no simple way to test this, but valgrind was unhappy about the sequence of instructions in prange_storage::set_prange ().   UNDEFINED, VARYING and ZERO modes don't really use the m_bitmask nor m_points_to field.  Although the query for the current bitmask should be harmless, this patch moves it down to the section where we know we are using it, and sets the defaults to FALSE for the other 3 cases. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew From da6ac91f21c3472c6067c8e7d65179de7770d16c Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Mon, 31 Aug 2026 10:00:27 -0400 Subject: [PATCH 1/2] Dont access unused fields in set_prange. PR tree-optimization/127154 * value-range-storage.cc (prange_storage::set_prange) Access bitmask and points to fields only for kinds those that use them --- gcc/value-range-storage.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/value-range-storage.cc b/gcc/value-range-storage.cc index 827a5260a19..14fa6e29a9f 100644 --- a/gcc/value-range-storage.cc +++ b/gcc/value-range-storage.cc @@ -710,9 +710,9 @@ prange_storage::set_prange (const prange &r) { unsigned num_words; m_kind = prange_format (r, num_words); - m_has_bitmask = !r.get_bitmask ().unknown_p (); + m_has_bitmask = false; + m_points_to_p = false; m_pt = r.m_pt; - m_points_to_p = r.m_points_to_p; unsigned index = 0; @@ -733,6 +733,9 @@ prange_storage::set_prange (const prange &r) gcc_unreachable (); } + m_has_bitmask = !r.get_bitmask ().unknown_p (); + m_points_to_p = r.m_points_to_p; + if (m_has_bitmask) { irange_bitmask bm = r.m_bitmask; -- 2.55.0