From patchwork Tue Sep 1 12:49:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 142627 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE6634BA7980 for ; Tue, 1 Sep 2026 12:50:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE6634BA7980 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=EMzXQWZF X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [185.254.79.34]) by sourceware.org (Postfix) with ESMTPS id 7023D4BA2E1F for ; Tue, 1 Sep 2026 12:49:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7023D4BA2E1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7023D4BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=185.254.79.34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266982; cv=none; b=xbWjOvE28+5uNM8gexWafCzw1Afbpwq7nH+l4/ZjFRV30QqVxAiWGxbmJtekM/+Dg0Eig9+HoK+tAcAhziYBlmGHzMwu5ZTUh6WfQ+9+4kg+GrnU2uath1/nLUGgng4k7PUfwPGuILtbwJzcTAzxtPryjnRYIEU9lS4nYMulB1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266982; c=relaxed/simple; bh=kiUy1UrNbxwIwDvvF5MHRp5gm93qK/k1AqKipLwetRI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dt/P/snB8dd9zageWD09hslLd7qPlTC3h20+ZtSjATDkxzKZz+3N4IervFXXl2ILzJXf9JafJeq1A2Mir2QpXQnDgyJWmDjFer4jSHgWCQ4kT/oP1cGQfIKeUK4xIVT9IeAZMQJbuUo3sFFS3VZLSQt35nFponIc5SqIP0+dAqc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=EMzXQWZF DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7023D4BA2E1F Received: from kolabnow.com (unknown [10.17.5.252]) by mx.kolabnow.com (Postfix) with ESMTPS id 790F330EC245 for ; Tue, 1 Sep 2026 14:49:41 +0200 (CEST) Authentication-Results: kolabnow.com (amavis); dkim=pass reason="pass (just generated, assumed good)" header.d=lambda.is DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lambda.is; h= content-transfer-encoding:mime-version:message-id:date:date :subject:subject:from:from; s=dkim2; t=1788266981; x=1789130982; bh=kiUy1UrNbxwIwDvvF5MHRp5gm93qK/k1AqKipLwetRI=; b=EMzXQWZFQE/K 2C5xNHAKGKYlDugJ15Bh2RJuMHoF5f24pnd3KD0hG1/2qZ96cQoP4XGq8zuHzxhG VGiNnJ4vRNINVHDaKcUiuEDVwIc3g9ZmH1x5XWdiVToCXytE+tcqYYfxwu3l+Cja CcBOcDzJVt+FBTFC1WI4qkHStu5WFRLFWzZKrZSH0va1LbfVCXDsf7CtjKgt9lN3 IWy1U4G0/wNjpvB7X5w9CB72bTYi1XKb7yLyaXBoDONbOYKEN2APFql5yRUYIZ7h QRi4018zyROru0yY+/zrNrqEe1VZQ04CCewL292z5fmIommPAwgKbPFWR1uZp09y bvMB6srjEw== From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PUSHED 1/3] Check past-the-end before dereferencing iterator Date: Tue, 1 Sep 2026 14:49:27 +0200 Message-ID: <20260901124929.514896-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Guard the dereference in the case where the current cursor in the needle isn't a tombstone in case we're at the end of the haystack. Example pair: NEEDLE: 6 x x 4 6 HAYSTACK: 4 6 x x 4 We find the subsequence 6 4, but the needle is not yet at end (missing 6) while the haystack is moved past the end: NEEDLE: 6 x x 4 6 ^ HAYSTACK: 4 6 x x 4 ^ If the haystack (super) is exhausted before the needle (sub) we know it isn't a proper subsequence, so this is the correct behaviour. This example was in the testsuite and caught by ASAN. PR gcov-profile/127038 gcc/ChangeLog: * gcov.cc (tombstone_subsequence_p): Guard iterator dereference. --- gcc/gcov.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gcov.cc b/gcc/gcov.cc index 87deeadcc75..0ad48eb1b54 100644 --- a/gcc/gcov.cc +++ b/gcc/gcov.cc @@ -1015,7 +1015,7 @@ tombstone_subsequence_p (const vector& sub, if (yitr == yend) return false; } - else if (*yitr != *xitr) + else if (yitr == yend || *yitr != *xitr) return false; yitr = find_if_not (yitr, yend, tombstone_p); From patchwork Tue Sep 1 12:49:28 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 142628 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75C564BA900F for ; Tue, 1 Sep 2026 12:51:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75C564BA900F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=qqWnG7Yf X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [185.254.79.34]) by sourceware.org (Postfix) with ESMTPS id 43B9D4BA2E1F for ; Tue, 1 Sep 2026 12:49:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43B9D4BA2E1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43B9D4BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=185.254.79.34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266985; cv=none; b=nVtIFpN59qHoHvKuLrVvXqVgVi3pheo9HCink8Of15o9JXUHsYhTMiBWJzcDY96f0qsG+dThMM/w8J2UQ4QaiMALwVQSHKvVlQjv0LjgF1twk6k2FkIRIVi6Q9ndSQRRc8ow6CyjmC1FfFcItp4oH/OWebyKxRrF1gVvORoZA2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266985; c=relaxed/simple; bh=AlzYK0CXyht/AAGbq8sNV6ODQDbC4FI3/OFWoDgh5SE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Hrrmzdllugc+riC0jZMAKGs1uYfMNk6kMYnXEl5ouzP0N7+FB70iJwZDRy0oSQCA5G/RkacdFlpUJ6Ug+29GSuGAWBgW0OFiwWoZJPc66IWNGLZdA9Q9D59ApmDpwHwNjDEUqimxkSO/Qvu1nBeC9cot5Todtm4XoozQq+48Gbs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=qqWnG7Yf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43B9D4BA2E1F Received: from kolabnow.com (unknown [10.17.5.252]) by mx.kolabnow.com (Postfix) with ESMTPS id 51A1E30EC245 for ; Tue, 1 Sep 2026 14:49:44 +0200 (CEST) Authentication-Results: kolabnow.com (amavis); dkim=pass reason="pass (just generated, assumed good)" header.d=lambda.is DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lambda.is; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from; s=dkim2; t= 1788266984; x=1789130985; bh=AlzYK0CXyht/AAGbq8sNV6ODQDbC4FI3/OF WoDgh5SE=; b=qqWnG7Yf79Rg+qp844kVV+h003s05zJ41W64wKcukJyQFmIykdu pjFQC+0Qa2wbNeeHRtxUEjzJWRBEgYTvktKQB2Cnu3UG2wK+FMbSICIfVdMvpuHu il1hsFTDowTYrxOZMxGVv2XNwmlxOtkUDWEXI+xYchbp0Xq+Sg+nhWXNm9iPZ6gp IllFuP9ueLU8XuyKtEeBbvwQfiNZlnZnHSn3f5judOIdjxyukbCORXsyHs14D5FO F43dytZ18OlxCT2Dhp6Wu57cWK7yTZ7nXjlOMwQ15fpSXbG44b1VcRdDnBY6DAPF 93Garj3K8RmrBbYiWuyA+wu09sUZxo+3Y+Q== From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PUSHED 2/3] Remove TODO comment Date: Tue, 1 Sep 2026 14:49:28 +0200 Message-ID: <20260901124929.514896-2-j@lambda.is> In-Reply-To: <20260901124929.514896-1-j@lambda.is> References: <20260901124929.514896-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org The comment shouldn't have been checked in in the first place, sorry. gcc/ChangeLog: * gcov.cc (find_prime_paths): Remove comment. --- gcc/gcov.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/gcov.cc b/gcc/gcov.cc index 0ad48eb1b54..06047a60460 100644 --- a/gcc/gcov.cc +++ b/gcc/gcov.cc @@ -3215,9 +3215,6 @@ find_prime_paths (function_info *fn) } vec> prime_paths (struct graph*, size_t); - /* TODO: Pass extra information in the PATH_TAG section. In case - that is empty this might still need to be tunable should the - coverage be requested without instrumentation. */ vec> paths = prime_paths (cfg, (size_t)-1); fn->paths.paths.reserve (paths.length ()); for (vec &path : paths) From patchwork Tue Sep 1 12:49:29 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 142625 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D57BC4BA540B for ; Tue, 1 Sep 2026 12:50:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D57BC4BA540B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=KBLYwDKT X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [185.254.79.35]) by sourceware.org (Postfix) with ESMTPS id 7F4A84BA799B for ; Tue, 1 Sep 2026 12:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F4A84BA799B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F4A84BA799B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=185.254.79.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266988; cv=none; b=Y7pwB2qtstiHCxnP/fZIRCgaol4dvo9hlqXC1FG7rvtlyIHZv84wErv6HtGQS0ULBqVmo5Nd/EaZt0BbOiwZTm1Bhw+OxMquEYDsrNgVZ9PkLv7L4/sTz2BfQFUgCoPM0+8b5rwOHpWxNnBLCYo9s960Ie+zT8iRSsBeFHMushM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788266988; c=relaxed/simple; bh=RlFAsHUaeRYJbvww/5CHNfHOgxn+AF9hPVlaqSMytj8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YoWyNA1r5/icuh+sUzIDpX6ekDYSeVGEFInhBRsVTlWg+TKABnxg29GEGUJmADQIMGHppEOabrhX3m2W3gwzrqvBYgrLBslQjDP+cx7ay412Rw9L2DBnyGCs3DcsnZwlL1xbTVgyuGa3gd7V5xdSMq3+sOJhLwSEocCQBMQaMfM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=lambda.is header.i=@lambda.is header.a=rsa-sha256 header.s=dkim2 header.b=KBLYwDKT DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F4A84BA799B Received: from kolabnow.com (unknown [10.17.5.252]) by mx.kolabnow.com (Postfix) with ESMTPS id 719EBE966B for ; Tue, 1 Sep 2026 14:49:47 +0200 (CEST) Authentication-Results: kolabnow.com (amavis); dkim=pass reason="pass (just generated, assumed good)" header.d=lambda.is DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lambda.is; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from; s=dkim2; t= 1788266987; x=1789130988; bh=RlFAsHUaeRYJbvww/5CHNfHOgxn+AF9hPVl aqSMytj8=; b=KBLYwDKTPUiT+fGls0bo0g3wcBTZoONSET45gozma6fD85aVmqH n9R+Wsr/ZAa6Qs1r+ZZUosedLC09Gu4PdlTvC36uaFL8f+ewBBFo5KJMODwvGixg F1Qf+oU/4hDjsXt7FJP7UbCdh9fW7+wrz1mhUoH6+5Ci8rfB6lLnA2Vd735J/LAb 6aK6ULoqq/GICnfFoqXdJkTU9K161qqBu6/IK/Ocr4BAFBVdUo/4qlwX02Fjim0J W57SaZyqjdHPhJlaM7uYfQivi38FpT187i3djjKBqxpMbmDWUuPfCp3rRCEn3H7x Jc1db6kIxeX9hTpunATcZtrzTPZsogWvf8Q== From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PUSHED 3/3] Formatting fix Date: Tue, 1 Sep 2026 14:49:29 +0200 Message-ID: <20260901124929.514896-3-j@lambda.is> In-Reply-To: <20260901124929.514896-1-j@lambda.is> References: <20260901124929.514896-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SH_BODYURI_REVERSE_CSS, SPF_HELO_PASS, SPF_PASS, TXREP, URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org gcc/ChangeLog: * profile.cc (coverage_instrumentation_p): Put return type on separate line. --- gcc/profile.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/profile.cc b/gcc/profile.cc index 5ae64d4043f..52704e93866 100644 --- a/gcc/profile.cc +++ b/gcc/profile.cc @@ -2071,7 +2071,8 @@ end_branch_prob (void) /* Return true if any cfg coverage/profiling is enabled; -fprofile-arcs -fcondition-coverage -fpath-coverage. */ -bool coverage_instrumentation_p () +bool +coverage_instrumentation_p () { return profile_arc_flag || condition_coverage_flag || path_coverage_flag; }