From patchwork Thu Jan 13 14:12:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 49967 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE74E3951C0D for ; Thu, 13 Jan 2022 14:13:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE74E3951C0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1642083189; bh=ZU1xtQQewG3wqSp/B7XHTm2l71/UzPhY+JUxY4mPGlU=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=m2mawngYVycMssxezOOQIugkQ/zDb81rHKyp4YZspr/el435ebNkQSxe4J8BYCeaK tDT4VUDgvB9VAlgkEps6YyxMkqFXynXO/hrojDyJPZYINPh8AnDxEVJQowWiKXIZyo JiXYTE6UQ3BLWpHZe9pM72zacI1CXYz5f0kd/008= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 8B7BF3951C02 for ; Thu, 13 Jan 2022 14:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B7BF3951C02 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6CF6721129; Thu, 13 Jan 2022 14:12:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 542861330C; Thu, 13 Jan 2022 14:12:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lMpNEzMz4GEjcwAAMHmgww (envelope-from ); Thu, 13 Jan 2022 14:12:03 +0000 Date: Thu, 13 Jan 2022 15:12:03 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] c/104002 - shufflevector variable indexing Message-ID: <99p4058-7255-5195-o3nq-s5555p6rq3o@fhfr.qr> MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Cc: jakub@redhat.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Variable indexing of a __builtin_shufflevector result is broken because we fail to properly mark the TARGET_EXPR decl as addressable. Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? Thanks, Richard. 2022-01-13 Richard Biener PR c/104002 gcc/c-family/ * c-common.c (c_common_mark_addressable_vec): Handle TARGET_EXPR. gcc/testsuite/ * c-c++-common/builtin-shufflevector-3.c: Move ... * c-c++-common/torture/builtin-shufflevector-3.c: ... here. --- gcc/c-family/c-common.c | 5 ++++- .../c-c++-common/{ => torture}/builtin-shufflevector-3.c | 0 2 files changed, 4 insertions(+), 1 deletion(-) rename gcc/testsuite/c-c++-common/{ => torture}/builtin-shufflevector-3.c (100%) diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index 4a6a4edb763..a34f32f51a4 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -6989,12 +6989,15 @@ c_common_mark_addressable_vec (tree t) } if (!VAR_P (t) && TREE_CODE (t) != PARM_DECL - && TREE_CODE (t) != COMPOUND_LITERAL_EXPR) + && TREE_CODE (t) != COMPOUND_LITERAL_EXPR + && TREE_CODE (t) != TARGET_EXPR) return; if (!VAR_P (t) || !DECL_HARD_REGISTER (t)) TREE_ADDRESSABLE (t) = 1; if (TREE_CODE (t) == COMPOUND_LITERAL_EXPR) TREE_ADDRESSABLE (COMPOUND_LITERAL_EXPR_DECL (t)) = 1; + else if (TREE_CODE (t) == TARGET_EXPR) + TREE_ADDRESSABLE (TARGET_EXPR_SLOT (t)) = 1; } diff --git a/gcc/testsuite/c-c++-common/builtin-shufflevector-3.c b/gcc/testsuite/c-c++-common/torture/builtin-shufflevector-3.c similarity index 100% rename from gcc/testsuite/c-c++-common/builtin-shufflevector-3.c rename to gcc/testsuite/c-c++-common/torture/builtin-shufflevector-3.c