From patchwork Sat Aug 1 16:02:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleg Tolmatcev X-Patchwork-Id: 140387 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5EA74BA902D for ; Sat, 1 Aug 2026 16:03:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5EA74BA902D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=dYG4IjEb X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 956F54BA903B for ; Sat, 1 Aug 2026 16:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 956F54BA903B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 956F54BA903B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785600184; cv=none; b=ZNM89diWIvQ9sldZaibQa9X6nfX6Q01vH9dAsVwnpNo8GEAYXfyH40YaIiQGCCh82xtPKS6g0fuLPwYYZvyTPv4Wf9p5uKu5I3z88pWafpy/a6P7K+yHDtMW/3J2YA1fGgJEHNZOcwQ8LIXd3K1fxr2gF8QT6XSjnNwcwIvkwJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785600184; c=relaxed/simple; bh=nfQrgJTtTsVIAwX9KMHUW4POhT3NW03EW2CK/0LnmZ0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=F1Qoxn1ObG6/srXY05U3tRmQI8pNmkwoCaOOvmbsX3NzQJdUBYFeiVlC8kXM2Bl/FqjQvwhDkb/HuJ/8fcqGwXe0qqmikQvoMuBq4FoqIZxqQXec+BD8cwagUvRCB78Thsp8Vy3rEkQFikU5EIgDL/I5u+H2+KNeGNwiKf6OdrA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=dYG4IjEb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 956F54BA903B Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-47f71156e1aso1062636f8f.3 for ; Sat, 01 Aug 2026 09:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785600183; x=1786204983; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fD4OErZhoFk+BPohO9fcKtJVzmc8P5F3EbFaDZ55QeI=; b=dYG4IjEbDisfQ85cEaQpBULWRoX4X75S8PT0mEBn7kohmD1qLWXGEsgS6c4mBWyu7U bismHAWZjr9LAnjT2umDhx20VbCBHX0BzpQ6pAqII7WemdDZeWsNUaBtDXQZ15kxqmgT F/DhyrzWyjEZtTPMwzywquvgSisq6qMQmeor91928kTVDKPmnv8VeQmd75aqYIRrw8bX UxqKKelOTasnbCnSp68+CdziUA3f3hpX1XfkMeonWbQ1j7wwT9rz96yfxEGZd07Ej7In 1EiIaVfVDOkplooSJ74ZJ205um334HGYwquHGe9RWYEWNe6YVNB3y/DwzDN1tnC/jAJR UNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785600183; x=1786204983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fD4OErZhoFk+BPohO9fcKtJVzmc8P5F3EbFaDZ55QeI=; b=CBRoxFH/UF+Zyx+JBWFYKuww/PecaBuMGe+hZ0lIgOx1FmuGLxpCeR8lWe82C5eJ+P XWRvqSyyOX2jfwbcjXbufWE8L9rv0ZmtpYE1KKB2whSuGIq3EyI29MGC+7oSV4k4javt ZLEzm7+EJrr7vFx2WNXPj/3fuUK7P9OnEaOzteMrXKkJC3hs2yEGZZNmO4Qzh0q5qNZm tgJqcswdrqOxrEcZzDSvRI2ZBCAlXwWB9vs/D5Zor4/KabFGAV24Zr07uGs+aCvCzaa/ uJcsk/HMkUx/mtJy8EKYgdMwKpxfWRSHcZI5rQkM6auZArqI/hkNdJEtep0+DHRBM7NJ Ufdg== X-Gm-Message-State: AOJu0YyD9uP7UFOXpYxGG1imsLXYKezpOY7cP6deQXoy4yNLSR5Yxdg5 7ToZrF8P5qqX8d1lFDjgWo7Mz1o/ZEB34sPRgDUfULskWsbegKMw/ZiWquhDag== X-Gm-Gg: AR+sD13iwvxQBYT/PPGayYAcGXyr52xfKyq2f5jzZ+eG8TC/+kRvJ5Z451IH0erLYH3 ppu/7f9yHnpo/qAUelMDy6vnD8YkTDdL+yY8RR1YqLyVGoVL/963koV36MYtLgcXKubQsuy9LRV u2wOWrBR50GoK435tgDgsodzpt+FB9r72I9Tcb61VK5P4JJ3nxo0n5G3k6zXPbHvqPbEKrhanv7 Bh51jIW/cIHQSSbHrJHGKIdM4GsoQ3ZWbH+vRL1rzDJlxBzcwQS/PkdEDoqaIU40Gpg0aIzwdhe RwwinftGRe9rkOfQx0ydKTJAs3zIkcENMOF2xt5uw8Ey226dbdeq2qwgRywFnAKQDsgsv2dvfxd JrM29ZWlp/p2h9YR898S3xXOeOlucy4MquRZFJ07ipPV/WOmtHam1J+4qSOlWkjHcC4KpInOf5t ueD+6nSW8zSYniTlG2dLR+hECbKp1gOtUvDKDE4K7K2KGiHiaDnc56dS8/u8xidBGDn5a/CR1wU 6CDoEXZpRsNCnMl3Z6XKK60NQ2r4Y5H47UjDAOSmVc2V87oGwqDMpAxO6c= X-Received: by 2002:a05:6000:615:b0:47f:81af:1a3b with SMTP id ffacd0b85a97d-47fd72c4be9mr9076785f8f.22.1785600183491; Sat, 01 Aug 2026 09:03:03 -0700 (PDT) Received: from Mein-PC (p200300ed8f25390011cee7fff0232c36.dip0.t-ipconnect.de. [2003:ed:8f25:3900:11ce:e7ff:f023:2c36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a1240sm15988980f8f.36.2026.08.01.09.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 09:03:03 -0700 (PDT) From: Oleg Tolmatcev To: gdb-patches@sourceware.org Cc: Oleg Tolmatcev Subject: [PATCH] gdb/dap: stop setting CompletionItem.length Date: Sat, 1 Aug 2026 18:02:34 +0200 Message-ID: <20260801160233.79-2-oleg.tolmatcev@gmail.com> X-Mailer: git-send-email 2.55.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Do not set the CompletionItem.length field in completions responses. According to the DAP spec, length says how many characters the completion text should overwrite. It is not the length of the completion label, so using the label length here is wrong. --- gdb/python/lib/gdb/dap/completions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/python/lib/gdb/dap/completions.py b/gdb/python/lib/gdb/dap/completions.py index 5cc6e025ee5..fb8f078d046 100644 --- a/gdb/python/lib/gdb/dap/completions.py +++ b/gdb/python/lib/gdb/dap/completions.py @@ -49,7 +49,7 @@ def completions( completion = None if "completion" in mi_result: completion = mi_result["completion"] - result.append({"label": completion, "length": len(completion)}) + result.append({"label": completion}) # If `-complete' finds one match then `completion' and `matches' # will contain the same one match. if ( @@ -59,5 +59,5 @@ def completions( ): return {"targets": result} for match in mi_result["matches"]: - result.append({"label": match, "length": len(match)}) + result.append({"label": match}) return {"targets": result}